From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rob Herring <robh@kernel.org>, Ibrahim Tilki <Ibrahim.Tilki@analog.com>
Cc: jdelvare@suse.com, linux-kernel@vger.kernel.org,
krzysztof.kozlowski+dt@linaro.org, linux@roeck-us.net,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v8 3/4] dt-bindings: hwmon: Add bindings for max31760
Date: Fri, 9 Sep 2022 18:59:40 +0200 [thread overview]
Message-ID: <bd277041-db44-58c2-54f5-94f081a07f30@linaro.org> (raw)
In-Reply-To: <20220909164710.GA1537271-robh@kernel.org>
On 09/09/2022 18:47, Rob Herring wrote:
> On Fri, Sep 09, 2022 at 11:26:29AM -0500, Rob Herring wrote:
>> On Fri, 09 Sep 2022 16:37:17 +0300, Ibrahim Tilki wrote:
>>> Adding bindings for Analog Devices MAX31760 Fan-Speed Controller
>>>
>>> Signed-off-by: Ibrahim Tilki <Ibrahim.Tilki@analog.com>
>>> ---
>>> .../bindings/hwmon/adi,max31760.yaml | 44 +++++++++++++++++++
>>> 1 file changed, 44 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/hwmon/adi,max31760.yaml
>>>
>>
>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
>> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> ./Documentation/devicetree/bindings/hwmon/adi,max31760.yaml: error checking schema file
>
> Not sure why the error is useless ATM. I'm checking that.
>
> The problem is that 'reg' is a matrix and you need to either fully
> define it or use the simplified form for a single cell:
>
> reg:
> minimum: 0x50
> maximum: 0x57
I think this was in v7, so I understand that schema in that case expects
the third option from anyOf - #/single?
https://github.com/devicetree-org/dt-schema/blob/main/dtschema/meta-schemas/cell.yaml#L62
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-09-09 16:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 13:37 [PATCH v8 0/4] hwmon: Add max31760 fan speed controller Ibrahim Tilki
2022-09-09 13:37 ` [PATCH v8 1/4] drivers: hwmon: Add max31760 fan speed controller driver Ibrahim Tilki
2022-09-09 17:43 ` Guenter Roeck
2022-09-09 13:37 ` [PATCH v8 2/4] docs: hwmon: add max31760 documentation Ibrahim Tilki
2022-09-09 13:37 ` [PATCH v8 3/4] dt-bindings: hwmon: Add bindings for max31760 Ibrahim Tilki
2022-09-09 14:49 ` Krzysztof Kozlowski
2022-09-09 14:52 ` Guenter Roeck
2022-09-09 14:56 ` Krzysztof Kozlowski
2022-09-09 15:04 ` Guenter Roeck
2022-09-09 16:42 ` Krzysztof Kozlowski
2022-09-09 16:26 ` Rob Herring
2022-09-09 16:47 ` Rob Herring
2022-09-09 16:59 ` Krzysztof Kozlowski [this message]
2022-09-09 17:48 ` Tilki, Ibrahim
2022-09-10 8:10 ` Krzysztof Kozlowski
2022-09-09 13:37 ` [PATCH v8 4/4] MAINTAINERS: Add maintainer for hwmon/max31760 Ibrahim Tilki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd277041-db44-58c2-54f5-94f081a07f30@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Ibrahim.Tilki@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).