From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 451902690EC for ; Wed, 10 Dec 2025 15:52:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765381956; cv=none; b=fPRVprcIV/fZRGI4x70aBaIWdNZn9IJWqDorqdc4c5DmUlmG2XulGjB3STx+byDLNq77I4ZbrvukEVRe5CHm4Ugg6MAccfvZEwmlqRlX3zZLjiCr0VZBX1xbN/rO/ww5u5DqpQrk4RtgXC3rHzdeu3Qup50+sy7fcRnhRHIX4ak= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765381956; c=relaxed/simple; bh=Sy3rkYIAkT984AorK7upQDIq//OeA6DevD/fk0iMMAM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LA1HxEy3Z8cwBnWHOW3ZnevQh8EluyHLB4fEssVXT0uWvRBDHWllGHUmQ4XqIn/Z1t06WMDfxUqs5AzKL4cDVy/ia4j+sil3tnz/FErOlUCvjF9qty2A7JBK5eYDATyy9HQVCPV74aYbWLzWFGsuZr8fAKXMX95W1pC3j2yzihg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dqctR2k+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=So1WLXq0; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dqctR2k+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="So1WLXq0" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BA8wirF2308615 for ; Wed, 10 Dec 2025 15:52:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= PJy/hWRaHKDG88WN/vJ1UcLi9eIjuGmXlKYwBNenPpE=; b=dqctR2k+ZnmQqdT6 o5rcRVOD/O8kI2qs/6pFkA4TZ/87k+EoLTY8C2BjbGsFHIplbB3gmKQqru5qwjly +/Oh+JwUbyQENvD5Qcef58U5SdKCayaUPiApH/029ZeWPaWUuytiTNamiDwqiS05 TeAR81zuKoyvAJaomGIGvK1CZGELfLQxH3ljMxgvnwKJurPQXoUFROvfMvuAGM/b XQOiDhf5cagsKwtgLpC+9es2MfhDrPR71XchcwvpGBYMd0Ym5UPJU3PY6t5H1Wvf BchyolZzacYqjejm46l2iUX2dXCEbye0Qy5lpwfic+bTtW9BFOrPesP+EaWqlvMz z9Wy8A== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ay5tx17h0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 10 Dec 2025 15:52:34 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-299d221b749so131800615ad.3 for ; Wed, 10 Dec 2025 07:52:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765381953; x=1765986753; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PJy/hWRaHKDG88WN/vJ1UcLi9eIjuGmXlKYwBNenPpE=; b=So1WLXq05yGqqNFRvGuIlNYsfD7TIupu7v1frSGOp1Z9ysXEqDcRuzLaZ6IL0FLoJ5 nHYvyNjkagcoZk3ZRcQ0gzpCNZ67csosW3nW7A5T2E/Q6ZULOt/hqjTdxE9mIqYOZ62y Ppn/ENdv7UUgBYtNKzF+j6xSH1lIl+3/g7slEEsz5h+vrTVdPlau9MadXBm9/KEGX1V3 T5yxknXeCZNg4D2vW4U7S8qIcq5Wq0a2nTmVXu/maiVyQLJoVYHiTCEaai4uOMDgKE+3 HfGUlQ3fqFkw12lX2ejpjLvdZejbPUGaqjNasVRj7f3jLKzoKCF1pa0uxVQObxPxET85 hqkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765381953; x=1765986753; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PJy/hWRaHKDG88WN/vJ1UcLi9eIjuGmXlKYwBNenPpE=; b=fiDS0eEn/HJV15LSrWDYleO3PQCQNaKkFOfY0YrBXw/GEjCG6M41faVKsV8lkQqDQR uQ6hlJ7Hz/v4dnm+Z6DY2WrlQOXfIrZDb60cgUyckVsAVqpj2ZSoHDy5PVB5xRzjAzaQ HltIS+AbZRYUNqd2thMaEw6p4dTQdHJuuAisF5PtJzj+F+qM0SiN7sQmuPsLpxrRFYwk LNXe8mIBtjJofAvxywUXumDkFnbsYvLeTJULmZYQLHSETizGd/YxqJhx9l8XmHM0eTWA qazCM4iedcEHlNXGypF0Vsp58nimtyy5JBlW4F3hIOqpsl1OBvt3PHkARAxm0nL4RI3g snxA== X-Forwarded-Encrypted: i=1; AJvYcCWK1ql0hoJQoZAXHqWPX2ZUHz6qLaLowx7Y4CL3AMuGT+26+B19danXzeGSefYKb+MYUpng16bqA8eM@vger.kernel.org X-Gm-Message-State: AOJu0YxaP7ROwvIk4YeCVe14R8MeHd6Ls+fLSW+8dQone5UtZg54PeoO /Aafo18ooXfTYTvjU+McuYMmz4hW0DmJRIZfJ0xGm2UQGNAlSu0E+piTTd4PlKy5hIgjNaBRz8v i1o0Z4thT1Ic8meOYVZXWJmR/o1GjwKnB+8SJr1FzaIWzxint5DMMKVbG/qMjrRBF X-Gm-Gg: AY/fxX4/aF3FZmhiYnFx7EXzRv6kNMOkpWnf3AJmHLeVC17aFEKTfSOEB1HGxxnZgzB f9Q4r+EZt8pAFqrE39YAe0RPq9fK/OTKF/jNwNMrm5ffJZcxFURgsT6E65tKkjnksrGI+GzMTcl g32xEkcr5zjt6Jz60uoXiIdkflBMMHurzTr7OCd9a2nPX/U7zni3cG8eGvMo8QztxUT238Ri5w8 vbgIbAkqGytyuA6haMro0HkSAAq+F2u4vEnUHR+JtO/GjYNIgwrpeZbIeuVKC73H+j5wlp8rhYA pqxD+lEZjb6EkJqiArCwKbhbo/hCkRQCYiBQOQ52wJ3UkkNYni9ItKnOXpEAEVEl+MRwVVnbGY+ 6bsBLhK9qeUzDAL6Z8qxFswHrBA/qlVIZ1VVp X-Received: by 2002:a17:903:1a03:b0:294:cc8d:c0c2 with SMTP id d9443c01a7336-29ec22f5eaemr35571145ad.27.1765381952914; Wed, 10 Dec 2025 07:52:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IGgR0SmEbFzoaUp8IC339sYqgwpstSC6VT0zYYRqG/MrbWzQIXm8DtQk0x+2NkzuYsymN0sng== X-Received: by 2002:a17:903:1a03:b0:294:cc8d:c0c2 with SMTP id d9443c01a7336-29ec22f5eaemr35570695ad.27.1765381952378; Wed, 10 Dec 2025 07:52:32 -0800 (PST) Received: from [10.218.4.141] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29daeaab9b1sm187393045ad.77.2025.12.10.07.52.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Dec 2025 07:52:31 -0800 (PST) Message-ID: Date: Wed, 10 Dec 2025 21:22:27 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V1 2/3] dt-bindings: ufs: Document bindings for SA8255P UFS Host Controller To: Bjorn Andersson Cc: mani@kernel.org, alim.akhtar@samsung.com, avri.altman@wdc.com, bvanassche@acm.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, James.Bottomley@hansenpartnership.com, martin.petersen@oracle.com, quic_ahari@quicinc.com, linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251114145646.2291324-1-ram.dwivedi@oss.qualcomm.com> <20251114145646.2291324-3-ram.dwivedi@oss.qualcomm.com> Content-Language: en-US From: Ram Kumar Dwivedi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: o2weFvIPxu2aW8mHN5tstPCBXDEWuJ0v X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjEwMDEyOSBTYWx0ZWRfXwjtaEBSoUyyv xvcBxtb/Q2R0qHGF9d/5GO8Cz8ibNweGYo5YMplP5ZSKU1hRnxsgmYVHH1Y8hqDpljf/g6/caiX 3QgfVEI6Cct0nLp4jukPNl2MpnSopkT9X7j1fVbdCI5/ZBBiF446XscUyLHvLrZSkJccqAbhzg5 Q9qPFutOKXz2jml4OLVkkXRe5l9QTHNnaTygp6bwf85JjEHv+aFKAdcioTF15oVORgDH+nwQhxU OlEzqiIlPjyQarWnxcTyqd0CXCb/f+8Oyr8xAEj8MlfJXLSOBGpkeRKa+TIKCWmcED1GH6rYRk8 WiCwJsmDFOqHWFwY1PZ5DQUEQTEN23bdam+OLy6sDRu/vpOJW+tA97GUfYvaDy2W3gckK62YbcI qY1gmXfw5zOXOUXq/8vbf51gLk2xyg== X-Authority-Analysis: v=2.4 cv=dq7Wylg4 c=1 sm=1 tr=0 ts=69399742 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=gEfo2CItAAAA:8 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=I-uMcen_RorggYIV1ZkA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 a=sptkURWiP4Gy88Gu7hUp:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: o2weFvIPxu2aW8mHN5tstPCBXDEWuJ0v X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-10_01,2025-12-09_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 suspectscore=0 adultscore=0 malwarescore=0 spamscore=0 impostorscore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512100129 On 15-Nov-25 1:02 AM, Bjorn Andersson wrote: > On Fri, Nov 14, 2025 at 08:26:45PM +0530, Ram Kumar Dwivedi wrote: >> From: Ram Kumar Dwivedi >> >> Document the device tree bindings for UFS host controller on >> Qualcomm SA8255P platform which integrates firmware-managed >> resources. >> >> The platform firmware implements the SCMI server and manages >> resources such as the PHY, clocks, regulators and resets via the >> SCMI power protocol. As a result, the OS-visible DT only describes >> the controller’s MMIO, interrupt, IOMMU and power-domain interfaces. >> >> The generic "qcom,ufshc" and "jedec,ufs-2.0" compatible strings are >> removed from the binding, since this firmware managed design won't >> be compatible with the drivers doing full resource management. >> >> Co-developed-by: Anjana Hari >> Signed-off-by: Anjana Hari >> Signed-off-by: Ram Kumar Dwivedi >> --- >> .../bindings/ufs/qcom,sa8255p-ufshc.yaml | 63 +++++++++++++++++++ >> 1 file changed, 63 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/ufs/qcom,sa8255p-ufshc.yaml >> >> diff --git a/Documentation/devicetree/bindings/ufs/qcom,sa8255p-ufshc.yaml b/Documentation/devicetree/bindings/ufs/qcom,sa8255p-ufshc.yaml >> new file mode 100644 >> index 000000000000..3b31f6282feb >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/ufs/qcom,sa8255p-ufshc.yaml >> @@ -0,0 +1,63 @@ >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/ufs/qcom,sa8255p-ufshc.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm SA8255P UFS Host Controller >> + >> +maintainers: >> + - Ram Kumar Dwivedi >> + - Anjana Hari > > This should be @oss.qualcomm.com, or @qti.qualcomm.com, not > @quicinc.com. Hi Bjorn, Thanks for pointing this out. I’ve updated this in the latest patchset. Thanks, Ram. > >> + >> +properties: >> + compatible: >> + const: qcom,sa8255p-ufshc >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 1 >> + >> + iommus: >> + maxItems: 1 >> + >> + dma-coherent: >> + type: boolean >> + >> + power-domains: >> + maxItems: 1 >> + >> +required: >> + - compatible >> + - reg >> + - interrupts >> + - power-domains >> + - iommus >> + - dma-coherent >> + >> +allOf: >> + - $ref: ufs-common.yaml >> + >> +unevaluatedProperties: false >> + >> +examples: >> + - | >> + #include >> + >> + soc { >> + #address-cells = <2>; >> + #size-cells = <2>; >> + >> + ufshc@1d84000 { >> + compatible = "qcom,sa8255p-ufshc"; >> + reg = <0x0 0x01d84000 0x0 0x3000>; > > Drop the two 0x0 and you don't need to change address/size-cells. > > Regards, > Bjorn > >> + interrupts = ; >> + lanes-per-direction = <2>; >> + >> + iommus = <&apps_smmu 0x100 0x0>; >> + power-domains = <&scmi3_pd 0>; >> + dma-coherent; >> + }; >> + }; >> -- >> 2.34.1 >> >>