From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44D91C77B61 for ; Thu, 13 Apr 2023 23:38:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230184AbjDMXis (ORCPT ); Thu, 13 Apr 2023 19:38:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230205AbjDMXir (ORCPT ); Thu, 13 Apr 2023 19:38:47 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 998371FD0 for ; Thu, 13 Apr 2023 16:38:45 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id i6so9556672lfp.1 for ; Thu, 13 Apr 2023 16:38:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681429124; x=1684021124; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9vbMMdXY95qL6L45KCQ/10QOy2KjAwy0Dtcq5sO3Kp8=; b=d5OeolZdIjVg9vlm/Y6YTXtOJ08S2Vazotp9JCFKdto+O6x3DAatnWg+RjgcTc3Mj6 IXXLxyisehdJya3mgQK6ecYhyVf6XxbGeU8tttDDiZwLZO8lbNNeBZDrG1aUqJ+MG6iM PhSt3Ob058pEwVRY6aeugxhctNIjT2PZuGC5dEinW+mGg3eLyrcZLMkrvLWaJxPCbajk 0GLDSUgKetoMoXJ0dUOF75OQtR7B2St8SdeTsWaicUNEby4FQKi8wGGX+gLr2GA/eCCO g9BDnd8/RnR1pPOQlqJ1R8pd5pn/6pYaOa5QMAf+uGJbtw8uGASupr4rDYqcZ6Wum1mq /DZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681429124; x=1684021124; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9vbMMdXY95qL6L45KCQ/10QOy2KjAwy0Dtcq5sO3Kp8=; b=gPRoGsWT5GPy3fQBQ26fNCDprmyS71phYw5NgSh8Fbux7xd0j62v2oUbwvLzoMYkeh Edz8u9FUPEkZDa/boixDt9XNHdOytkxwa5hjWZCfHC7zJYoub2WjpuOCdatVqtOVCBTU +BvqfImYc5HGGkIn110w/CdQqeFuFmerqy3CgvrzUlQT96LufROsZzzQMS/sjprnCc4o 5zhNyJx+w3mNahbsZeKUeoD8NMtAoZGZNOafZ9LiLp9PqgeXRZ27D/5UNUEFJWvXJFim 8g6gbnAPyoVxECmR4p06X7BcpzedQtXUBRrnHaOqm7LNCx2oGy6dRcFpUp2Gc6ZmGZu3 gsbQ== X-Gm-Message-State: AAQBX9eC6DNHCMtLFRqrqfS3SF2BGgH3Y21krZw6CfNzGU5xcQDUy9nd tgb79BPKMCAByA3o4exiIoisDQ== X-Google-Smtp-Source: AKy350a0pU6DFdq6HyGx5oDdQCdXJIvlqz2vEQYEfimYppnwQw5jaUJSk+Zmdk6X6Fr3yIlyZ2CpAQ== X-Received: by 2002:ac2:4895:0:b0:4d5:a689:7580 with SMTP id x21-20020ac24895000000b004d5a6897580mr1494493lfc.47.1681429123910; Thu, 13 Apr 2023 16:38:43 -0700 (PDT) Received: from [192.168.1.101] (abyl123.neoplus.adsl.tpnet.pl. [83.9.31.123]) by smtp.gmail.com with ESMTPSA id f16-20020a19ae10000000b004ed88fe62fesm317306lfc.209.2023.04.13.16.38.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Apr 2023 16:38:43 -0700 (PDT) Message-ID: Date: Fri, 14 Apr 2023 01:38:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v2 3/3] arm64: dts: qcom: sa8155p-adp: Remove unneeded rgmii_phy information Content-Language: en-US To: Andrew Halaney , linux-kernel@vger.kernel.org Cc: agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org References: <20230413194020.1077857-1-ahalaney@redhat.com> <20230413194020.1077857-3-ahalaney@redhat.com> From: Konrad Dybcio In-Reply-To: <20230413194020.1077857-3-ahalaney@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 13.04.2023 21:40, Andrew Halaney wrote: > Using interrupts-extended already indicates what the interrupt-parent > is, so drop the explicit interrupt-parent. > > The comment about this being the phy-intr is not helpful either, since > this is the only interrupt in the phy node. > > Suggested-by: Konrad Dybcio > Signed-off-by: Andrew Halaney > --- Reviewed-by: Konrad Dybcio Konrad > > Changes since v1: > * New patch (Konrad) > > arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts > index ac52a8dfeba1..b65e0203d783 100644 > --- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts > +++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts > @@ -361,8 +361,7 @@ rgmii_phy: phy@7 { > compatible = "ethernet-phy-ieee802.3-c22"; > reg = <0x7>; > > - interrupt-parent = <&tlmm>; > - interrupts-extended = <&tlmm 124 IRQ_TYPE_EDGE_FALLING>; /* phy intr */ > + interrupts-extended = <&tlmm 124 IRQ_TYPE_EDGE_FALLING>; > device_type = "ethernet-phy"; > }; > };