* [PATCH] arm64: dts: imx8mp: Add DeWarp Engine DT node
@ 2023-05-15 16:32 Marek Vasut
2023-05-16 6:38 ` Alexander Stein
0 siblings, 1 reply; 4+ messages in thread
From: Marek Vasut @ 2023-05-15 16:32 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Marek Vasut, Conor Dooley, Fabio Estevam, Krzysztof Kozlowski,
Laurent Pinchart, NXP Linux Team, Pengutronix Kernel Team,
Richard Cochran, Rob Herring, Sascha Hauer, Shawn Guo, devicetree
Add DT node for the DeWarp Engine of the i.MX8MP.
Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Cc: NXP Linux Team <linux-imx@nxp.com>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Richard Cochran <richardcochran@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
---
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index 245c560674de7..b64c944eecf82 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -1534,6 +1534,16 @@ isi_in_1: endpoint {
};
};
+ dewarp: dwe@32e30000 {
+ compatible = "nxp,imx8mp-dw100";
+ reg = <0x32e30000 0x10000>;
+ interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clk IMX8MP_CLK_MEDIA_AXI_ROOT>,
+ <&clk IMX8MP_CLK_MEDIA_APB_ROOT>;
+ clock-names = "axi", "ahb";
+ power-domains = <&media_blk_ctrl IMX8MP_MEDIABLK_PD_DWE>;
+ };
+
mipi_csi_0: csi@32e40000 {
compatible = "fsl,imx8mp-mipi-csi2", "fsl,imx8mm-mipi-csi2";
reg = <0x32e40000 0x10000>;
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: imx8mp: Add DeWarp Engine DT node
2023-05-15 16:32 [PATCH] arm64: dts: imx8mp: Add DeWarp Engine DT node Marek Vasut
@ 2023-05-16 6:38 ` Alexander Stein
2023-05-16 8:06 ` Marek Vasut
0 siblings, 1 reply; 4+ messages in thread
From: Alexander Stein @ 2023-05-16 6:38 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Marek Vasut, Conor Dooley, Fabio Estevam, Krzysztof Kozlowski,
Laurent Pinchart, NXP Linux Team, Pengutronix Kernel Team,
Richard Cochran, Rob Herring, Sascha Hauer, Shawn Guo, devicetree,
Marek Vasut
Hi Marek,
Am Montag, 15. Mai 2023, 18:32:24 CEST schrieb Marek Vasut:
> Add DT node for the DeWarp Engine of the i.MX8MP.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
> Cc: NXP Linux Team <linux-imx@nxp.com>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Richard Cochran <richardcochran@gmail.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
While the node itself is okay, could you please add a patch for reordering the
other nodes in aips4 before adding dewarp? dwe@32e30000 should be at the top
after ISI (ISP not yet added).
Best regards,
Alexander
> ---
> arch/arm64/boot/dts/freescale/imx8mp.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mp.dtsi index
> 245c560674de7..b64c944eecf82 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -1534,6 +1534,16 @@ isi_in_1: endpoint {
> };
> };
>
> + dewarp: dwe@32e30000 {
> + compatible = "nxp,imx8mp-dw100";
> + reg = <0x32e30000 0x10000>;
> + interrupts = <GIC_SPI 100
IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clk
IMX8MP_CLK_MEDIA_AXI_ROOT>,
> + <&clk
IMX8MP_CLK_MEDIA_APB_ROOT>;
> + clock-names = "axi", "ahb";
> + power-domains = <&media_blk_ctrl
IMX8MP_MEDIABLK_PD_DWE>;
> + };
> +
> mipi_csi_0: csi@32e40000 {
> compatible = "fsl,imx8mp-mipi-csi2",
"fsl,imx8mm-mipi-csi2";
> reg = <0x32e40000 0x10000>;
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: imx8mp: Add DeWarp Engine DT node
2023-05-16 6:38 ` Alexander Stein
@ 2023-05-16 8:06 ` Marek Vasut
2023-05-16 8:17 ` Marek Vasut
0 siblings, 1 reply; 4+ messages in thread
From: Marek Vasut @ 2023-05-16 8:06 UTC (permalink / raw)
To: Alexander Stein, linux-arm-kernel
Cc: Conor Dooley, Fabio Estevam, Krzysztof Kozlowski,
Laurent Pinchart, NXP Linux Team, Pengutronix Kernel Team,
Richard Cochran, Rob Herring, Sascha Hauer, Shawn Guo, devicetree
On 5/16/23 08:38, Alexander Stein wrote:
> Hi Marek,
Hi,
> Am Montag, 15. Mai 2023, 18:32:24 CEST schrieb Marek Vasut:
>> Add DT node for the DeWarp Engine of the i.MX8MP.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> ---
>> Cc: Conor Dooley <conor+dt@kernel.org>
>> Cc: Fabio Estevam <festevam@gmail.com>
>> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
>> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
>> Cc: NXP Linux Team <linux-imx@nxp.com>
>> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
>> Cc: Richard Cochran <richardcochran@gmail.com>
>> Cc: Rob Herring <robh+dt@kernel.org>
>> Cc: Sascha Hauer <s.hauer@pengutronix.de>
>> Cc: Shawn Guo <shawnguo@kernel.org>
>> Cc: devicetree@vger.kernel.org
>> Cc: linux-arm-kernel@lists.infradead.org
>
> While the node itself is okay, could you please add a patch for reordering the
> other nodes in aips4 before adding dewarp? dwe@32e30000 should be at the top
> after ISI (ISP not yet added).
The sorting of nodes does not conflict with this change, so I'll send a
separate patch for that.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: imx8mp: Add DeWarp Engine DT node
2023-05-16 8:06 ` Marek Vasut
@ 2023-05-16 8:17 ` Marek Vasut
0 siblings, 0 replies; 4+ messages in thread
From: Marek Vasut @ 2023-05-16 8:17 UTC (permalink / raw)
To: Alexander Stein, linux-arm-kernel
Cc: Conor Dooley, Fabio Estevam, Krzysztof Kozlowski,
Laurent Pinchart, NXP Linux Team, Pengutronix Kernel Team,
Richard Cochran, Rob Herring, Sascha Hauer, Shawn Guo, devicetree
On 5/16/23 10:06, Marek Vasut wrote:
> On 5/16/23 08:38, Alexander Stein wrote:
>> Hi Marek,
>
> Hi,
>
>> Am Montag, 15. Mai 2023, 18:32:24 CEST schrieb Marek Vasut:
>>> Add DT node for the DeWarp Engine of the i.MX8MP.
>>>
>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>> ---
>>> Cc: Conor Dooley <conor+dt@kernel.org>
>>> Cc: Fabio Estevam <festevam@gmail.com>
>>> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
>>> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
>>> Cc: NXP Linux Team <linux-imx@nxp.com>
>>> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
>>> Cc: Richard Cochran <richardcochran@gmail.com>
>>> Cc: Rob Herring <robh+dt@kernel.org>
>>> Cc: Sascha Hauer <s.hauer@pengutronix.de>
>>> Cc: Shawn Guo <shawnguo@kernel.org>
>>> Cc: devicetree@vger.kernel.org
>>> Cc: linux-arm-kernel@lists.infradead.org
>>
>> While the node itself is okay, could you please add a patch for
>> reordering the
>> other nodes in aips4 before adding dewarp? dwe@32e30000 should be at
>> the top
>> after ISI (ISP not yet added).
>
> The sorting of nodes does not conflict with this change, so I'll send a
> separate patch for that.
Well that wasn't as easy as I thought, but oh well, V2 is out.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-05-16 8:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-15 16:32 [PATCH] arm64: dts: imx8mp: Add DeWarp Engine DT node Marek Vasut
2023-05-16 6:38 ` Alexander Stein
2023-05-16 8:06 ` Marek Vasut
2023-05-16 8:17 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).