From: Dan Murphy <dmurphy@ti.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: <f.fainelli@gmail.com>, <hkallweit1@gmail.com>,
<davem@davemloft.net>, <robh@kernel.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>
Subject: Re: [PATCH net-next v2 2/2] net: phy: DP83822: Add ability to advertise Fiber connection
Date: Mon, 13 Jul 2020 10:51:28 -0500 [thread overview]
Message-ID: <bd3580a2-a603-7d17-692c-2cb353ded865@ti.com> (raw)
In-Reply-To: <20200711184512.GR1014141@lunn.ch>
Andrew
On 7/11/20 1:45 PM, Andrew Lunn wrote:
>> +#define MII_DP83822_FIBER_ADVERTISE (SUPPORTED_AUI | SUPPORTED_FIBRE | \
>> + SUPPORTED_BNC | SUPPORTED_Pause | \
>> + SUPPORTED_Asym_Pause | \
>> + SUPPORTED_100baseT_Full)
>> +
>> + /* Setup fiber advertisement */
>> + err = phy_modify_changed(phydev, MII_ADVERTISE,
>> + ADVERTISE_1000XFULL |
>> + ADVERTISE_1000XPAUSE |
>> + ADVERTISE_1000XPSE_ASYM,
>> + MII_DP83822_FIBER_ADVERTISE);
> That looks very odd. SUPPORTED_AUI #define has nothing to do with
> MII_ADVERTISE register. It is not a bit you can read/write in that
> register.
ACK removed the SUPPORTED_AUI.
I also going to update the MII_DP83822_FIBER_ADVERTISE defines from
SUPPORTED_* to ADVERTISED_*
Dan
> Andrew
next prev parent reply other threads:[~2020-07-13 15:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 14:37 [PATCH net-next v2 0/2] DP83822 Fiber enablement Dan Murphy
2020-07-10 14:37 ` [PATCH net-next v2 1/2] dt-bindings: net: dp83822: Add TI dp83822 phy Dan Murphy
2020-07-13 15:36 ` Rob Herring
2020-07-10 14:37 ` [PATCH net-next v2 2/2] net: phy: DP83822: Add ability to advertise Fiber connection Dan Murphy
2020-07-11 18:45 ` Andrew Lunn
2020-07-13 15:51 ` Dan Murphy [this message]
2020-07-11 18:54 ` Andrew Lunn
2020-07-13 15:50 ` Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd3580a2-a603-7d17-692c-2cb353ded865@ti.com \
--to=dmurphy@ti.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).