From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3255DC3DA6E for ; Sat, 17 Dec 2022 10:55:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230249AbiLQKzo (ORCPT ); Sat, 17 Dec 2022 05:55:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230252AbiLQKzl (ORCPT ); Sat, 17 Dec 2022 05:55:41 -0500 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D151ABBC for ; Sat, 17 Dec 2022 02:55:40 -0800 (PST) Received: by mail-lf1-x12a.google.com with SMTP id p36so7128861lfa.12 for ; Sat, 17 Dec 2022 02:55:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dgeIfPkL/uAsGQYe43m14UGQ6KeF1AJBZCItoIswQjA=; b=TjaXqQvjIE4ADe59iDZUvuhgHC4c0qDSOPDIyMPQF9p5KFJ0kTheTCLpKt6ae7qFgZ g/E3ETklQKvtjMxVhJN4AhhxD17DH5XfaAPWq4K9C8l82EyCVnTlOcKKhiCgJHVruF+J rHiw7PQSHaDxK9cWnCmYUpXuBJHwUUljh3/TZdhkEpPXrY1TeG++Ft/J8DlCifrDPImu EkUmNi6/BEKy4J5kHk37vzJ77M/FyIt3g2Zxo8pdDZNDTbQ7oYt+HKWvnbJdChr5KKqu zhh61pgN9BAduUNFvbbatEByFNM0/qa9Tv3VwwzeifV8hbYVdmmz9bbyD3b14d5//6mx N5sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dgeIfPkL/uAsGQYe43m14UGQ6KeF1AJBZCItoIswQjA=; b=YckrKuB0GYZckm74sKEijs6r7D1HLmig291qqrW99ETxZR7H82RBZURZN8lqEaC6bn XN2WQtXjbOvoVuxA2NPFiALJovUvGU+NxmSMdWxLWe3jnpEc1oil1OXM57+IUQb6SDU7 bqYi9Fq6uUAaXfoBgzbzS40cb6zOUfSIw+0w3KA3I46e6f5Fqz7OFdx9w0tTEYSv34CW FMYH4d6GFFWFdG3YVLcd2tw0vxRsHdQPWCC6fiPb+KdPdXVFC/pYd7PE60o57N5D8NnK IA4DU3CsaxDh8aMrVQ1jPI6WHjJLMGSqHUIMF9ZuOHKvNiEFpJP/uqCd2FIQpyMlIk9P HDGA== X-Gm-Message-State: ANoB5pkUa7m8OXhVeXGtnywk9zkifDsF48roW5Dequdzwr/qFpp+vPuh XQH6WZBk6pYYP44pDCSn24PjQg== X-Google-Smtp-Source: AA0mqf6Bnxu9VFQRjM1hc7UoQnQPYgU8xl2tt1W7wzJI5NWV3jvwRu4cpAUIxaxvNjLiuseak8u1Bg== X-Received: by 2002:a19:5f0d:0:b0:4a4:68b9:608c with SMTP id t13-20020a195f0d000000b004a468b9608cmr10625310lfb.23.1671274539224; Sat, 17 Dec 2022 02:55:39 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id u10-20020a05651220ca00b0048a982ad0a8sm482085lfr.23.2022.12.17.02.55.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 17 Dec 2022 02:55:38 -0800 (PST) Message-ID: Date: Sat, 17 Dec 2022 11:55:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v1 2/6] dt-bindings: i2c: hpe,gxp-i2c Content-Language: en-US To: nick.hawkins@hpe.com, verdun@hpe.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, lee@kernel.org, linux@armlinux.org.uk, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20221216183532.78933-1-nick.hawkins@hpe.com> <20221216183532.78933-3-nick.hawkins@hpe.com> From: Krzysztof Kozlowski In-Reply-To: <20221216183532.78933-3-nick.hawkins@hpe.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 16/12/2022 19:35, nick.hawkins@hpe.com wrote: > From: Nick Hawkins > Subject: missing explanation what you are doing. Use `git log` to learn how this can be written. > Document binding to support I2C controller in GXP. > > Signed-off-by: Nick Hawkins > --- > .../devicetree/bindings/i2c/hpe,gxp-i2c.yaml | 63 +++++++++++++++++++ > 1 file changed, 63 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i2c/hpe,gxp-i2c.yaml > > diff --git a/Documentation/devicetree/bindings/i2c/hpe,gxp-i2c.yaml b/Documentation/devicetree/bindings/i2c/hpe,gxp-i2c.yaml > new file mode 100644 > index 000000000000..fa378e991fdb > --- /dev/null > +++ b/Documentation/devicetree/bindings/i2c/hpe,gxp-i2c.yaml > @@ -0,0 +1,63 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/i2c/hpe,gxp-i2c.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: HPE GXP SoC I2C Controller > + > +maintainers: > + - Nick Hawkins > + > +allOf: > + - $ref: /schemas/i2c/i2c-controller.yaml# > + > +properties: > + compatible: > + const: hpe,gxp-i2c > + > + '#address-cells': > + const: 1 Drop, it's coming from i2c-controller. > + > + interrupts: > + maxItems: 1 > + > + reg: > + maxItems: 1 > + > + hpe,i2c-max-bus-freq: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Desired frequency in Hz of the bus. No, there is existing property for this - clock-frequency. Do not invent own stuff. Even if this was accepted, you must use standard property suffixes. > + default: 100000 > + > + hpe,sysreg-phandle: Don't encode the type in property name. You do not call "reg" a "reg-uint32", right? or hpe,i2c-max-bus-freq-uint32? hpe,sysreg (unless you can name it more accurately) > + $ref: /schemas/types.yaml#/definitions/phandle > + description: Pandle to syscon used to control the system registers. > + > + '#size-cells': > + const: 0 Drop, it's coming from i2c-controller. Krzysztof