From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D359484226 for ; Wed, 19 Aug 2026 16:34:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787157289; cv=none; b=eGyGGij4tljZdCCTXr2c9P5YdVz0CzOoCtvbvDBdPcxHE+NQAt6mTu5UGkKk2QT/0tDSU5JPDsGlyWGSLX0pY0pU4s3XCgjloZRjJ4jNcA1VN/xJrmFij7nF9mkpttY+fSB740p+LsW6GuTQbZ3S58cmQ7WfUUPnizcCOA4+2Y0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787157289; c=relaxed/simple; bh=r0UdGZ6t8TSGFR4bNpVzGy/0hINZi61fPITnYokWDhQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nuzbl20ljCv3ElIQDKIW2ef9AyTkcThNj24bj6nQWyMEJpy3ySgzantBihPNIcvtthodbLzQOq3nyL6NCeq3uZRVTEtBSnzQz7mkTqfof6iovoeuCzW+3bPruMLADOuJkSYHjSEUAyTSqJf6olQANi43quBLHXXYsxC7aKyygus= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Ggs86ID4; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RvCLAYVq; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Ggs86ID4"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RvCLAYVq" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67JEbLRd067552 for ; Wed, 19 Aug 2026 16:34:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= TWy+ySCcYENBF17tSAyqwXm235v/+ZUFPPyXbMWLu7M=; b=Ggs86ID4PJGL30Mt 5kAtEey/7yZ6K1iDxnmZ/aSZXGSwUtHsdT4M60K0s2HdsBfgLhC3yo/i/x5hg8qc Trd5tCrHJWjWf0cMJML7UDIYGShD7OxYRlhLQSWT1GJ6lo7J6+8R9FQ8sQmH6BQu jzjjIOMmLjhlsmUa+RUUcnTSbVEplJ1gkvStMMX8fDnD93TpQtx8N9jUdiiubGem 4Y+s32OXS5cPCEFTAFGgKdYXeHampfR5aEJXc4iKxRi8OwVICstsHUipwKdLnHor NU3RfqPuUiAGiG/rBmF+Fb4EwjsqY0BpgcTZ+xFYh7HMLC1cZ/TOA9lyf34ahX5O 4SB9ng== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g5e5d0q50-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 19 Aug 2026 16:34:46 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-930bd2bfc45so40149985a.1 for ; Wed, 19 Aug 2026 09:34:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787157286; x=1787762086; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=TWy+ySCcYENBF17tSAyqwXm235v/+ZUFPPyXbMWLu7M=; b=RvCLAYVq32A7ZAaZyTAKdfepvFXjxe3YC1kXRM1D5wZf5CLSw8uAOaQQv5hA8hIM55 pwUeySopAGUj0cb4n0/ok77M/c5FqKx3w7MHnkQFSYmFvvVnI69H+iGrd14oZ2DZ8/Iz E2jlNhbnT3AHXp0luuUq+rwFyfx7MSabukdU1mpbBBepBy+5WbmlpKd4MpUUpWhTdyp4 nLKqeIGy6y+0ej6jJk1tieSypx3R8Iw1JF0Rkz8L5gzxlfUkW//kwGWsgLQDU1YsnsGF mObadlnr7dNRu8HUbDe4BkUW1MsgLL0FiZqyPRDZpwetT3guv9kpn7mJmfHgINPdzG7q UtXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787157286; x=1787762086; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=TWy+ySCcYENBF17tSAyqwXm235v/+ZUFPPyXbMWLu7M=; b=jZNFOJwwdtlXBqN0iRLstUGgVVxkjbJBZgSBDerv+gO+KI9HJ24LeI9pu/WWr57may 0PPTOlS0Wx7mziOV4kbTrxfrPIKwuB/hJQCLjTctg8inLhTOB1LER/z61w+wSAPk4CBM lFRIfND+nGCkBJLuv5phEhFPpx/cwTRj5sm+VJawU2t6gecBt/fRKnyOfpII7lZPykVo gjhqHHbraDIO7SH/paYZiBpwCznGKTxsGxUs4nBnAPvJgIQG2+ZscA1LHYLBd3oGCOMt U4pJa5E85qVO5hFZt9ZvZktqWKqei1Pa7n1yREHZk0hc6HAZj64xlc8HIE1KCkuVWNP+ 2AqA== X-Forwarded-Encrypted: i=1; AHgh+RoQST639i59SfUxrcCBcyVI+I0FuuC5W2Oc5VcYLBl2wlb/4xo+wZMy70Fe5N2nPl0SP1XLZko73qtJ@vger.kernel.org X-Gm-Message-State: AOJu0YzAP9OOF1VY/0HTDCjSYjAryJFAosw9dlO4NYHrML+2fu7Z7BYw lxZh1EqVs0+YQQx9fyIyi7dsn8CYvt+WwaQO1GFQPQjiyOOhJHzGOsGficYF8iiWKFJHbIks9EG mJ/ayehzr1lqXGFyerLUdIxqqiqj1ifua3MwthWDbdZHgERYUM98cVGSDezPVYixs X-Gm-Gg: AR+sD11uhhmDmeXS4RzDMRLQc98ebTZNPrYBHePNOu6iYXidIWOgLcTws755yo0Udln ejLgY2A4rGaoptDKn/+7eiWsPzrx/PD61+ATz9ZrT8NfqVmBmQM9KdzKrTeXxPdQUBGdPXfKBBH 4nrdK/1LB/LAAIwXA0HfvrU3QeVsKUKUKE01cRPzhbWbPJPW7+dfufb6lvc4fV+hC+Vruqobgeh Di8mTfiHBgakuf4AyoAZ+e51iFhZVdSVk1xrbpi2yjQ+m0EMMJa6OymwEEnxOF0+IrWOWqaZvqf DPlxRYjnYQJyvFrOmJONgpNUt28LLodAcd9aQwiutPNGyHdMC3+/HuN+fZvoXSQMThq4cXC6vA0 AvsM2gqvBXwEOLc8k+7rxlei5 X-Received: by 2002:a05:620a:8802:b0:930:a08c:cf9c with SMTP id af79cd13be357-9371e6803f4mr414223585a.2.1787157285696; Wed, 19 Aug 2026 09:34:45 -0700 (PDT) X-Received: by 2002:a05:620a:8802:b0:930:a08c:cf9c with SMTP id af79cd13be357-9371e6803f4mr414218485a.2.1787157285063; Wed, 19 Aug 2026 09:34:45 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c243c8e4482sm100845166b.1.2026.08.19.09.34.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Aug 2026 09:34:44 -0700 (PDT) Message-ID: Date: Wed, 19 Aug 2026 18:34:40 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/8] platform: arm64: qcom-hamoa-ec: Add fan RPM query and LUT calibration To: Anvesh Jain P , Sibi Sankar , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org References: <20260728-ec_add_more_commands-v1-0-771abd65ee1a@oss.qualcomm.com> <20260728-ec_add_more_commands-v1-4-771abd65ee1a@oss.qualcomm.com> <96411e0c-f357-40d5-81f8-14523836280e@oss.qualcomm.com> <438eeded-2f5c-41f0-a021-b5476fb16cb7@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <438eeded-2f5c-41f0-a021-b5476fb16cb7@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE5MDEyOCBTYWx0ZWRfX3OZGG0Lj/7h9 LRY4ksudynwbR5UNKMdAOwGI5gWzQ0sQc2P96M164UyspgSW1PoRZyV9g3HfuNz3Y2sTSk8GW+/ 4gw6482iDYbSjP+YOVqIfhEGRL9h5rQGReaTy4kIZtU0Vtz2c4oiHMHD8a2kGvewzOlOfHDi6HX rP4yf79ZspgfwinLTIP5miXM35LRnWDX6wRrDcCNYT4nu4+jflpfrxt+P6867P7YDaY8hvOLRUH bloYBnFASUFteylPlGjOCsK0YaY/B0k3nV3kznYLO3WnY3iLpSBvwLOKDaK/+CW4S7rawAS5b7/ zvyN7CONGWdfZl/o+ByLo08S2YLrGkMUlU9nTxyTttZQZRnd0Xc61j5uyNpgy85DtdtDCtA3l4l V846eQPFxXfm6s+SiZypult84E3vm/Fn4AX+JKHmAmPCgne/EC6Yzi4/Yih+LaAWnPIMvYjHzRV UAdQFaCgCu1PVeExWlA== X-Authority-Analysis: v=2.4 cv=cuOrVV4i c=1 sm=1 tr=0 ts=6a85db26 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=JpzDVA2CVgTy79lvUYkA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-ORIG-GUID: 7O-p0kxk4ex6pk4iXZezX4UyKKb5vs2U X-Proofpoint-GUID: 7O-p0kxk4ex6pk4iXZezX4UyKKb5vs2U X-Proofpoint-Spam-Info: AW1haW4tMjYwODE5MDEyOCBTYWx0ZWRfX5s0iIzIHBwMJ b3Dfu3vJ+qyOjwHZJjjswZFXKnJKPwbatwWp1WtLPEThJ79nDCTX295AyXsOZDTykDEe/TYfYiY YsTcfz44ZtxGTEQl/SXMrIbcYx2AuvE= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-19_04,2026-08-19_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 malwarescore=0 suspectscore=0 phishscore=0 clxscore=1015 lowpriorityscore=0 adultscore=0 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608190128 On 8/19/26 7:13 AM, Anvesh Jain P wrote: > > > On 7/30/2026 12:05 PM, Anvesh Jain P wrote: >> >> >> On 7/29/2026 4:37 PM, Konrad Dybcio wrote: >>> On 7/28/26 7:44 PM, Anvesh Jain P wrote: >>>> Add the EC command definitions and handler functions for querying fan >>>> RPM and programming per-fan LUTs (lookup tables mapping SoC >>>> temperature to target RPM), and introduce a raw i2c_transfer()-based >>>> transport for the two commands, since their variable-length, >>>> sub-command-addressed payloads don't fit the smbus block-data model >>>> used by the existing commands. >>>> >>>> Fan LUT geometry and temperature breakpoints vary by board, so encode >>>> them in per-compatible qcom_ec_lut_config data selected via >>>> device_get_match_data(). Add configs for the Hamoa CRD, Hamoa/Purwa >>>> IOT EVK, and Glymur CRD ECs; IOT EVK boards share the Hamoa LUT >>>> geometry but are bring-up platforms without a calibrated fan curve, >>>> so skip_lut_set suppresses the LUT-set command on those boards. >>> >>> So are we expecting every single laptop/device that utilizes a >>> compatible EC to require modifications to the driver here? >>> >> >> Yes, currently a new board does need a driver-side compatible + LUT >> config entry. Will check on the feasibility of moving the LUT >> geometry/curve data into devicetree instead so new boards don't require >> driver changes. Adding a specific way to write the configuration to the driver vs storing the entirety of configuration data in the driver are two very separate issues Konrad