From: Walker Chen <walker.chen@starfivetech.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor@kernel.org>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
Emil Renner Berthing <kernel@esmil.dk>,
"Emil Renner Berthing" <emil.renner.berthing@canonical.com>
Cc: <dmaengine@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-riscv@lists.infradead.org>
Subject: Re: [PATCH v2 1/3] dt-bindings: dma: snps,dw-axi-dmac: Add reset items
Date: Fri, 24 Feb 2023 21:09:07 +0800 [thread overview]
Message-ID: <bd4301c5-d79f-6ba5-a840-95b733d2d44e@starfivetech.com> (raw)
In-Reply-To: <36188e04-332f-e944-9c58-f6f2b74987da@linaro.org>
On 2023/2/24 18:51, Krzysztof Kozlowski wrote:
> On 24/02/2023 11:14, Walker Chen wrote:
>>>> resets:
>>>> - maxItems: 1
>>>> + maxItems: 2
>>>
>>> This breaks ABI and all other users. Test your changes before sending.
>>
>> I think 'minItems' should be added here. So like this:
>> resets:
>> minItems: 1
>> maxItems: 2
>>
>> Other platform/users will not be affected by this.
>
> Which will allow two resets on all platforms. Is this correct for these
> platforms? Do they have two resets?
>
In kernel 6.2, only two platforms use this DMA controller (see 'arch/arc/boot/dts/hsdk.dts' and 'arch/riscv/boot/dts/canaan/k210.dtsi').
There is one reset on k210, while there is no reset of DMA on hsdk at all.
If here minItems with value 1 is added and the value of maxItems is changed to 2, after my testing,
whether it is one reset or two resets, even no reset, there is no errors occur when doing dtbs_check,
the DMA initialization shall not be affected either on their platforms.
next prev parent reply other threads:[~2023-02-24 13:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 14:04 [PATCH v2 0/3] Add DMA driver for StarFive JH7110 SoC Walker Chen
2023-02-21 14:04 ` [PATCH v2 1/3] dt-bindings: dma: snps,dw-axi-dmac: Add reset items Walker Chen
2023-02-22 9:17 ` Krzysztof Kozlowski
2023-02-24 10:14 ` Walker Chen
2023-02-24 10:51 ` Krzysztof Kozlowski
2023-02-24 13:09 ` Walker Chen [this message]
2023-02-24 13:21 ` Krzysztof Kozlowski
2023-02-24 15:23 ` Walker Chen
2023-02-21 14:04 ` [PATCH v2 2/3] dmaengine: dw-axi-dmac: Add support for StarFive JH7110 DMA Walker Chen
2023-02-26 14:25 ` Emil Renner Berthing
2023-02-27 9:27 ` Walker Chen
2023-02-21 14:04 ` [PATCH v2 3/3] riscv: dts: starfive: add dma controller node Walker Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd4301c5-d79f-6ba5-a840-95b733d2d44e@starfivetech.com \
--to=walker.chen@starfivetech.com \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=emil.renner.berthing@canonical.com \
--cc=kernel@esmil.dk \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).