From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from freeshell.de (freeshell.de [116.202.128.144]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9261A1487E9; Tue, 17 Dec 2024 03:26:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=116.202.128.144 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734405975; cv=none; b=XGQuFFoY7nDBOm+dy6tRsNWx+QWWjVf3XukhppLsMWfmyBd22hGKRJi9bdtr6A+VoUYVRZv1BueH1XbZ3i7NdodrAc03ym+JqHMbVgkSznskki9356fyU+emliJZ2jnjcTa2AA9bMGXqTgu83OZzlKqtMvS3E9oB6sR8hKWVxJg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734405975; c=relaxed/simple; bh=sZOvuW1HEcRirxjW0tMfjBhBibKySg+ZlHH/e1Gv2yg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pL/JhdO2tKW1zz9lRoJnPDvtArYUho1CE/QscqONUUWjKKqxA0CsNAuVhbA1vLoy0OdPY/3iIdvCi9BS/uqSg3Gx9w+5vWHJyrMQEU1iON4dReqiFK2BCaThWPiu4GBNobFSdLwiUsfCeH/g9RGfRQhfPGmwbLEby8IDXdb46JA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=freeshell.de; spf=pass smtp.mailfrom=freeshell.de; arc=none smtp.client-ip=116.202.128.144 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=freeshell.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=freeshell.de Received: from [IPV6:2605:59c8:31de:bf00:37c2:fe62:c21b:ab46] (unknown [IPv6:2605:59c8:31de:bf00:37c2:fe62:c21b:ab46]) (Authenticated sender: e) by freeshell.de (Postfix) with ESMTPSA id 745A8B4B2470; Tue, 17 Dec 2024 04:26:01 +0100 (CET) Message-ID: Date: Mon, 16 Dec 2024 19:25:59 -0800 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] riscv: dts: starfive: jh7110-common: Use named definition for mmc1 card detect To: Hal Feng , Conor Dooley , Emil Renner Berthing , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Jianlong Huang , Jisheng Zhang Cc: Conor Dooley , "linux-riscv@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Emil Renner Berthing References: <20241210040652.164030-1-e@freeshell.de> <20241216-elixir-cupped-f7a83bce4e12@spud> Content-Language: en-US From: E Shattow In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Hal On 12/16/24 18:02, Hal Feng wrote: >> On 17.12.24 04:13, Conor Dooley wrote: >> On Mon, 09 Dec 2024 20:06:46 -0800, E Shattow wrote: >>> Use named definition for mmc1 card detect GPIO instead of numeric literal. >>> >>> >> >> Applied to riscv-dt-for-next, thanks! >> >> [1/1] riscv: dts: starfive: jh7110-common: Use named definition for mmc1 >> card detect >> https://git.kernel.org/conor/c/c96f15d79172 > > No, here "41" means the GPIO number, but GPI_SYS_SDIO1_CD means the > multiplexed function and should be used by pinctrl pinmux not gpio subsystem. > Although GPI-SYS_SDIO1_CD is numerically the same as 41. > > Best regards, > Hal You're right, Hal. I'm confused trying to make sense of this. From dts/upstream/src/riscv/starfive/jh7110-pinfunc.h: "gpio nr: gpio number, 0 - 63" And yet in dts/upstream/src/riscv/starfive/jh7110-common.dtsi there's: > pinmux = , > , > , > , > , > , > , > , > , > ; Loosely on the subject of MMC interface and GPIO numbering, what is the above code doing? These are not GPIO numbers 0-63 so what is this? I'm trying to understand this so I can write the Mars CM (-Lite) dts. Conor, and Hal: sorry for the mistake there. -E