From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D2A43126DF; Mon, 27 Oct 2025 15:44:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761579879; cv=none; b=mTbIUIM7xmYPhWpeiaN5H/KXscQUohKlOYoJ4gcgCo7leRmqTvebiOVEGUuA0bTy/U7VmLhVG0dyXO6ggqGPpBjyj9FWGmP4rNzK/w1tv/F3NofbCZJ3jpKHlT3BW3LEg1HUiY92zeKz9bX+w8SrS+rU/HnQ6o0LVaLNKVgD6Sg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761579879; c=relaxed/simple; bh=irqrm6uQuxnVppFGPRLF54t+DGlSHlPLRooV9JCjiDQ=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=kHUp+S5ZR7qAOcKCXMUpp3bv4lpMUeEI+ZY9WXk9se/Y6olALgJ8qsDboHC4ocrx2Ou5tdgUrKK5kK3aP/jlYeI3g3E6Ya9IkvzLegnfWN4JW+JF/UrAiVyHt5lYEH/5cQc05sH/HrbQNATvYWsfyxJmeQGuQ5z8v4sg+dZQqPU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cfetCQx8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cfetCQx8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 772A3C4CEF1; Mon, 27 Oct 2025 15:44:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1761579878; bh=irqrm6uQuxnVppFGPRLF54t+DGlSHlPLRooV9JCjiDQ=; h=Date:From:Subject:To:Cc:References:In-Reply-To:From; b=cfetCQx8JQRMhmIHEBzrut79SMh/LybtoUNESImySCl7bpvPebEdWExqAU9utDIcP X+2whTajAST3e+zKA79i59PzYOmSOf4DPFQLPYV3f8sVr0CErTzqjJkBwbgAMlZMR5 LTZWdv5h4L+HwMLvr4tM0n9avVnL4JwpUP+LtIDsRNTq99YLISW8vdBWbfUkjtGJto ncnL1ag8wQa7zB+Ey6BTPsCUgh7xVQsaCW1IFKOiLJ3GBNm3R0enr7EKKaDOdC7aQf KlRDC0kBM10OWUzN3COVPVf9LA2dqO3zwCETrcgd/ETa3X4aeqhw6lEA6owWPlP2nL ot8Yg9ZrNSixw== Message-ID: Date: Mon, 27 Oct 2025 16:44:30 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Hans Verkuil Subject: Re: [PATCH v5 06/23] staging: media: tegra-video: vi: adjust get_selection op check To: Svyatoslav Ryhel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , Prashant Gaikwad , Michael Turquette , Stephen Boyd , Mikko Perttunen , Mauro Carvalho Chehab , Greg Kroah-Hartman , =?UTF-8?Q?Jonas_Schw=C3=B6bel?= , Dmitry Osipenko , Charan Pedumuru , Diogo Ivo , Aaron Kling , Arnd Bergmann Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-clk@vger.kernel.org, linux-staging@lists.linux.dev References: <20251022142051.70400-1-clamor95@gmail.com> <20251022142051.70400-7-clamor95@gmail.com> Content-Language: en-US, nl In-Reply-To: <20251022142051.70400-7-clamor95@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Svyatoslav, On 22/10/2025 16:20, Svyatoslav Ryhel wrote: > Get_selection operation may be implemented only for sink pad and may > return error code. Set try_crop to 0 instead of returning error. Can you mention why try_crop is set to 0 instead of returning an error? That would be good to have in the commit log. And in fact, it's not clear to me either why you want this. > > Signed-off-by: Svyatoslav Ryhel > --- > drivers/staging/media/tegra-video/vi.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/media/tegra-video/vi.c b/drivers/staging/media/tegra-video/vi.c > index 7c44a3448588..856b7c18b551 100644 > --- a/drivers/staging/media/tegra-video/vi.c > +++ b/drivers/staging/media/tegra-video/vi.c > @@ -476,15 +476,11 @@ static int __tegra_channel_try_format(struct tegra_vi_channel *chan, > fse.code = fmtinfo->code; > ret = v4l2_subdev_call(subdev, pad, enum_frame_size, sd_state, &fse); > if (ret) { > - if (!v4l2_subdev_has_op(subdev, pad, get_selection)) { > + if (!v4l2_subdev_has_op(subdev, pad, get_selection) || > + v4l2_subdev_call(subdev, pad, get_selection, NULL, &sdsel)) { > try_crop->width = 0; > try_crop->height = 0; This looks all a bit magical. Which subdev is queried here? I.e. what is the corresponding subdev driver that implements get_selection? > } else { > - ret = v4l2_subdev_call(subdev, pad, get_selection, > - NULL, &sdsel); > - if (ret) > - return -EINVAL; > - > try_crop->width = sdsel.r.width; > try_crop->height = sdsel.r.height; > } It looks odd (esp. setting try_crop to 0), and I wonder if this code path has been tested. Regards, Hans