From: Markus Elfring <Markus.Elfring@web.de>
To: Pengyu Luo <mitltlatltl@gmail.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev,
kernel@pengutronix.de, Conor Dooley <conor+dt@kernel.org>,
Fabio Estevam <festevam@gmail.com>, Frank Li <Frank.Li@nxp.com>,
Hans Verkuil <hverkuil@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Martin Kepplinger-Novakovic <martink@posteo.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/5] media: hi846: fix hi846_write_reg_16 handling
Date: Mon, 11 May 2026 11:36:20 +0200 [thread overview]
Message-ID: <bd8e38d7-1010-4f04-8b28-38789596a502@web.de> (raw)
In-Reply-To: <20260511090924.269106-2-mitltlatltl@gmail.com>
…
> Fix this by resetting *err to 0 only when it is positive.
How do you think about to handle return values by an adjusted interface?
https://elixir.bootlin.com/linux/v7.1-rc2/source/drivers/media/i2c/hi846.c#L1265-L1282
Would a function signature (like the following) be nicer?
static int hi846_write_reg_16(struct hi846 *hi846, u16 reg, u16 val);
Regards,
Markus
next prev parent reply other threads:[~2026-05-11 9:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 9:09 [PATCH v3 0/5] fix and improve for Hi846 Pengyu Luo
2026-05-11 9:09 ` [PATCH v3 1/5] media: hi846: fix hi846_write_reg_16 handling Pengyu Luo
2026-05-11 9:36 ` Markus Elfring [this message]
2026-05-12 1:24 ` sashiko-bot
2026-05-11 9:09 ` [PATCH v3 2/5] media: hi846: fix link frequency handling Pengyu Luo
2026-05-11 10:42 ` Markus Elfring
2026-05-12 1:56 ` sashiko-bot
2026-05-11 9:09 ` [PATCH v3 3/5] media: hi846: fix modes handling for different lane cases Pengyu Luo
2026-05-12 2:35 ` sashiko-bot
2026-05-11 9:09 ` [PATCH v3 4/5] media: hi846: Add 6MP and 8MP modes support Pengyu Luo
2026-05-12 3:22 ` sashiko-bot
2026-05-11 9:09 ` [PATCH v3 5/5] arm64: dts: imx8mq-librem5: Correct link frequency list Pengyu Luo
2026-05-12 3:48 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd8e38d7-1010-4f04-8b28-38789596a502@web.de \
--to=markus.elfring@web.de \
--cc=Frank.Li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=hverkuil@kernel.org \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=martink@posteo.de \
--cc=mchehab@kernel.org \
--cc=mitltlatltl@gmail.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sakari.ailus@linux.intel.com \
--cc=sebastian.krzyszkowiak@puri.sm \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox