From: Yuanfang Zhang <quic_yuanfang@quicinc.com>
To: Leo Yan <leo.yan@arm.com>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@linaro.org>,
James Clark <james.clark@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
<kernel@oss.qualcomm.com>, <linux-arm-msm@vger.kernel.org>,
<coresight@lists.linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v9 2/2] coresight: add coresight Trace Network On Chip driver
Date: Wed, 11 Jun 2025 18:43:50 +0800 [thread overview]
Message-ID: <bd9a0216-ea87-4eeb-ac7f-14fcf3202bc8@quicinc.com> (raw)
In-Reply-To: <20250611100911.GT8020@e132581.arm.com>
On 6/11/2025 6:09 PM, Leo Yan wrote:
> On Wed, Jun 11, 2025 at 04:59:47PM +0800, Yuanfang Zhang wrote:
>> Add a driver to support Coresight device Trace Network On Chip (TNOC),
>> which is an integration hierarchy integrating functionalities of TPDA
>> and funnels. It aggregates the trace and transports to coresight trace
>> bus.
>>
>> Compared to current configuration, it has the following advantages:
>> 1. Reduce wires between subsystems.
>> 2. Continue cleaning the infrastructure.
>> 3. Reduce Data overhead by transporting raw data from source to target.
>>
>> +------------------------+ +-------------------------+
>> | Video Subsystem | |Video Subsystem |
>> | +-------------+ | | +------------+ |
>> | | Video TPDM | | | | Video TPDM | |
>> | +-------------+ | | +------------+ |
>> | | | | | |
>> | v | | v |
>> | +---------------+ | | +-----------+ |
>> | | Video funnel | | | |Video TNOC | |
>> | +---------------+ | | +-----------+ |
>> +------------|-----------+ +------------|------------+
>> | |
>> v-----+ |
>> +--------------------|---------+ |
>> | Multimedia v | |
>> | Subsystem +--------+ | |
>> | | TPDA | | v
>> | +----|---+ | +---------------------+
>> | | | | Aggregator TNOC |
>> | | | +----------|----------+
>> | +-- | |
>> | | | |
>> | | | |
>> | +------v-----+ | |
>> | | Funnel | | |
>> | +------------+ | |
>> +----------------|-------------+ |
>> | |
>> v v
>> +--------------------+ +------------------+
>> | Coresight Sink | | Coresight Sink |
>> +--------------------+ +------------------+
>>
>> Current Configuration TNOC
>>
>> Signed-off-by: Yuanfang Zhang <quic_yuanfang@quicinc.com>
>
> I observed a merging conflict. I would suggest you sticking to the
> coresight next branch for CoreSight related upstreaming. Please
> rebase this patch on it.
>
> https://git.kernel.org/pub/scm/linux/kernel/git/coresight/linux.git
> branch: next
>
> I also verified this patch with static checker smatch. With rebasing:
>
> Reviewed-by: Leo Yan <leo.yan@arm.com>
Done in next patch.
prev parent reply other threads:[~2025-06-11 10:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 8:59 [PATCH v9 0/2] coresight: Add Coresight Trace Network On Chip driver Yuanfang Zhang
2025-06-11 8:59 ` [PATCH v9 1/2] dt-bindings: arm: Add device Trace Network On Chip definition Yuanfang Zhang
2025-06-11 8:59 ` [PATCH v9 2/2] coresight: add coresight Trace Network On Chip driver Yuanfang Zhang
2025-06-11 10:09 ` Leo Yan
2025-06-11 10:43 ` Yuanfang Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd9a0216-ea87-4eeb-ac7f-14fcf3202bc8@quicinc.com \
--to=quic_yuanfang@quicinc.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=james.clark@linaro.org \
--cc=kernel@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=leo.yan@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.leach@linaro.org \
--cc=robh@kernel.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox