From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Saravanan Sekar <saravanan@linumiz.com>,
Guenter Roeck <linux@roeck-us.net>
Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, marten.lindahl@axis.com,
jdelvare@suse.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org
Subject: Re: [PATCH v2 2/4] dt-bindings: hwmon/pmbus: Add mps,mpq7932 power-management IC
Date: Thu, 1 Dec 2022 17:43:29 +0100 [thread overview]
Message-ID: <bdab2e58-ea12-0ccf-a25a-ed89e50a5332@linaro.org> (raw)
In-Reply-To: <8228db8d-2a32-1d23-74f3-05b9fe529a82@linumiz.com>
On 01/12/2022 17:38, Saravanan Sekar wrote:
>>>> Plus additional comment for the driver (and related to bindings) was
>>>> that this is not hwmon but a regulator driver. Why putting regulator
>>>> driver in hwmon?
>>>>
>>>
>>> Turns out this is primarily a hardware monitoring driver, like the drivers
>>> for all other PMBus chips. Regulator support is actually optional; the driver
>>> works perfectly well with CONFIG_REGULATOR=n (except that it needs some
>>> #ifdefs to address that situation).
>>
>> OK, this would explain location of the driver. However the bindings are
>> saying:
>> "Monolithic Power System MPQ7932 PMIC"
>> and PMIC is not mainly a hwmon device, even if it has such capabilities.
>> It might be missing description and proper title... or might be misplaced.
>>
>
> Indeed it is PMIC chip. I think this is not the first and not sure title
> has to be changed for hwmon subsystem.
>
> bindings/hwmon/pmbus/ti,lm25066.yaml
> title: National Semiconductor/Texas Instruments LM250x6/LM506x
> power-management ICs
Then I propose to put it in regulator directory.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-12-01 16:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 4:46 [PATCH v2 0/4] Add support for mpq7932 PMIC IC Saravanan Sekar
2022-12-01 4:46 ` [PATCH v2 1/4] hwmon: pm_bus: core: Add min_uV in pmbus regulator helper macro Saravanan Sekar
2022-12-01 4:46 ` [PATCH v2 2/4] dt-bindings: hwmon/pmbus: Add mps,mpq7932 power-management IC Saravanan Sekar
2022-12-01 10:26 ` Krzysztof Kozlowski
2022-12-01 11:29 ` Saravanan Sekar
2022-12-01 11:38 ` Krzysztof Kozlowski
2022-12-01 15:37 ` Guenter Roeck
2022-12-01 15:57 ` Saravanan Sekar
2022-12-01 16:15 ` Krzysztof Kozlowski
2022-12-01 16:38 ` Saravanan Sekar
2022-12-01 16:43 ` Krzysztof Kozlowski [this message]
2022-12-01 16:52 ` Saravanan Sekar
2022-12-01 17:00 ` Krzysztof Kozlowski
2022-12-01 13:36 ` Rob Herring
2022-12-01 16:16 ` Krzysztof Kozlowski
2022-12-01 4:46 ` [PATCH v2 3/4] hwmon: (pmbus/mpq7932) Add a support for mpq7932 Power Management IC Saravanan Sekar
2022-12-01 10:26 ` Krzysztof Kozlowski
2022-12-01 11:36 ` Saravanan Sekar
2022-12-01 15:34 ` Guenter Roeck
[not found] ` <6773256d-2842-fadc-1222-f76e0b495eda@linumiz.com>
2022-12-07 4:46 ` Guenter Roeck
2022-12-01 4:46 ` [PATCH v2 4/4] MAINTAINERS: Update the entry for MPQ7932 PMIC driver Saravanan Sekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdab2e58-ea12-0ccf-a25a-ed89e50a5332@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=marten.lindahl@axis.com \
--cc=robh+dt@kernel.org \
--cc=saravanan@linumiz.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).