From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Elvis.Wang" <Elvis.Wang@mediatek.com>,
Jassi Brar <jassisinghbrar@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: "jason-jh . lin" <jason-jh.lin@mediatek.com>,
Yongqiang Niu <yongqiang.niu@mediatek.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v3 1/2] dt-bindings: gce: add gce header file for mt8188
Date: Sun, 6 Nov 2022 11:27:58 +0100 [thread overview]
Message-ID: <bdb46b7c-6e08-26cf-491d-ca68d36f29af@linaro.org> (raw)
In-Reply-To: <20221104074443.26172-2-Elvis.Wang@mediatek.com>
On 04/11/2022 08:44, Elvis.Wang wrote:
> From: Elvis Wang <Elvis.Wang@mediatek.com>
>
> add gce header file to define the gce thread priority, gce subsys id,
> event and constant for mt8188.
>
> Signed-off-by: Elvis Wang <Elvis.Wang@mediatek.com>
> ---
> Thanks for the reviews, I have removed the incorrect reviewed message.
> ---
> include/dt-bindings/gce/mediatek,mt8188-gce.h | 966 ++++++++++++++++++
> 1 file changed, 966 insertions(+)
> create mode 100644 include/dt-bindings/gce/mediatek,mt8188-gce.h
>
> diff --git a/include/dt-bindings/gce/mediatek,mt8188-gce.h b/include/dt-bindings/gce/mediatek,mt8188-gce.h
> new file mode 100644
> index 000000000000..e2e2c56016a1
> --- /dev/null
> +++ b/include/dt-bindings/gce/mediatek,mt8188-gce.h
What is a "gce" subsystem or type of hardware? Why do you put headers in
"gce"?
Don't continue this pattern. Mediatek devices do not get specific folders...
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-06 10:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221104074443.26172-1-Elvis.Wang@mediatek.com>
[not found] ` <20221104074443.26172-2-Elvis.Wang@mediatek.com>
2022-11-04 9:12 ` [PATCH v3 1/2] dt-bindings: gce: add gce header file for mt8188 AngeloGioacchino Del Regno
2022-11-06 10:27 ` Krzysztof Kozlowski [this message]
2022-11-07 11:18 ` Matthias Brugger
2022-11-22 9:10 ` Elvis Wang (王军)
2022-11-22 9:25 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdb46b7c-6e08-26cf-491d-ca68d36f29af@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Elvis.Wang@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=jason-jh.lin@mediatek.com \
--cc=jassisinghbrar@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=yongqiang.niu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).