From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Kathiravan Thirumoorthy
<kathiravan.thirumoorthy@oss.qualcomm.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/6] arm64: dts: qcom: ipq6018: Add the IMEM node
Date: Tue, 8 Jul 2025 16:19:51 +0200 [thread overview]
Message-ID: <bdb5e19c-dbab-4ea3-9a6d-a4ac795fb43a@oss.qualcomm.com> (raw)
In-Reply-To: <20250708-imem-v2-3-692eb92b228e@oss.qualcomm.com>
On 7/8/25 7:39 AM, Kathiravan Thirumoorthy wrote:
> Add the IMEM node to the device tree to extract debugging information
> like system restart reason, which is populated via IMEM. Define the
> IMEM region to enable this functionality.
>
> As described, overall IMEM region is 32KB but only initial 4KB is
> accessible by all masters in the SoC.
>
> Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
> ---
> Changes in v2:
> - Rounded off the size to 0x8000 (Konrad)
> - Represent the reg's address space in hexadecimal format (Krzysztof)
> ---
> In 'ranges' property 0 is used instead of 0x0 to align with the existing
> format.
> ---
> arch/arm64/boot/dts/qcom/ipq6018.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> index bfe59b0208415902c69fd0c0c7565d97997d4207..3b9e40045906b26b94e2d2510b0570d3eaf084ce 100644
> --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> @@ -659,6 +659,15 @@ qpic_nand: nand-controller@79b0000 {
> status = "disabled";
> };
>
> + sram@8600000 {
> + compatible = "qcom,ipq6018-imem", "syscon", "simple-mfd";
> + reg = <0x0 0x08600000 0x0 0x8000>;
> + ranges = <0 0 0x08600000 0x8000>;
> +
> + #address-cells = <1>;
> + #size-cells = <1>;
> + };
On this platform, shouldn't it be 0x6860_0000?
Konrad
next prev parent reply other threads:[~2025-07-08 14:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-08 5:39 [PATCH v2 0/6] Describe the IMEM present in Qualcomm IPQ SoC's Kathiravan Thirumoorthy
2025-07-08 5:39 ` [PATCH v2 1/6] dt-bindings: sram: qcom,imem: Document Qualcomm IPQ SoC's IMEM compatibles Kathiravan Thirumoorthy
2025-07-08 5:39 ` [PATCH v2 2/6] arm64: dts: qcom: ipq8074: Add the IMEM node Kathiravan Thirumoorthy
2025-07-08 6:47 ` Krzysztof Kozlowski
2025-07-08 10:19 ` Kathiravan Thirumoorthy
2025-07-08 14:19 ` Konrad Dybcio
2025-07-08 5:39 ` [PATCH v2 3/6] arm64: dts: qcom: ipq6018: " Kathiravan Thirumoorthy
2025-07-08 14:19 ` Konrad Dybcio [this message]
2025-07-09 4:28 ` Kathiravan Thirumoorthy
2025-07-18 11:45 ` Konrad Dybcio
2025-07-08 5:39 ` [PATCH v2 4/6] arm64: dts: qcom: ipq5018: " Kathiravan Thirumoorthy
2025-07-08 14:20 ` Konrad Dybcio
2025-07-08 5:39 ` [PATCH v2 5/6] arm64: dts: qcom: ipq9574: " Kathiravan Thirumoorthy
2025-07-08 14:21 ` Konrad Dybcio
2025-07-08 5:39 ` [PATCH v2 6/6] arm64: dts: qcom: ipq5332: " Kathiravan Thirumoorthy
2025-07-08 14:21 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdb5e19c-dbab-4ea3-9a6d-a4ac795fb43a@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kathiravan.thirumoorthy@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).