devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [RFC PATCH 0/6] Add platform device SVM support for ARM SMMUv3
@ 2017-08-31  8:20 Yisheng Xie
  2017-08-31  8:20 ` [RFC PATCH 1/6] dt-bindings: document stall and PASID properties for IOMMU masters Yisheng Xie
                   ` (3 more replies)
  0 siblings, 4 replies; 30+ messages in thread
From: Yisheng Xie @ 2017-08-31  8:20 UTC (permalink / raw)
  To: jean-philippe.brucker-5wv7dgnIgG8
  Cc: mark.rutland-5wv7dgnIgG8, devicetree-u79uwXL29TY76Z2rM5mHXA,
	lv.zheng-ral2JQCrhuEAvxtiuMwx3w, will.deacon-5wv7dgnIgG8,
	rjw-LthD3rsA81gm4RdzfppkhA, robert.moore-ral2JQCrhuEAvxtiuMwx3w,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	linux-acpi-u79uwXL29TY76Z2rM5mHXA,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A, xieyisheng-hv44wF8Li93QT0dZR+AlfA,
	sudeep.holla-5wv7dgnIgG8, chenjiankang1-hv44wF8Li93QT0dZR+AlfA,
	devel-E0kO6a4B6psdnm+yROfE0A,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	lenb-DgEjT+Ai2ygdnm+yROfE0A

Jean-Philippe has post a patchset for Adding PCIe SVM support to ARM SMMUv3:
https://www.spinics.net/lists/arm-kernel/msg565155.html

But for some platform devices(aka on-chip integrated devices), there is also
SVM requirement, which works based on the SMMU stall mode.
Jean-Philippe has prepared a prototype patchset to support it:
git://linux-arm.org/linux-jpb.git svm/stall

We tested this patchset with some fixes on a on-chip integrated device. The
basic function is ok, so I just send them out for review, although this
patchset heavily depends on the former patchset (PCIe SVM support for ARM
SMMUv3), which is still under discussion.

Patch Overview:
*1 to 3 prepare for device tree or acpi get the device stall ability and pasid bits
*4 is to realise the SVM function for platform device
*5 is fix a bug when test SVM function while SMMU donnot support this feature
*6 avoid ILLEGAL setting of STE and CD entry about stall

Acctually here, I also have a question about SVM on SMMUv3:

1. Why the SVM feature on SMMUv3 depends on BTM feature? when bind a task to device,
   it will register a mmu_notify. Therefore, when a page range is invalid, we can
   send TLBI or ATC invalid without BTM?

2. According to ACPI IORT spec, named component specific data has a node flags field
   whoes bit0 is for Stall support. However, it do not have any field for pasid bit.
   Can we use other 5 bits[5:1] for pasid bit numbers, so we can have 32 pasid bit for
   a single platform device which should be enough, because SMMU only support 20 bit pasid

3. Presently, the pasid is allocate for a task but not for a context, if a task is trying
   to bind to 2 device A and B:
     a) A support 5 pasid bits
     b) B support 2 pasid bits
     c) when the task bind to device A, it allocate pasid = 16
     d) then it must be fail when trying to bind to task B, for its highest pasid is 4.
   So it should allocate a single pasid for a context to avoid this?


Jean-Philippe Brucker (3):
  dt-bindings: document stall and PASID properties for IOMMU masters
  iommu/of: Add stall and pasid properties to iommu_fwspec
  iommu/arm-smmu-v3: Add SVM support for platform devices

Yisheng Xie (3):
  ACPI: IORT: Add stall and pasid properties to iommu_fwspec
  iommu/arm-smmu-v3: fix panic when handle stall mode irq
  iommu/arm-smmu-v3: Avoid ILLEGAL setting of STE.S1STALLD and CD.S

 Documentation/devicetree/bindings/iommu/iommu.txt |  13 ++
 drivers/acpi/arm64/iort.c                         |  20 ++
 drivers/iommu/arm-smmu-v3.c                       | 230 ++++++++++++++++++----
 drivers/iommu/of_iommu.c                          |  11 +
 include/acpi/actbl2.h                             |   5 +
 include/linux/iommu.h                             |   2 +
 6 files changed, 244 insertions(+), 37 deletions(-)

--
1.7.12.4

^ permalink raw reply	[flat|nested] 30+ messages in thread

end of thread, other threads:[~2017-09-13 17:11 UTC | newest]

Thread overview: 30+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-31  8:20 [RFC PATCH 0/6] Add platform device SVM support for ARM SMMUv3 Yisheng Xie
2017-08-31  8:20 ` [RFC PATCH 1/6] dt-bindings: document stall and PASID properties for IOMMU masters Yisheng Xie
     [not found]   ` <1504167642-14922-2-git-send-email-xieyisheng1-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2017-09-05 12:52     ` Jean-Philippe Brucker
2017-08-31  8:20 ` [RFC PATCH 3/6] ACPI: IORT: Add stall and pasid properties to iommu_fwspec Yisheng Xie
     [not found] ` <1504167642-14922-1-git-send-email-xieyisheng1-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2017-08-31  8:20   ` [RFC PATCH 2/6] iommu/of: " Yisheng Xie
     [not found]     ` <1504167642-14922-3-git-send-email-xieyisheng1-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2017-09-05 12:52       ` Jean-Philippe Brucker
2017-08-31  8:20   ` [RFC PATCH 4/6] iommu/arm-smmu-v3: Add SVM support for platform devices Yisheng Xie
     [not found]     ` <1504167642-14922-5-git-send-email-xieyisheng1-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2017-09-05 12:53       ` Jean-Philippe Brucker
2017-09-06  0:51         ` Bob Liu
2017-09-06  1:20           ` Yisheng Xie
2017-08-31  8:20   ` [RFC PATCH 5/6] iommu/arm-smmu-v3: fix panic when handle stall mode irq Yisheng Xie
2017-09-05 12:53     ` Jean-Philippe Brucker
2017-08-31  8:20   ` [RFC PATCH 6/6] iommu/arm-smmu-v3: Avoid ILLEGAL setting of STE.S1STALLD and CD.S Yisheng Xie
     [not found]     ` <1504167642-14922-7-git-send-email-xieyisheng1-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2017-09-05 12:54       ` Jean-Philippe Brucker
2017-09-06  2:23         ` Yisheng Xie
     [not found]         ` <738977bb-4cd7-7d86-0ea0-0c88b6af721c-5wv7dgnIgG8@public.gmane.org>
2017-09-13  3:06           ` Will Deacon
2017-09-13 10:11             ` Yisheng Xie
     [not found]               ` <2f952821-afc3-46dd-17eb-40e8626bd6e5-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2017-09-13 15:47                 ` Jean-Philippe Brucker
2017-09-13 17:11               ` Will Deacon
2017-09-05 12:56   ` [RFC PATCH 0/6] Add platform device SVM support for ARM SMMUv3 Jean-Philippe Brucker
     [not found]     ` <95d1a9e2-1816-ff7d-9a8d-98406a6c2c22-5wv7dgnIgG8@public.gmane.org>
2017-09-06  1:02       ` Bob Liu
2017-09-06  9:57         ` Jean-Philippe Brucker
     [not found]           ` <2874a1f3-22f1-20d4-4009-50add127a10f-5wv7dgnIgG8@public.gmane.org>
2017-09-07  1:41             ` Bob Liu
     [not found]               ` <1d358989-48bb-ccde-d7d9-36e004bc2d78-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2017-09-07 16:32                 ` Jean-Philippe Brucker
2017-09-13  1:11             ` Bob Liu
2017-09-06  1:16       ` Yisheng Xie
2017-09-06  9:59         ` Jean-Philippe Brucker
     [not found]           ` <fd4200c1-3c89-23f1-a2b1-6457ef8475c1-5wv7dgnIgG8@public.gmane.org>
2017-09-07  1:55             ` Bob Liu
2017-09-07 16:30               ` Jean-Philippe Brucker
2017-09-06  1:24 ` Hanjun Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).