From mboxrd@z Thu Jan 1 00:00:00 1970 From: Faiz Abbas Subject: Re: [PATCH v2 5/6] ARM: dts: Add generic interconnect target module node for MCAN Date: Thu, 31 May 2018 16:56:46 +0530 Message-ID: References: <20180530141133.3711-1-faiz_abbas@ti.com> <20180530141133.3711-6-faiz_abbas@ti.com> <20180531040638.GA26751@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180531040638.GA26751@rob-hp-laptop> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Rob Herring Cc: devicetree@vger.kernel.org, paul@pwsan.com, tony@atomide.com, linux-kernel@vger.kernel.org, t-kristo@ti.com, bcousson@baylibre.com, linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org Hi, On Thursday 31 May 2018 09:36 AM, Rob Herring wrote: > On Wed, May 30, 2018 at 07:41:32PM +0530, Faiz Abbas wrote: >> The ti-sysc driver provides support for manipulating the idlemodes >> and interconnect level resets. >> >> Add the generic interconnect target module node for MCAN to support >> the same. >> >> CC: Tony Lindgren >> Signed-off-by: Faiz Abbas >> --- >> arch/arm/boot/dts/dra76x.dtsi | 19 +++++++++++++++++++ >> 1 file changed, 19 insertions(+) >> >> diff --git a/arch/arm/boot/dts/dra76x.dtsi b/arch/arm/boot/dts/dra76x.dtsi >> index bfc82636999c..57b8dc0fe719 100644 >> --- a/arch/arm/boot/dts/dra76x.dtsi >> +++ b/arch/arm/boot/dts/dra76x.dtsi >> @@ -11,6 +11,25 @@ >> / { >> compatible = "ti,dra762", "ti,dra7"; >> >> + ocp { >> + >> + target-module@0x42c00000 { > > Build your dtb with W=1 and fix warnings you add (drop '0x'). Sure, Will fix this. > > This is a CAN bus controller? If so, then use 'can' for node name. Yes but I am using m_can along the lines of dcan in other boards (For example, see arch/arm/boot/dts/am33xx.dtsi:1046). Are you saying all CAN controllers should only be called can? Thanks, Faiz