From: Matti Vaittinen <mazziesaccount@gmail.com>
To: Conor Dooley <conor@kernel.org>
Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] dt-bindings: ROHM KX134ACR-LBZ
Date: Fri, 15 Nov 2024 08:15:34 +0200 [thread overview]
Message-ID: <be11e656-a8be-4603-bd8f-01e3bdc56677@gmail.com> (raw)
In-Reply-To: <20241114-afterlife-ride-08068767f1e4@spud>
On 14/11/2024 22:10, Conor Dooley wrote:
> On Wed, Nov 13, 2024 at 01:20:49PM +0200, Matti Vaittinen wrote:
>> Add compatible and information for ROHM KX134ACR-LBZ accelerometer.
>
> The commit message mention what makes this device incompatible - but
> I'll let you away with it the description below contains it.
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
Thanks for pointing it out Conor. I agree the commit message should
describe the KX134ACR-LBZ a bit better. I'll improve the commit message
to include the g-range difference if I re-spin this series - and try to
remember this if I get to support also some other variants :) A very
good head's up for me as I didn't even think of describing the
differences in commit message!
Yours,
-- Matti
next prev parent reply other threads:[~2024-11-15 6:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 11:19 [PATCH 0/5] Support ROHM KX134ACR-LBZ Matti Vaittinen
2024-11-13 11:19 ` [PATCH 1/5] iio: gts: Simplify using __free Matti Vaittinen
2024-11-13 11:20 ` [PATCH 2/5] iio: accel: kx022a: Use cleanup.h helpers Matti Vaittinen
2024-11-13 11:20 ` [PATCH 3/5] iio: accel: kx022a: Support ICs with different G-ranges Matti Vaittinen
2024-11-13 11:20 ` [PATCH 4/5] dt-bindings: ROHM KX134ACR-LBZ Matti Vaittinen
2024-11-14 20:10 ` Conor Dooley
2024-11-15 6:15 ` Matti Vaittinen [this message]
2024-11-13 11:21 ` [PATCH 5/5] iio: kx022a: Support " Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be11e656-a8be-4603-bd8f-01e3bdc56677@gmail.com \
--to=mazziesaccount@gmail.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).