From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64544C77B76 for ; Mon, 24 Apr 2023 09:43:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230152AbjDXJnC (ORCPT ); Mon, 24 Apr 2023 05:43:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229547AbjDXJnB (ORCPT ); Mon, 24 Apr 2023 05:43:01 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72BE21FE0 for ; Mon, 24 Apr 2023 02:43:00 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-504efe702d5so6045550a12.3 for ; Mon, 24 Apr 2023 02:43:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682329379; x=1684921379; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=sTC30/cz84+6KAee/oGkWJA1JugNorQ2NhQ6WARnGE0=; b=rtXWuf3JNfkAHAfAmA2cEYMt2sdc9jR4Np+5Kb6vSaHsvgYP0eCOgfvbZ7EpzUe5qh 0aAifedgOIbLeCg/woGiS4eDLparxUgHXtonnp2Pc0LvYnp/hSZb01nG/Lvngez8L6BH 3U3RhEV315jDBzxVmjH7taP6NMQlWO4nCqKgxgJSxGrYNJMMdE3exov5zgFOv9yO41LC 9Uq1pT96vyqPopct5Y7iY558ZhrF6vjqh90YMSHNELRgMAyZKpJolY0pRu3/RvtEHzrF gQDrXhyFLSaxni8K7W4aS+VpmSUS42MENZbyOtjGOIw0hJG4qKzfdv8JaOdu2NXKJp3u eLgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682329379; x=1684921379; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sTC30/cz84+6KAee/oGkWJA1JugNorQ2NhQ6WARnGE0=; b=Hl/WVn4ZpKMH28VuriBw+QgDCnSTV9ZyxfQ+SE8J5xo5LBYQaIyaeTIFd9BWWGpeob OoIkuZgAAKSmkGfXSrdigK2CJjsEiFi8QFf3qDytaoZ7RkUM9dQF25duDH6IxZx5/k2O oeUC2REmoUW9FlkStYe6WfKzU1ogppQmESjBcKZZ7cCUeL+SV9vyYUwFDYCyRYphw8xF Mtoz4IJH0lk1Hm/amd64+mSNsFNtrH9z33oGKXrW4dl/hkWxEpUZnJprdU5Ht3QVJFLk FU/m52USRuhv2hI1wZbD7pimvd7dSk4zKGUVuybm3CUaHs8E5Jr89faHEIkIjx/ohrdk E5rQ== X-Gm-Message-State: AAQBX9fm0t4Np7YWOlUXyyBUhBrkqdhATnZNZ0xLi3Y5EqWpgj1MnQ38 q+UBqWxgrJq2a/9FoiJvu4bf3A== X-Google-Smtp-Source: AKy350YAXqslb6hk6tvtZLyLLmjKobEKe0JFksRkukozW2c/onCbo7bLelBLsbcyrHZmm2SkaAaDXQ== X-Received: by 2002:aa7:cd7c:0:b0:4fc:3777:f630 with SMTP id ca28-20020aa7cd7c000000b004fc3777f630mr10401509edb.0.1682329378898; Mon, 24 Apr 2023 02:42:58 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:fcdb:bf53:d053:3a52? ([2a02:810d:15c0:828:fcdb:bf53:d053:3a52]) by smtp.gmail.com with ESMTPSA id e17-20020aa7d7d1000000b00508480633bdsm4561189eds.74.2023.04.24.02.42.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Apr 2023 02:42:58 -0700 (PDT) Message-ID: Date: Mon, 24 Apr 2023 11:42:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 1/2] dt-bindings: hwmon: Add max6639 To: Naresh Solanki , Jean Delvare , Guenter Roeck , Rob Herring , Krzysztof Kozlowski Cc: Marcello Sylvester Bauer , linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230420111759.2687001-1-Naresh.Solanki@9elements.com> <76e57634-75dd-01e8-9c56-36ed7de17812@linaro.org> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 24/04/2023 11:18, Naresh Solanki wrote: >>> Changes in V2: >>> - Update subject >>> - Drop blank lines >>> --- >>> .../bindings/hwmon/maxim,max6639.yaml | 52 +++++++++++++++++++ >>> 1 file changed, 52 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml b/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml >>> new file mode 100644 >>> index 000000000000..1aaedfd7cee0 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml >>> @@ -0,0 +1,52 @@ >>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/hwmon/maxim,max6639.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Maxim max6639 >> >> What is this device? fan controller? > Yes Fan controller. > Do you want me to update the title here as: > "Maxim MAC6639 2 channel fan controller & temperature monitor" ? Enough would be: Maxim MAX6639 Fan Controller > >> >>> + >>> +maintainers: >>> + - Naresh Solanki >>> + >>> +description: | >>> + The MAX6639 is a 2-channel temperature monitor with dual, automatic, PWM >>> + fan-speed controller. It monitors its own temperature and one external >>> + diode-connected transistor or the temperatures of two external diode-connected >>> + transistors, typically available in CPUs, FPGAs, or GPUs. >>> + >>> + Datasheets: >>> + https://datasheets.maximintegrated.com/en/ds/MAX6639-MAX6639F.pdf >>> + >>> +properties: >>> + compatible: >>> + enum: >>> + - maxim,max6639 >>> + >>> + reg: >>> + maxItems: 1 >>> + >>> + '#address-cells': >>> + const: 1 >>> + >>> + '#size-cells': >>> + const: 0 >> >> Why do you need these two properties? > Ack. Will remove them. >> >> Anyway, the binding looks incomplete. Where are the supplies? Interrupts? > This patch just adds basic support to the existing platform driver. > Intention is to be able to call the driver from DT with basic > initialization from driver the existing driver. Bindings should be rather complete. Here the datasheet is accessible and few properties quite obvious, so I don't see a reason to skip them. Best regards, Krzysztof