From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Krzysztof Kozlowski <krzk@kernel.org>,
gchan9527@gmail.com, Robert Foss <rfoss@kernel.org>,
Todor Tomov <todor.too@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
cros-qcom-dts-watchers@chromium.org,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] media: qcom: camss: Add CAMSS_SC7180 enum
Date: Fri, 21 Jun 2024 12:16:19 +0100 [thread overview]
Message-ID: <be3d384f-82e2-4849-b3c4-070de8d08ba0@linaro.org> (raw)
In-Reply-To: <f835bd3c-82a7-4798-ac49-cf0d0014d70c@kernel.org>
On 21/06/2024 11:03, Krzysztof Kozlowski wrote:
> On 21/06/2024 11:40, George Chan via B4 Relay wrote:
>> From: George Chan <gchan9527@gmail.com>
>>
>> Adds a CAMSS SoC identifier for the SC7180.
>>
>> Signed-off-by: George Chan <gchan9527@gmail.com>
>> ---
>> drivers/media/platform/qcom/camss/camss.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/media/platform/qcom/camss/camss.h b/drivers/media/platform/qcom/camss/camss.h
>> index ac15fe23a702..5e750c481b74 100644
>> --- a/drivers/media/platform/qcom/camss/camss.h
>> +++ b/drivers/media/platform/qcom/camss/camss.h
>> @@ -76,6 +76,7 @@ enum camss_version {
>> CAMSS_8x96,
>> CAMSS_660,
>> CAMSS_845,
>> + CAMSS_7180,
>
> This patch on its own makes no sense. Squash it with patch adding 7180.
>
> Best regards,
> Krzysztof
>
Agreed you can put it into the PHY init sequence in patch #3
---
bod
next prev parent reply other threads:[~2024-06-21 11:16 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-21 9:40 [PATCH 0/6] media: qcom: camss: Add sc7180 support George Chan via B4 Relay
2024-06-21 9:40 ` [PATCH 1/6] media: dt-bindings: media: camss: Add qcom,sc7180-camss binding George Chan via B4 Relay
2024-06-21 10:02 ` Krzysztof Kozlowski
2024-06-22 15:24 ` george chan
2024-06-21 10:29 ` Rob Herring (Arm)
2024-06-21 11:24 ` Bryan O'Donoghue
2024-06-22 15:31 ` george chan
2024-06-23 11:10 ` Bryan O'Donoghue
2024-06-23 21:45 ` george chan
2024-06-21 9:40 ` [PATCH 2/6] media: qcom: camss: Add CAMSS_SC7180 enum George Chan via B4 Relay
2024-06-21 10:03 ` Krzysztof Kozlowski
2024-06-21 11:16 ` Bryan O'Donoghue [this message]
2024-06-21 9:40 ` [PATCH 3/6] media: qcom: camss: csiphy-3ph: Add Gen2 v1.2.2 two-phase MIPI CSI-2 DPHY init George Chan via B4 Relay
2024-06-21 11:25 ` Bryan O'Donoghue
2024-06-22 11:20 ` Konrad Dybcio
2024-06-22 13:47 ` george chan
[not found] ` <CADgMGSs7owyvvvRTr4YvCdmMiJV86CjD5YLsJiBZZONDhfFisQ@mail.gmail.com>
2024-06-23 11:17 ` Bryan O'Donoghue
2024-06-23 21:37 ` george chan
2024-06-23 22:13 ` Bryan O'Donoghue
2024-06-23 23:16 ` george chan
2024-06-23 23:26 ` Bryan O'Donoghue
2024-06-21 9:40 ` [PATCH 4/6] media: qcom: camss: Add sc7180 support George Chan via B4 Relay
2024-06-21 9:40 ` [PATCH 5/6] media: qcom: camss: Add sc7180 resources George Chan via B4 Relay
2024-06-22 11:18 ` Konrad Dybcio
2024-06-23 21:48 ` george chan
2024-06-23 22:14 ` Bryan O'Donoghue
2024-06-23 23:27 ` george chan
2024-06-21 9:40 ` [PATCH RFT 6/6] arm64: dts: qcom: sc7180: Add support for camss subsys George Chan via B4 Relay
2024-06-21 10:03 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be3d384f-82e2-4849-b3c4-070de8d08ba0@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=gchan9527@gmail.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).