From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C59FC172BA5 for ; Fri, 21 Jun 2024 11:16:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718968585; cv=none; b=uXteKvQGjlEMn6adbeKiSwoemFusOY8WXRp4OZ3AbJPQubqN3yjsEJP6CuIdGFl3f8VEES8uu2EmEnEj0yfU6VHiSYq6i/1hFlmgKhT3Ned8MIuzt0CxfwEe7sV3HEe1cJtcDJTqNm31idqHc3rs8Y5h5jUtUpL1AHPOvvqfAQE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718968585; c=relaxed/simple; bh=BshDJQdhNhXf11L2xygSIbCgPvzBsBsrcg9+j+hrxIA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Zot/Oojb7jKKFMWbLpFJ7fRq5HXEXyCO6qW4OYb4qBpjxfLKRrUemeShJm04r0DgXpwf7IJl6bHtVRkUFvAx4lnIaztDvNTx+/UWJnLbOnTJP0tXnq78z4hDum/0u2JmlO2lsnrqz+ZZIcxjm0AphEdbBRUDZK4+VhiypspfXGE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=lVHr/P6n; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lVHr/P6n" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4217c7eb6b4so18171645e9.2 for ; Fri, 21 Jun 2024 04:16:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1718968581; x=1719573381; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bPEEtZOHgOmd9n8/jwJKYJBhpCqajSuBe3eF47dbP/M=; b=lVHr/P6n6fNHFm3wxISbNYNWoUzEx+8rlKIn5YEaROvaHCPfUB4jNSK5xX2y5mlfUB elqOmknRLYmDRLqZj9ww/pkGCj6z3xySNh4O57402tgDRn/J3HFW7wHwBuqpG9GEQczF VQ7vSnBbXAvMW3VOSjoN45ZlnAwTPRSWUmEikeqx7/iW5xWSeE1r8lpdPHKq8ndntmuE N4QD9RqkJawT90arooRZmLKlr88wzHNCIatJLAcP6OKfB/2dqx6EkoR4QiRhw2afmX99 0ceKGb0iKiafSr4IwW6Yzv2bOj/NheeuxDPDWMx+9jEsCoqvf2YzxTdf//xAjcwB9KXl H8bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718968581; x=1719573381; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bPEEtZOHgOmd9n8/jwJKYJBhpCqajSuBe3eF47dbP/M=; b=f5YFNQT9GDp8um8FLapQAUfydPhjdgpCvZawOrYWz39AEcZaEv03GfkETWXUSEb8nt CogAIbsOIlM5HNdgfHbwlDQZkfpyPqXUq4jknrivDL8GCNjUNn7oPFebjsPcfZk6kQYu UYQsKJ+PnE5JXPdC9chIqJEA7UTos1Z8Nv15XB2tBwZGWOXca0jnSly8QSZnt1lz/lzZ Se3We3tTeg6hpuhpI7Moe6Z/PCRY0WwgyQT69Ypj0FfdH8lC3yECMvIEJ8tfKJgZuRey JRrqT9PHwkk4bl8MZnX6ImCMskbppAzxUl7jyf4leW5wmrWwjowIfm0unrg6GsXgB+72 x1vQ== X-Forwarded-Encrypted: i=1; AJvYcCV0G3lGmNjDAD0S3Kg3zevlzfE4rm82Zf6dOthMwqToDFWbb2QMs6S4vXosts08ObKoOxpCjyLmr9FjFIOAo0JbqIL7XBTlaxJKiA== X-Gm-Message-State: AOJu0YxWx/fhgT05FO3BtDMcP81blzJuaddZcz7Q7BQjgMv9QDEX0qPh H1GYlRssGW1mTEXOfpgf8h1WkPIc19zq66q+F3p1sSvVE60Fb8j0YakRvZiROWs= X-Google-Smtp-Source: AGHT+IGELu0uHxfAlwboPDwjRtRyDqLbieRNBQ+AhZbFVs2b5uEh5KXbhEXjKnW5TwDgBrj6qXfxtQ== X-Received: by 2002:a05:600c:2e54:b0:424:6c83:a78e with SMTP id 5b1f17b1804b1-4247529c9e0mr50294075e9.40.1718968581086; Fri, 21 Jun 2024 04:16:21 -0700 (PDT) Received: from [192.168.0.3] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-424817a8d8esm23675535e9.12.2024.06.21.04.16.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Jun 2024 04:16:20 -0700 (PDT) Message-ID: Date: Fri, 21 Jun 2024 12:16:19 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/6] media: qcom: camss: Add CAMSS_SC7180 enum To: Krzysztof Kozlowski , gchan9527@gmail.com, Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org, Bjorn Andersson , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240621-b4-sc7180-camss-v1-0-14937929f30e@gmail.com> <20240621-b4-sc7180-camss-v1-2-14937929f30e@gmail.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 21/06/2024 11:03, Krzysztof Kozlowski wrote: > On 21/06/2024 11:40, George Chan via B4 Relay wrote: >> From: George Chan >> >> Adds a CAMSS SoC identifier for the SC7180. >> >> Signed-off-by: George Chan >> --- >> drivers/media/platform/qcom/camss/camss.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/media/platform/qcom/camss/camss.h b/drivers/media/platform/qcom/camss/camss.h >> index ac15fe23a702..5e750c481b74 100644 >> --- a/drivers/media/platform/qcom/camss/camss.h >> +++ b/drivers/media/platform/qcom/camss/camss.h >> @@ -76,6 +76,7 @@ enum camss_version { >> CAMSS_8x96, >> CAMSS_660, >> CAMSS_845, >> + CAMSS_7180, > > This patch on its own makes no sense. Squash it with patch adding 7180. > > Best regards, > Krzysztof > Agreed you can put it into the PHY init sequence in patch #3 --- bod