From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B5D6C77B7A for ; Fri, 26 May 2023 19:53:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237655AbjEZTxM (ORCPT ); Fri, 26 May 2023 15:53:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230058AbjEZTxL (ORCPT ); Fri, 26 May 2023 15:53:11 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6989189 for ; Fri, 26 May 2023 12:53:09 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-4f00c33c3d6so1283609e87.2 for ; Fri, 26 May 2023 12:53:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685130788; x=1687722788; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EdOxC7pmuf6A/Xakhco3OcLae3tnkD2fShwausc2Awo=; b=HOrZeNPoR3ZYMQxO8fqChg/oAGdcW3K8v9RhXw3PAtxwsL3JS1D7LydUT65LwFS8rd d8oanhI4eQEI5hcOLZ5PILzZm/xBDSbUUEiMz/bJtc5x1x0tgYnASt4sBHAhLnerxMiP X9uJiiH05lY6LeC1Pg1nP49h/dzQH+A5tcltvwAQyR7NUB5a2r5UaaULBndvd5OmNq65 XAGy6ZRhI8ZTJAV5wOZz2JgXR1FrOlBVIRuVFk3dvsjulvIXqM/X84c02PpZhU6srX4E KG/DohoNiI1JrAJBaWw6OFY2jly2qMhqe4f8ttYtqI/HpmKNgJaE7Fns3qDR5yAM/CGf XbPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685130788; x=1687722788; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EdOxC7pmuf6A/Xakhco3OcLae3tnkD2fShwausc2Awo=; b=G0F1IMH4gRn9UPSScwViwFvXr/gDZ7FTE3PwYiraq8WyKkoVKM9m9c9Yrv2aG0jvug lw1vKzel2EZ9Yg1rgARxKq5XsSvWFXrCnFawIYXN9gtxphprOHBOB83FisQEld1bo6s/ MMnUf8U7R+c0vud1ugXTeqkq1WIiz426kaKuGNweXJcCmaTPe09RKQMuP6J1VtI2TUXR V1obDqjM+g3pTZ8S8OskaiDAGgpwG5bVg2Axsm9DVpEzOLDCqnApcZs8a585OECza1v8 waV7F+YYJmSTvQZJJwmocJrNDVb+yQsUPWCOYPQX25aktvWayVG3tuPAbd51Xot7atkp z6dA== X-Gm-Message-State: AC+VfDwKtiEPF5UMyeYPAOfp9xa1sTY4/22PEFRBW6wud8L6qrdJESt3 A5Nibd0UeAmttq+IBZPB5s/u7A== X-Google-Smtp-Source: ACHHUZ4khPTysmRopzYaR5zjx+FiCgvNlpBkbFBZniRUlr/Zm+W/qbEL2Eup6UXRtM1OFsiXiiwbAg== X-Received: by 2002:a2e:808c:0:b0:2ad:92b9:83b4 with SMTP id i12-20020a2e808c000000b002ad92b983b4mr1228070ljg.5.1685130787979; Fri, 26 May 2023 12:53:07 -0700 (PDT) Received: from [192.168.1.101] (abyj77.neoplus.adsl.tpnet.pl. [83.9.29.77]) by smtp.gmail.com with ESMTPSA id f6-20020a2e3806000000b002adb36f7343sm900375lja.77.2023.05.26.12.53.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 May 2023 12:53:07 -0700 (PDT) Message-ID: Date: Fri, 26 May 2023 21:53:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 4/4] arm64: dts: qcom: sm8550-qrd: enable PMIC Volume and Power buttons Content-Language: en-US To: Neil Armstrong , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230525-topic-sm8550-upstream-pm8550-lpg-dt-v1-0-4d5d7602f290@linaro.org> <20230525-topic-sm8550-upstream-pm8550-lpg-dt-v1-4-4d5d7602f290@linaro.org> From: Konrad Dybcio In-Reply-To: <20230525-topic-sm8550-upstream-pm8550-lpg-dt-v1-4-4d5d7602f290@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 25.05.2023 17:47, Neil Armstrong wrote: > The Volume Down & Power buttons are controlled by the PMIC via > the PON hardware, and the Volume Up is connected to a PMIC gpio. > > Enable the necessary hardware and setup the GPIO state for the > Volume Up gpio key. > > Signed-off-by: Neil Armstrong > --- > arch/arm64/boot/dts/qcom/sm8550-qrd.dts | 36 +++++++++++++++++++++++++++++++++ > 1 file changed, 36 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts > index b08a8201ad23..c354dcc12621 100644 > --- a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts > +++ b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts > @@ -28,6 +28,22 @@ chosen { > stdout-path = "serial0:115200n8"; > }; > > + gpio-keys { > + compatible = "gpio-keys"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&volume_up_n>; property-n property-names > + > + key-volume-up { > + label = "Volume Up"; > + linux,code = ; > + gpios = <&pm8550_gpios 6 GPIO_ACTIVE_LOW>; > + debounce-interval = <15>; > + linux,can-disable; > + wakeup-source; > + }; > + }; > + > pmic-glink { > compatible = "qcom,sm8550-pmic-glink", "qcom,pmic-glink"; > #address-cells = <1>; > @@ -426,6 +442,16 @@ &pcie0_phy { > status = "okay"; > }; > > +&pon_pwrkey { > + status = "okay"; > +}; > + > +&pon_resin { Not alphabetically ordered Konrad > + linux,code = ; > + > + status = "okay"; > +}; > + > &pm8550_flash { > status = "okay"; > > @@ -450,6 +476,16 @@ led-1 { > }; > }; > > +&pm8550_gpios { > + volume_up_n: volume-up-n-state { > + pins = "gpio6"; > + function = "normal"; > + power-source = <1>; > + bias-pull-up; > + input-enable; > + }; > +}; > + > &pm8550_pwm { > status = "okay"; > >