From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Rob Herring (Arm)" <robh@kernel.org>,
Shawn Lin <shawn.lin@rock-chips.com>
Cc: linux-rockchip@lists.infradead.org, linux-scsi@vger.kernel.org,
YiFeng Zhao <zyf@rock-chips.com>,
Heiko Stuebner <heiko@sntech.de>,
devicetree@vger.kernel.org, Avri Altman <avri.altman@wdc.com>,
"James E . J . Bottomley" <James.Bottomley@HansenPartnership.com>,
Bart Van Assche <bvanassche@acm.org>,
Liang Chen <cl@rock-chips.com>,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Rob Herring <robh+dt@kernel.org>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: Re: [RESEND PATCH v2 2/3] dt-bindings: ufs: Document Rockchip UFS host controller
Date: Thu, 8 Aug 2024 12:30:12 +0200 [thread overview]
Message-ID: <be40aed4-38f9-4db7-a3df-e1da61295b18@kernel.org> (raw)
In-Reply-To: <172310944186.384374.16402625285044950364.robh@kernel.org>
On 08/08/2024 11:30, Rob Herring (Arm) wrote:
>
> On Thu, 08 Aug 2024 12:27:00 +0800, Shawn Lin wrote:
>> Document Rockchip UFS host controller for RK3576 SoC.
>>
>> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
>>
>> ---
>>
>> Changes in v2:
>> - renmae file name
>> - fix all errors and pass the dt_binding_check:
>> make dt_binding_check DT_SCHEMA_FILES=rockchip,rk3576-ufs.yaml
>>
>> .../bindings/ufs/rockchip,rk3576-ufs.yaml | 96 ++++++++++++++++++++++
>> 1 file changed, 96 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/ufs/rockchip,rk3576-ufs.yaml
>>
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/ufs/rockchip,rk3576-ufs.example.dts:24:18: fatal error: dt-bindings/clock/rockchip,rk3576-cru.h: No such file or directory
> 24 | #include <dt-bindings/clock/rockchip,rk3576-cru.h>
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> compilation terminated.
Nothing improved... stop sending new versions so fast but allow people
to respond to your patches and then implement the feedback.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-08 10:30 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 3:52 [PATCH v2 0/3] Init support for RK3576 UFS controller Shawn Lin
2024-08-08 3:52 ` [PATCH v2 2/3] dt-bindings: ufs: Document Rockchip UFS host controller Shawn Lin
2024-08-08 5:29 ` Rob Herring (Arm)
2024-08-08 6:10 ` Shawn Lin
2024-08-08 10:28 ` Krzysztof Kozlowski
2024-08-08 10:34 ` Krzysztof Kozlowski
2024-08-09 0:33 ` Shawn Lin
2024-08-08 3:52 ` [PATCH v2 3/3] scsi: ufs: rockchip: init support for UFS Shawn Lin
2024-08-08 10:36 ` Krzysztof Kozlowski
2024-08-09 0:53 ` Shawn Lin
2024-08-09 5:44 ` Krzysztof Kozlowski
2024-08-09 6:11 ` Shawn Lin
2024-08-08 10:39 ` Krzysztof Kozlowski
2024-08-09 6:28 ` Manivannan Sadhasivam
2024-08-09 8:16 ` Shawn Lin
2024-08-10 9:28 ` Manivannan Sadhasivam
2024-08-12 1:28 ` Shawn Lin
2024-08-12 4:10 ` Manivannan Sadhasivam
2024-08-12 6:24 ` Shawn Lin
2024-08-12 16:55 ` Manivannan Sadhasivam
2024-08-13 3:52 ` Shawn Lin
2024-08-13 7:22 ` Shawn Lin
2024-08-16 7:52 ` Manivannan Sadhasivam
2024-08-09 19:06 ` Bart Van Assche
2024-08-08 4:27 ` [RESEND PATCH v2 2/3] dt-bindings: ufs: Document Rockchip UFS host controller Shawn Lin
2024-08-08 9:30 ` Rob Herring (Arm)
2024-08-08 10:30 ` Krzysztof Kozlowski [this message]
2024-08-08 10:29 ` Krzysztof Kozlowski
[not found] ` <1723089163-28983-2-git-send-email-shawn.lin@rock-chips.com>
2024-08-09 18:27 ` [PATCH v2 1/3] scsi: ufs: core: Export ufshcd_dme_link_startup() helper Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be40aed4-38f9-4db7-a3df-e1da61295b18@kernel.org \
--to=krzk@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=cl@rock-chips.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=zyf@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).