devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Nuno Sá" <noname.nuno@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>, nuno.sa@analog.com
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	Lars-Peter Clausen <lars@metafoo.de>,
	Michael Hennerich <Michael.Hennerich@analog.com>,
	 Jonathan Cameron <jic23@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Frank Rowand <frowand.list@gmail.com>,
	Olivier Moysan <olivier.moysan@foss.st.com>
Subject: Re: [PATCH v11 7/7] iio: adc: adi-axi-adc: move to backend framework
Date: Wed, 14 Feb 2024 13:35:22 +0100	[thread overview]
Message-ID: <be58e8b4716dae855843645de59671309352eb41.camel@gmail.com> (raw)
In-Reply-To: <CAHp75VfiM0cqFsdN3nQQzZkea+cKfbFKkSM1J4LdE3LYGFedWg@mail.gmail.com>

On Sun, 2024-02-11 at 18:52 +0200, Andy Shevchenko wrote:
> On Sat, Feb 10, 2024 at 10:57 PM Nuno Sa via B4 Relay
> <devnull+nuno.sa.analog.com@kernel.org> wrote:
> > 
> > From: Nuno Sa <nuno.sa@analog.com>
> > 
> > Move to the IIO backend framework. Devices supported by adi-axi-adc now
> > register themselves as backend devices.
> 
> ...
> 
> >  struct adi_axi_adc_state {
> >         struct regmap                           *regmap;
> >         struct device                           *dev;
> >  };
> 
> So, not sure you need these two as one can be derived from the other one
> (IIUC).
> In any case, it may be amended in a follow up.

Yeah, I think you're right and I never really thought about it but one can use
regmap_get_device()... 

> 
> ...
> 
> > +       fsleep(10000);
> 
> As I pointed out, the comment is good to have. Maybe you can add it
> when reducing the timeout in a follow up patch...
> 

I did not included because there's no documentation for the delay. But I'll try
to ask around about...

- Nuno Sá

  reply	other threads:[~2024-02-14 12:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-10 20:57 [PATCH v11 0/7] iio: add new backend framework Nuno Sa via B4 Relay
2024-02-10 20:57 ` [PATCH v11 1/7] dt-bindings: adc: ad9467: add new io-backend property Nuno Sa via B4 Relay
2024-02-10 20:57 ` [PATCH v11 2/7] dt-bindings: adc: axi-adc: update bindings for backend framework Nuno Sa via B4 Relay
2024-02-10 20:57 ` [PATCH v11 3/7] of: property: add device link support for io-backends Nuno Sa via B4 Relay
2024-02-16 14:34   ` Jonathan Cameron
2024-02-10 20:57 ` [PATCH v11 4/7] iio: buffer-dmaengine: export buffer alloc and free functions Nuno Sa via B4 Relay
2024-02-10 20:57 ` [PATCH v11 5/7] iio: add the IIO backend framework Nuno Sa via B4 Relay
2024-02-10 20:57 ` [PATCH v11 6/7] iio: adc: ad9467: convert to " Nuno Sa via B4 Relay
2024-02-10 20:57 ` [PATCH v11 7/7] iio: adc: adi-axi-adc: move " Nuno Sa via B4 Relay
2024-02-11 16:52   ` Andy Shevchenko
2024-02-14 12:35     ` Nuno Sá [this message]
2024-02-11 16:55 ` [PATCH v11 0/7] iio: add new " Andy Shevchenko
2024-02-14 12:38   ` Nuno Sá

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be58e8b4716dae855843645de59671309352eb41.camel@gmail.com \
    --to=noname.nuno@gmail.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=jic23@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=olivier.moysan@foss.st.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).