From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24A1EC7EE2D for ; Mon, 27 Feb 2023 20:11:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229657AbjB0ULr (ORCPT ); Mon, 27 Feb 2023 15:11:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229574AbjB0ULq (ORCPT ); Mon, 27 Feb 2023 15:11:46 -0500 Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4EBB286B9; Mon, 27 Feb 2023 12:11:45 -0800 (PST) Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 214B280EB1; Mon, 27 Feb 2023 21:11:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1677528703; bh=HHhhNiiFFM6pJEYBbaLex7pnt0KsSv9LmdqUwbAIwk0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=TXb/yCiVJLpdxJy2Qpl4WNlF0PnqG3X3ZT7PAabeoF2fWRAn+RIgU553qDJjNCz4T ev8EmLQU7nMZtjkxyY81lXB3MKZrKJ3lN9YIDtsGtNtMcMY1Xl6zljshZ9IK17DnlV lAGaqFPO8CbeUI2Hcmi8Rea9QxYR/2gKyJBqYFY1r0yy0EBS0jEEhhKdIA7cl6LDMQ KDryQy7OeWSMzFyJY4WWAAnfmmZpPdj//63p5GLtkaJo0pghwyT3Wou7K+lfHZnB2X mkNmf3fnyxA9CxHMlq9CEGxEeGx9BgHPC8/3EJPoXr9ow0J6UCctorfaz/9QGGhi0F nda7zZ9jzwfTA== Message-ID: Date: Mon, 27 Feb 2023 21:11:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] arm64: dts: imx8mn: specify #sound-dai-cells for SAI nodes Content-Language: en-US To: Marco Felsch Cc: linux-arm-kernel@lists.infradead.org, Abel Vesa , Alexander Stein , Fabio Estevam , Jacky Bai , Krzysztof Kozlowski , Laurent Pinchart , Luca Ceresoli , Lucas Stach , Michael Turquette , NXP Linux Team , Peng Fan , Pengutronix Kernel Team , Richard Cochran , Rob Herring , Sascha Hauer , Shawn Guo , Stephen Boyd , devicetree@vger.kernel.org, linux-clk@vger.kernel.org References: <20230227174535.87657-1-marex@denx.de> <20230227190123.znifdqympsantpt6@pengutronix.de> <20230227200039.ugmtvpli6gvux3fi@pengutronix.de> From: Marek Vasut In-Reply-To: <20230227200039.ugmtvpli6gvux3fi@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2/27/23 21:00, Marco Felsch wrote: > On 23-02-27, Marek Vasut wrote: >> On 2/27/23 20:01, Marco Felsch wrote: >>> Hi Marek, >>> >>> On 23-02-27, Marek Vasut wrote: >>>> Add #sound-dai-cells properties to SAI nodes. >>>> >>>> Signed-off-by: Marek Vasut >>>> --- >>>> Cc: Abel Vesa >>>> Cc: Alexander Stein >>>> Cc: Fabio Estevam >>>> Cc: Jacky Bai >>>> Cc: Krzysztof Kozlowski >>>> Cc: Laurent Pinchart >>>> Cc: Luca Ceresoli >>>> Cc: Lucas Stach >>>> Cc: Marco Felsch >>>> Cc: Michael Turquette >>>> Cc: NXP Linux Team >>>> Cc: Peng Fan >>>> Cc: Pengutronix Kernel Team >>>> Cc: Richard Cochran >>>> Cc: Rob Herring >>>> Cc: Sascha Hauer >>>> Cc: Shawn Guo >>>> Cc: Stephen Boyd >>>> Cc: devicetree@vger.kernel.org >>>> Cc: linux-arm-kernel@lists.infradead.org >>>> Cc: linux-clk@vger.kernel.org >>>> --- >>>> arch/arm64/boot/dts/freescale/imx8mn.dtsi | 5 +++++ >>>> 1 file changed, 5 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi >>>> index ed9ac6c5047c0..bbec860ef8548 100644 >>>> --- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi >>>> +++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi >>>> @@ -294,6 +294,7 @@ spba2: spba-bus@30000000 { >>>> ranges; >>>> sai2: sai@30020000 { >>>> + #sound-dai-cells = <0>; >>> >>> Please don't add it in front of the compatible and the reg property. >> >> The #address-cells and #size-cells are also always on top, why should the >> #sound-dai-cells be any different ? Where should they be ? > > As of now my understanding of specifying a devicetree node was: > > node-name@reg-nr { > compatible = ""; > reg = <>; > // all pending properties below > ... > }; > > @Rob, @Krzysztof: > Is this a (unwritten) rule/policy? > > Marekt please ignore my comment if this is not the case. Getting input from Rob/Krysztof is a good idea, thanks.