From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EC26C0015E for ; Tue, 15 Aug 2023 12:06:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236936AbjHOMGV (ORCPT ); Tue, 15 Aug 2023 08:06:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237015AbjHOMFw (ORCPT ); Tue, 15 Aug 2023 08:05:52 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C76CB173C; Tue, 15 Aug 2023 05:05:46 -0700 (PDT) Received: from [192.168.88.20] (91-154-35-171.elisa-laajakaista.fi [91.154.35.171]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8FB2D6BE; Tue, 15 Aug 2023 14:04:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1692101071; bh=z0PuRlOPSM7m9+UtKr3fBFzofL+sYR2WdbiV0aUsETk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Nzcy/V9oMsRCzey3fPoE4VFz10+o86wZSBRDpsc26jiGD5ubPE6AIYGCYdKHhf3c+ ah+TZZ936iSyctp9zUWZp9+G1CJVh008AlMczR9gDu+9VeP2Pp9vZLcUcZDyfQXGpr DoEp8GPaX4naIS08pk9Nv4Ez7gz+/A95COZH+NaY= Message-ID: Date: Tue, 15 Aug 2023 15:05:39 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v9 05/13] media: cadence: csi2rx: Add get_fmt and set_fmt pad ops To: Jai Luthra , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sakari Ailus Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Laurent Pinchart , Mauro Carvalho Chehab , Maxime Ripard , niklas.soderlund+renesas@ragnatech.se, Benoit Parrot , Vaishnav Achath , Vignesh Raghavendra , nm@ti.com, devarsht@ti.com, a-bhatia1@ti.com, Martyn Welch , Julien Massot References: <20230811-upstream_csi-v9-0-8943f7a68a81@ti.com> <20230811-upstream_csi-v9-5-8943f7a68a81@ti.com> Content-Language: en-US From: Tomi Valkeinen In-Reply-To: <20230811-upstream_csi-v9-5-8943f7a68a81@ti.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11/08/2023 13:47, Jai Luthra wrote: > From: Pratyush Yadav > > The format is needed to calculate the link speed for the external DPHY > configuration. It is not right to query the format from the source > subdev. Add get_fmt and set_fmt pad operations so that the format can be > configured and correct bpp be selected. > > Initialize and use the v4l2 subdev active state to keep track of the > active formats. Also propagate the new format from the sink pad to all > the source pads. > > Signed-off-by: Pratyush Yadav > Co-authored-by: Jai Luthra > Reviewed-by: Maxime Ripard > Signed-off-by: Jai Luthra > --- > Changes from v8: > - Squash the patch adding RAW8 and RAW10 formats within this one > - Single line struct entries in formats[] array > - Skip specifiying redundant format.which entry in init_cfg() > Reviewed-by: Tomi Valkeinen Tomi