From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sarangdhar Joshi Subject: Re: [PATCH 3/4] arm64: dts: msm8996: Add SMEM DT nodes Date: Thu, 20 Oct 2016 14:59:49 -0700 Message-ID: References: <1476989765-7524-1-git-send-email-spjoshi@codeaurora.org> <1476989765-7524-3-git-send-email-spjoshi@codeaurora.org> <20161020195629.GM7509@tuxbot> <1c7504f2-48ca-bcae-3eef-16589513d1aa@codeaurora.org> <20161020215137.GF3145@hector.attlocal.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20161020215137.GF3145@hector.attlocal.net> Sender: linux-kernel-owner@vger.kernel.org To: Andy Gross Cc: Bjorn Andersson , David Brown , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Stephen Boyd , Trilok Soni List-Id: devicetree@vger.kernel.org On 10/20/2016 02:51 PM, Andy Gross wrote: > On Thu, Oct 20, 2016 at 02:18:33PM -0700, Sarangdhar Joshi wrote: >> On 10/20/2016 12:56 PM, Bjorn Andersson wrote: >>> On Thu 20 Oct 11:56 PDT 2016, Sarangdhar Joshi wrote: >>> >>>> From: Bjorn Andersson >>>> >>>> Add SMEM and TCSR DT nodes on MSM8996. >>>> >>>> Signed-off-by: Bjorn Andersson >>>> Signed-off-by: Sarangdhar Joshi >>>> --- >>>> arch/arm64/boot/dts/qcom/msm8996.dtsi | 19 +++++++++++++++++++ >>>> 1 file changed, 19 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi >>>> index 949b096..0a810f5 100644 >>>> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi >>>> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi >>>> @@ -169,12 +169,31 @@ >>>> method = "smc"; >>>> }; >>>> >>>> + smem { >>>> + compatible = "qcom,smem"; >>>> + >>>> + memory-region = <&smem_mem>; >>>> + >>>> + hwlocks = <&tcsr_mutex 3>; >>>> + }; >>>> + >>>> soc: soc { >>>> #address-cells = <1>; >>>> #size-cells = <1>; >>>> ranges = <0 0 0 0xffffffff>; >>>> compatible = "simple-bus"; >>>> >>>> + tcsr_mutex_regs: syscon@740000 { >>>> + compatible = "syscon"; >>>> + reg = <0x740000 0x20000>; >>>> + }; >>>> + >>>> + tcsr_mutex: hwlock { >>>> + compatible = "qcom,tcsr-mutex"; >>>> + syscon = <&tcsr_mutex_regs 0 0x1000>; >>>> + #hwlock-cells = <1>; >>>> + }; >>> >>> Sorry, I got this in the wrong place, the hwlock node should sit outside >>> of soc {} - looks like we got this wrong in msm8916 as well. >> >> Thanks for reviewing the patch. Do you mean to move it under / {}; (i.e. >> root)? > > Yes. Any node that doesn't have reg properties should go under the root. > Got it. Will update the patch(es) and add cover letter. Thanks. > > Andy > Regards, Sarang -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project