From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90A3AC433EF for ; Wed, 22 Jun 2022 12:20:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232489AbiFVMUb (ORCPT ); Wed, 22 Jun 2022 08:20:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234528AbiFVMU3 (ORCPT ); Wed, 22 Jun 2022 08:20:29 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D73935DF3 for ; Wed, 22 Jun 2022 05:20:28 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id ay16so14463697ejb.6 for ; Wed, 22 Jun 2022 05:20:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=YqZl55YlnzKJuZvnAvOYUqgqzVWeklNXo8K4BWb79NY=; b=K+vUm9h4zeZ2BY+AkhsLxdTYyhJwqnMXqQq77ZRQfWdtzXQwazdV7BvakFNKvQJxGb YbZqFHNUdhLZ5rkfeG9GzWzmy0i05jF+yiQg8vU/hKgJvaCCmROqzo1ePUT0nW3nKGUb awSUdhmwMFCXKWFnTe0GlnC6o/TV/UIx84e8QJEZjXf+qSo/JH9yEfluwL4JpjwyP6lJ C3v6aS4CbXAKHBZ3u0eWXDUTiz5mZLZLDle3Ex5Cr41wSJ3Ouze7STBZxmb+C++WIMaz YkGxZucrMsZHESuItdlF4xdJ5T7GkNi5dtvrDtaLfu+1DR9q6wJLUUJbdkozGT3mKCLX mILg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=YqZl55YlnzKJuZvnAvOYUqgqzVWeklNXo8K4BWb79NY=; b=aH2ChU3tc2fDtET9oe4vy60Fe2fp+xyzrh5lK9y+DUFC77nzd6bx/yUQ0XFPd9KJGB gtX27FVhzs5bJi6qAr+EfiYDupEIqzS4LJErxQp4SLzGpcw3IJ6bvzAcbd+7x0/ivL7/ CHaFlUMW2pEO0li1bwqFiYkYYqw6HpRkAatkQM6s3ce6xC/rqMINDyqAM01BS2QlF3qd h8K5qJ7tadtmHfFoqhfjeRzyJSI0NWezpRie/sXiJW2fyLujkRf4woT9NXZp1mAZjlzS eWGbU66Dxpbc1ZITOAxddJ5IfPBZUpEDD+U9rOlNOQtk0eXlQs+ejwv55V4amn0u3/77 RaxA== X-Gm-Message-State: AJIora+cOiBvO6geEwKO3zIZuu4dL+6ZSSTjYVphuB4piHewljom06eN ypblIXlMib3xWUZWtZwmwVtX9w== X-Google-Smtp-Source: AGRyM1tRaVprGVLQKE51VKBB6prua/fQyAH18plkrLguHseuDTTg9AZY0HC40TSxd49AsE/GzfvZTQ== X-Received: by 2002:a17:907:d0d:b0:711:d554:1c8f with SMTP id gn13-20020a1709070d0d00b00711d5541c8fmr2878279ejc.223.1655900426586; Wed, 22 Jun 2022 05:20:26 -0700 (PDT) Received: from [192.168.0.224] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id p6-20020a17090653c600b00722e0b1fa8esm3077762ejo.164.2022.06.22.05.20.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Jun 2022 05:20:25 -0700 (PDT) Message-ID: Date: Wed, 22 Jun 2022 14:20:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v4 1/4] dt-bindings: interconnect: qcom,sdm845-cpu-bwmon: add BWMON device Content-Language: en-US To: Rajendra Nayak , Bjorn Andersson Cc: Andy Gross , Georgi Djakov , Rob Herring , Catalin Marinas , Will Deacon , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Rob Herring References: <20220601101140.170504-1-krzysztof.kozlowski@linaro.org> <20220601101140.170504-2-krzysztof.kozlowski@linaro.org> <3e4e504c-5a38-43cd-ea8d-afbbb72eacad@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 22/06/2022 13:58, Rajendra Nayak wrote: > > > On 6/7/2022 12:20 PM, Krzysztof Kozlowski wrote: >> On 06/06/2022 23:11, Bjorn Andersson wrote: >>> On Wed 01 Jun 03:11 PDT 2022, Krzysztof Kozlowski wrote: >>> >>>> Add bindings for the Qualcomm Bandwidth Monitor device providing >>>> performance data on interconnects. The bindings describe only BWMON >>>> version 4, e.g. the instance on SDM845 between CPU and Last Level Cache >>>> Controller. >>>> >>>> Signed-off-by: Krzysztof Kozlowski >>>> Reviewed-by: Rob Herring >>>> Acked-by: Georgi Djakov >>>> --- >>>> .../interconnect/qcom,sdm845-cpu-bwmon.yaml | 97 +++++++++++++++++++ >>>> 1 file changed, 97 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,sdm845-cpu-bwmon.yaml >>>> >>>> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,sdm845-cpu-bwmon.yaml b/Documentation/devicetree/bindings/interconnect/qcom,sdm845-cpu-bwmon.yaml >>>> new file mode 100644 >>>> index 000000000000..8c82e06ee432 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/interconnect/qcom,sdm845-cpu-bwmon.yaml >>>> @@ -0,0 +1,97 @@ >>>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >>>> +%YAML 1.2 >>>> +--- >>>> +$id: http://devicetree.org/schemas/interconnect/qcom,sdm845-cpu-bwmon.yaml# >>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>> + >>>> +title: Qualcomm Interconnect Bandwidth Monitor >>>> + >>>> +maintainers: >>>> + - Krzysztof Kozlowski >>>> + >>>> +description: >>>> + Bandwidth Monitor measures current throughput on buses between various NoC >>>> + fabrics and provides information when it crosses configured thresholds. >>>> + >>>> +properties: >>>> + compatible: >>>> + enum: >>>> + - qcom,sdm845-cpu-bwmon # BWMON v4 >>> >>> It seems the thing that's called bwmon v4 is compatible with a number of >>> different platforms, should we add a generic compatible to the binding >>> as well, to avoid having to update the implementation for each SoC? >>> >>> (I.e. "qcom,sdm845-cpu-bwmon", "qcom,bwmon-v4") > > it seems pretty useful to have the "qcom,bwmon-v4" and "qcom,bwmon-v5" > compatibles, I tried these patches on a sc7280 device which has a bwmon4 > between the cpu and caches (and also has a bwmon5 between the caches and DDR) > and the driver works with zero changes. The trouble with naming it v4 is that such versioning does not exist in documentation. At least I failed to find it. Neither there is clear mapping between SoC and block version. The only indication about BWMON versioning comes from downstream sources, which I find not enough to justify usage of versions for blocks. Therefore as per DT recommendation (which I am enforcing on others) I am not planning put there bwmon-v4. Best regards, Krzysztof