Re: [PATCH 7/7] arm64: dts: qcom: sda660-ifc6560: enable mDSP and WiFi devices

[Konrad Dybcio <konradybcio@kernel.org>]

On 7.09.2024 8:48 PM, Dmitry Baryshkov wrote:
> Enable the onboard WiFi device present on the Inforce IFC6560 SBC.
> Pretty much like MSM8998 this device also doesn't generate the
> MSA_READY_IND indication.
> 
> For the reference:
> 
> ath10k_snoc 18800000.wifi: qmi chip_id 0x30214 chip_family 0x4001 board_id 0xff soc_id 0x40050000
> ath10k_snoc 18800000.wifi: qmi fw_version 0x101d01da fw_build_timestamp 2018-07-26 21:42 fw_build_id QC_IMAGE_VERSION_STRING=WLAN.HL.1.0.1.c2-00474-QCAHLSWMTPLZ-1
> ath10k_snoc 18800000.wifi: qmi not waiting for msa_ready indicator
> ath10k_snoc 18800000.wifi: wcn3990 hw1.0 target 0x00000008 chip_id 0x00000000 sub 0000:0000
> ath10k_snoc 18800000.wifi: kconfig debug 1 debugfs 0 tracing 0 dfs 0 testmode 0
> ath10k_snoc 18800000.wifi: firmware ver  api 5 features wowlan,mgmt-tx-by-reference,non-bmi crc32 b3d4b790
> ath10k_snoc 18800000.wifi: htt-ver 3.54 wmi-op 4 htt-op 3 cal file max-sta 32 raw 0 hwcrypto 1
> ath10k_snoc 18800000.wifi: invalid MAC address; choosing random
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> 
> ---
> Cc: ath11k@lists.infradead.org
> Cc: Kalle Valo <kvalo@kernel.org>
> ---
>  .../arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts b/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts
> index 09bc010ce56a..7948c8f6ab64 100644
> --- a/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts
> +++ b/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts
> @@ -252,6 +252,11 @@ &qusb2phy1 {
>  	vdda-phy-dpdm-supply = <&vreg_l7b_3p125>;
>  };
>  
> +&remoteproc_mss {
> +	firmware-name = "qcom/sda660/mba.mbn", "qcom/sda660/modem.mbn";
> +	status = "okay";
> +};
> +
>  &rpm_requests {
>  	regulators-0 {
>  		compatible = "qcom,rpm-pm660-regulators";
> @@ -291,6 +296,11 @@ vreg_l1a_1p225: l1 {
>  			regulator-allow-set-load;
>  		};
>  
> +		vreg_l5a_0p8: l5 {
> +			regulator-min-microvolt = <848000>;
> +			regulator-max-microvolt = <848000>;
> +		};
> +
>  		vreg_l6a_1p3: l6 {
>  			regulator-min-microvolt = <1304000>;
>  			regulator-max-microvolt = <1368000>;
> @@ -489,3 +499,15 @@ &usb3_qmpphy {
>  	vdda-pll-supply = <&vreg_l10a_1p8>;
>  	status = "okay";
>  };
> +
> +&wifi {
> +	status = "okay";

You placed status last in the addition above but not here :P

with that fixed:



Reviewed-by: Konrad Dybcio <konradybcio@kernel.org>

Konrad