Devicetree
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: eliza: Fix disp_cc_mdss_mdp_clk_src RCG stall on Eliza EVK
Date: Tue, 23 Jun 2026 13:38:27 +0200	[thread overview]
Message-ID: <be95b95b-dbcb-4b80-94dd-a7e97ef4c446@oss.qualcomm.com> (raw)
In-Reply-To: <de941d2d-df5d-44b6-b95a-437e35917cd5@oss.qualcomm.com>

On 6/23/26 1:31 PM, Krzysztof Kozlowski wrote:
> On 23/06/2026 13:27, Krzysztof Kozlowski wrote:
>> Eliza EVK (eliza-cqs-evk.dts) does not have display enabled, however its
>> Display Clock Controller is enabled and references parent clocks from
>> DSI PHYs.  Devices which in base DTSI do not have all required resources
>> available (e.g. because they are simply disabled), should not be enabled
>> in the first place.
>>
>> Having DISPCC enabled without DSI PHYs causes clock reparenting issues
>> and warning on Eliza EVK:
>>
>>   disp_cc_mdss_mdp_clk_src: rcg didn't update its configuration.
>>   WARNING: drivers/clk/qcom/clk-rcg2.c:136 at update_config+0xd4/0xe4, CPU#1: udevd/273
>>   ...
>>     update_config (drivers/clk/qcom/clk-rcg2.c:136 (discriminator 2)) (P)
>>     clk_rcg2_shared_disable (drivers/clk/qcom/clk-rcg2.c:1471)
>>     clk_rcg2_shared_init (drivers/clk/qcom/clk-rcg2.c:1540)
>>     __clk_register (drivers/clk/clk.c:3959 drivers/clk/clk.c:4368)
>>     devm_clk_hw_register (drivers/clk/clk.c:4448 (discriminator 1) drivers/clk/clk.c:4672 (discriminator 1))
>>     devm_clk_register_regmap (drivers/clk/qcom/clk-regmap.c:104)
>>     qcom_cc_really_probe (drivers/clk/qcom/common.c:418)
>>     qcom_cc_probe (drivers/clk/qcom/common.c:445)
>>     disp_cc_eliza_probe (dispcc-eliza.c:?) dispcc_eliza
>>     platform_probe (drivers/base/platform.c:1432)
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>> ---
>>  arch/arm64/boot/dts/qcom/eliza-mtp.dts | 4 ++++
>>  arch/arm64/boot/dts/qcom/eliza.dtsi    | 1 +
>>  2 files changed, 5 insertions(+)
> 
> 
> I should call it RFC, because this feels like a band-aid and should be
> fixed in clock drivers maybe. Eventually DISPCC should be enabled on
> Eliza EVK for HDMI, but DSI PHY will stay disabled.

I'd say all of that hardware should be kept enabled, if only to
make sure that it's parked safely

Konrad

  reply	other threads:[~2026-06-23 11:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-23 11:27 [PATCH] arm64: dts: qcom: eliza: Fix disp_cc_mdss_mdp_clk_src RCG stall on Eliza EVK Krzysztof Kozlowski
2026-06-23 11:31 ` Krzysztof Kozlowski
2026-06-23 11:38   ` Konrad Dybcio [this message]
2026-06-23 11:42     ` Krzysztof Kozlowski
2026-06-23 11:43       ` Konrad Dybcio
2026-06-23 11:56         ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be95b95b-dbcb-4b80-94dd-a7e97ef4c446@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox