From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andreas Kemnade <andreas@kemnade.info>,
bcousson@baylibre.com, tony@atomide.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: omap4-embt2ws: Add Bluetooth
Date: Wed, 27 Sep 2023 09:56:28 +0200 [thread overview]
Message-ID: <be991b32-018a-478d-bd74-6c79ea1c788e@linaro.org> (raw)
In-Reply-To: <20230926204204.2120316-1-andreas@kemnade.info>
On 26/09/2023 22:42, Andreas Kemnade wrote:
> Since the required clock is now available, add bluetooth.
>
> Note: Firmware (bts file) from device vendor reroutes tx for some time
> during initialisation and later put it back, producing timeouts in
> bluetooth initialisation but ignoring that command leads to proper
> initialisation.
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
> Depends on: https://lore.kernel.org/linux-omap/20230916100515.1650336-6-andreas@kemnade.info/T/#u
> arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts
> index 9d2f2d8639496..25b80385dc1f0 100644
> --- a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts
> +++ b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts
> @@ -478,10 +478,12 @@ &uart2 {
> interrupts-extended = <&wakeupgen GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH
> &omap4_pmx_core OMAP4_UART2_RX>;
>
> - /*
> - * BT + GPS in WL1283 in WG7500 requiring CLK32KAUDIO of pmic
> - * which does not have a driver
> - */
> + bluetooth: tiwi {
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
E.g. "bluetooth"
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-09-27 7:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 20:42 [PATCH] ARM: dts: omap4-embt2ws: Add Bluetooth Andreas Kemnade
2023-09-27 7:56 ` Krzysztof Kozlowski [this message]
2023-09-27 16:29 ` Andreas Kemnade
2023-09-28 4:54 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be991b32-018a-478d-bd74-6c79ea1c788e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andreas@kemnade.info \
--cc=bcousson@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).