From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1F82EB64D9 for ; Mon, 10 Jul 2023 14:48:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231637AbjGJOsL (ORCPT ); Mon, 10 Jul 2023 10:48:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230047AbjGJOsK (ORCPT ); Mon, 10 Jul 2023 10:48:10 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE927118 for ; Mon, 10 Jul 2023 07:48:08 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-991c786369cso564030466b.1 for ; Mon, 10 Jul 2023 07:48:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689000487; x=1691592487; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0zUz1F8t9WEy32K0WQzvG/tkTggRTR3113BWQqc0TAA=; b=OkpkR98UNKE1L7UjqB/hs8uZpKo2qzBIvbd3JgkfDo7ePiifR3C2gqjY3qh3r7Umni 9eEQptj5rNxCtADx0qUDxJPbMot36PYWDZ9B5RxmrZguWpF2VUdGIqFxnWM4Keil68w7 Rd+8K23yFKYKY+WRwR808JqH5nm5OUFVnmETF+LsbIKb43Expt9IR4XAda30Glg4CerA n3qzdFYtrM9cigbYW3x16/IfrpF2bA+KqQGNmUgTCbLkf6kKCTuNL0+s+oAdQ6gkXqvH FkSbRhp3EDX/iTfKRzSmGoRn4KC9BSbRtsx0RJ1izQOCEEHJU0kSiYDx2+o60sdJzc7R LDLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689000487; x=1691592487; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0zUz1F8t9WEy32K0WQzvG/tkTggRTR3113BWQqc0TAA=; b=aREfIDRV8N8ZqlTFXr3UcM7lIThOLv3won7oTnY+J4GaJOHasrNXP1MA86uD6sDXWC kbUgS1gzwNatEL5x3SUq4g1BiCStBcc60x9C7xv09Pyoy83rP7yh8W8LgLYiA9XQq6HL ti6AGJQbWZ1lS0tjju4x5ukxU2mbLtqLfNw4Qe8IG9Fh5yDR91RYt3wTbwbVkishAzCp KFiu8f0VE70751uWp45Vti83PRuJta2ni3+CtcgL1cB6CgBRcopwtQvq/E39SedN/GS+ EIVCzCjHkTUeSpmqQ7jLUcSz8iknlabmEUKZksneK9RRKAlKd99iyrCAt8O//8SP9G/1 UtXQ== X-Gm-Message-State: ABy/qLYOE7xEFwe2DdR5a3XgfMq9gyUKNHA54gXUsSnl/dQ5b4nUbdLP LhITzLrq/vHsDUrEvWmmkUXDyA== X-Google-Smtp-Source: APBJJlH4AXkRENLH/gW901quCxj9gQR9PgVXbmX2ni6qf+0KlpuIOL301ZCHjSNB/cdAHbYqljwGBg== X-Received: by 2002:a17:906:300b:b0:98e:1deb:cb03 with SMTP id 11-20020a170906300b00b0098e1debcb03mr10212757ejz.56.1689000487153; Mon, 10 Jul 2023 07:48:07 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id j17-20020a170906279100b00982a352f078sm6181160ejc.124.2023.07.10.07.48.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Jul 2023 07:48:06 -0700 (PDT) Message-ID: Date: Mon, 10 Jul 2023 16:48:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v3] arm64: dts: qcom: sdm845-db845c: Mark cont splash memory region as reserved To: Amit Pundir , Bjorn Andersson , Andy Gross , Dmitry Baryshkov , Rob Herring , Konrad Dybcio , Krzysztof Kozlowski , Conor Dooley , Caleb Connolly , Bryan Donoghue Cc: linux-arm-msm , dt , lkml References: <20230616065123.3710734-1-amit.pundir@linaro.org> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <20230616065123.3710734-1-amit.pundir@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 16/06/2023 08:51, Amit Pundir wrote: > Adding a reserved memory region for the framebuffer memory > (the splash memory region set up by the bootloader). > > Signed-off-by: Amit Pundir > --- > v3: Point this reserved region to MDSS. > > v2: Updated commit message. > > There was some dicussion on v1 but it didn't go anywhere, > https://lore.kernel.org/linux-kernel/20230124182857.1524912-1-amit.pundir@linaro.org/T/#u. > The general consensus is that this memory should be freed and be > made resuable but that (releasing this piece of memory) has been > tried before and it is not trivial to return the reserved memory > node to the system RAM pool in this case. > > arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > index df2fde9063dc..503136eb9c06 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > @@ -101,6 +101,14 @@ hdmi_con: endpoint { > }; > }; > > + reserved-memory { > + /* Cont splash region set up by the bootloader */ > + cont_splash_mem: framebuffer@9d400000 { > + reg = <0x0 0x9d400000 0x0 0x2400000>; > + no-map; > + }; > + }; > + > lt9611_1v8: lt9611-vdd18-regulator { > compatible = "regulator-fixed"; > regulator-name = "LT9611_1V8"; > @@ -517,6 +525,7 @@ &i2c14 { > }; > > &mdss { > + memory-region = <&cont_splash_mem>; Just to be sure: does this pass the dtbs_check testing? I would say it does not and wasn't tested :( Best regards, Krzysztof