From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16162C3F6B0 for ; Fri, 5 Aug 2022 06:53:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237468AbiHEGx3 (ORCPT ); Fri, 5 Aug 2022 02:53:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235981AbiHEGx2 (ORCPT ); Fri, 5 Aug 2022 02:53:28 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5950E13DD5 for ; Thu, 4 Aug 2022 23:53:27 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id t1so2148434lft.8 for ; Thu, 04 Aug 2022 23:53:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=svGbdJtoA42vxhMw0xl6uJ/CKt4Zq7+usPD0U/PNy5Q=; b=fcizwj7UD0ZDd1mZ0oDmsurKWnpaQ6W8uIjVJaOD0QvmsghpTV2mhyjgilSZfV3gfp VKxKifhMNxIxkv84hkBVE/pSxJMeMj+KoWkFL2y+KDM6m2ZZWeC9sJYVxT6Eo7Xe5I1W iV/F1O2wQ9eUQTVwfppVzZa0FHW+OxPbQV5/ji8lTUwWD3fxaFyFZOx4kNeQCte4KSj8 xKOGnH+sqff7E8e7Pb1UHtsuYRJl+IYJZbr6Ce0PeJiLzh1nHgmWeMbzZFyduUJFdbcX GB7zxiqDzQ0zakdY5rGcgEwK7b7VDGioVCMp2950fn0J5lmPnn7nh8gr6S99j3QHei4p vsYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=svGbdJtoA42vxhMw0xl6uJ/CKt4Zq7+usPD0U/PNy5Q=; b=Tg3jqOQtb8D9oR5GLxwXVvhOTKiyomfZOhcqLpinZBV8ATmUJoq9bmoQRAdpnwcytz Q2EnGGtn0+H+hugs+b9EVFLT/53BYDQ+oBFFLYWXlBLLziHWGnT8m6+q8ucKgrV6TPYh bhfV7dT/Bp9zW5OxjqNUS6GYl+AEgGv6u+rbpLF9Grat/dZGr0dZhVH5/LrmTXgRsV/y lPOTvGO37kZ2KVpmf4J0M983EM97MvkrEPKzMC8O/GKoajQb8nWgIHw6reQvMudlooTa /YdBLckscJTzWHGUtrX6Jqo9/K/KZ4Wd5NvC8SIVMJ8CkV01WVjKDMCEmxg2fVvbF6bN Bf6g== X-Gm-Message-State: ACgBeo3QIVS8bgU2HOmabMr2SV9Yb5Dk+8vMO0m7VwE71YcV8984wu9o xwdb6pPSRXUGoS/t9XBZF/pZIQ== X-Google-Smtp-Source: AA6agR5PP/ENG7yXEHTvyafw/XQB2vIAh7cCSieTd83vPiy91LJfZPa5YrNOmaUMVOVwlr0V6qymXg== X-Received: by 2002:a05:6512:230b:b0:48a:7c11:664d with SMTP id o11-20020a056512230b00b0048a7c11664dmr2034885lfu.390.1659682405752; Thu, 04 Aug 2022 23:53:25 -0700 (PDT) Received: from [192.168.1.6] ([77.222.167.48]) by smtp.gmail.com with ESMTPSA id z16-20020a2e9650000000b0025dd6c8933csm362348ljh.114.2022.08.04.23.53.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Aug 2022 23:53:23 -0700 (PDT) Message-ID: Date: Fri, 5 Aug 2022 08:53:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v4 3/8] dt-bindings: clock: Add ids for Lynx 10g PLLs Content-Language: en-US To: Sean Anderson , Vinod Koul , Kishon Vijay Abraham I , linux-phy@lists.infradead.org Cc: devicetree@vger.kernel.org, Madalin Bucur , Camelia Alexandra Groza , linuxppc-dev@lists.ozlabs.org, Rob Herring , linux-arm-kernel@lists.infradead.org, Ioana Ciornei , Krzysztof Kozlowski , Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org References: <20220804220602.477589-1-sean.anderson@seco.com> <20220804220602.477589-4-sean.anderson@seco.com> From: Krzysztof Kozlowski In-Reply-To: <20220804220602.477589-4-sean.anderson@seco.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 05/08/2022 00:05, Sean Anderson wrote: > This adds ids for the Lynx 10g SerDes's internal PLLs. These may be used > witn assigned-clock* to specify a particular frequency to use. > > Signed-off-by: Sean Anderson > --- > > Changes in v4: > - New > > include/dt-bindings/clock/fsl,lynx-10g.h | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > create mode 100644 include/dt-bindings/clock/fsl,lynx-10g.h > > diff --git a/include/dt-bindings/clock/fsl,lynx-10g.h b/include/dt-bindings/clock/fsl,lynx-10g.h > new file mode 100644 > index 000000000000..f5b955658106 > --- /dev/null > +++ b/include/dt-bindings/clock/fsl,lynx-10g.h > @@ -0,0 +1,14 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ This should be dual license. > +/* > + * Copyright (C) 2022 Sean Anderson It's confusing to see personal copyrights with company email. Either the copyright is attributed to your employer or to you. If to you, use private email. > + */ > + > +#ifndef __DT_BINDINGS_CLK_LYNX_10G_H > +#define __DT_BINDINGS_CLK_LYNX_10G_H > + > +#define LYNX10G_CLKS_PER_PLL 2 > + > +#define LYNX10G_PLLa(a) ((a) * LYNX10G_CLKS_PER_PLL) > +#define LYNX10G_PLLa_EX_DLY(a) ((a) * LYNX10G_CLKS_PER_PLL + 1) These do not look like proper IDs for clocks for bindings. Numbering starts from 0 or 1 and any "a" needs to be clearly explained. What do you bind here? > + > +#endif /* __DT_BINDINGS_CLK_LYNX_10G_H */ Best regards, Krzysztof