From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8E78C4332F for ; Thu, 17 Nov 2022 09:02:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239362AbiKQJC2 (ORCPT ); Thu, 17 Nov 2022 04:02:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234643AbiKQJC1 (ORCPT ); Thu, 17 Nov 2022 04:02:27 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A2F259178 for ; Thu, 17 Nov 2022 01:02:25 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id cl5so2601501wrb.9 for ; Thu, 17 Nov 2022 01:02:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=DqXNcJKGEk90R2legdFOv2JapBqj5ImP7hXsUpdTZn8=; b=B3w1xVlut+g3cx+uKRyaiDgM6Uy0uLwMy0yLt6VPJeXSsUuIHeBFk2Lj0xKmfi1E6X UpUwbS87bUj4ncJzDWQEIUObm0ToRVGioICxTdMqg90wyQNksB0V+ndD3yxDu6OGTi6X V5DKkZiG+qLNGHLsB3F44BjDnl6VxvRV/LqWh5wLfCKQHU2rKrLbRBkB1RNUFsa1PNuK PboecoBTuu/0GjI6/k+RC7AG49vT7BSjotEUAR2GFMvSPy2lOHiSLdseNrewTB/NFFaD fYqXa+ePNELNoPY3l7izU6e76j7hHTDiDy1hhhv+rusgkoDbwmYAJiEzvP1VaRqKlLMS Y6BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DqXNcJKGEk90R2legdFOv2JapBqj5ImP7hXsUpdTZn8=; b=laWuEsjefzLPbn0d9hequ3vpKAJeAR74kFi7CUrxACTfNOd9AUrib9w2DtfVwIKW2v cBQVmU42xKtyJ5ktYfKS1rwLJfTJRczw2pnsyiLpCowRIhLhbwmXoHIOGB6bUnIpL7mw jTIyAI8SNDLqkgh5ickXTJD9XrAFqwdvjAfAg2MIRomXqNjV/S/KZQzfGgOAokbigkVS 49CsFEsbdUQzmhraoODf+n/iU6+v1SbOpVsFhNKGv0x2R78H6v37EEzCeDBxhW/yNJJh jwR0042c8+r150pLraqVbCOe6PKiajGAc9aG+xx2a1R10REOY6UMP4dzQcnUFUy1uyq/ hu9w== X-Gm-Message-State: ANoB5plcMV8O7FRKUTd733oFrXW5j8Eb6/iydcsZPrdw0KLeP5yWQW3o hVIwSU5BFcvnF472Xa5a1G9sUw== X-Google-Smtp-Source: AA0mqf6SP7JQdGyyqDOZ6gBL0qEJ+oVzm11ooMlDI/kxn7uldpXQH3s82B0YuJjy2P6KVsdar0/6qg== X-Received: by 2002:adf:db81:0:b0:236:5144:f8ce with SMTP id u1-20020adfdb81000000b002365144f8cemr830227wri.657.1668675743980; Thu, 17 Nov 2022 01:02:23 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:aad5:8d14:a22f:2e8b? ([2a01:e0a:982:cbb0:aad5:8d14:a22f:2e8b]) by smtp.gmail.com with ESMTPSA id n17-20020a05600c465100b003cf483ee8e0sm4364699wmo.24.2022.11.17.01.02.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Nov 2022 01:02:23 -0800 (PST) Message-ID: Date: Thu, 17 Nov 2022 10:02:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 1/4] dt-bindings: remoteproc: qcom: adsp: document sm8550 adsp, cdsp & mpss compatible Content-Language: en-US To: Rob Herring , Krzysztof Kozlowski Cc: Krzysztof Kozlowski , Bjorn Andersson , Konrad Dybcio , Andy Gross , Manivannan Sadhasivam , Amol Maheshwari , Srinivas Kandagatla , Mathieu Poirier , devicetree@vger.kernel.org, Abel Vesa , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org References: <20221114-narmstrong-sm8550-upstream-remoteproc-v1-0-104c34cb3b91@linaro.org> <20221114-narmstrong-sm8550-upstream-remoteproc-v1-1-104c34cb3b91@linaro.org> <20221116233907.GA1227164-robh@kernel.org> Organization: Linaro Developer Services In-Reply-To: <20221116233907.GA1227164-robh@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 17/11/2022 00:39, Rob Herring wrote: > On Wed, Nov 16, 2022 at 01:28:11PM +0100, Krzysztof Kozlowski wrote: >> On 16/11/2022 11:20, Neil Armstrong wrote: >>> This documents the compatible for the component used to boot the >>> aDSP, cDSP and MPSS on the SM8550 SoC. >>> >>> The SM8550 boot process on SM8550 now requires a secondary "Devicetree" >>> firmware to be passed along the main Firmware, and the cDSP a new power >>> domain named "NSP". >>> >>> Signed-off-by: Neil Armstrong >>> --- >>> .../devicetree/bindings/remoteproc/qcom,adsp.yaml | 60 +++++++++++++++++++++- >>> 1 file changed, 59 insertions(+), 1 deletion(-) >>> >>> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml >>> index db9e0f0c2bea..678cb73f10de 100644 >>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml >>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml >>> @@ -55,6 +55,9 @@ properties: >>> - qcom,sm8450-cdsp-pas >>> - qcom,sm8450-mpss-pas >>> - qcom,sm8450-slpi-pas >>> + - qcom,sm8550-adsp-pas >>> + - qcom,sm8550-cdsp-pas >>> + - qcom,sm8550-mpss-pas >>> >>> reg: >>> maxItems: 1 >>> @@ -116,8 +119,13 @@ properties: >>> $ref: /schemas/types.yaml#/definitions/string >>> description: Firmware name for the Hexagon core >>> >>> + qcom,dtb-firmware-name: >>> + $ref: /schemas/types.yaml#/definitions/string >>> + description: Devicetree Firmware name for the Hexagon core >> >> Not sure about this one. >> >> Rob, >> Don't we want rather to have multiple items in firmware-name? > > Yes, I think we already have that for some users. Should have been > 'firmware-names' I guess but I don't think it's worth dealing with > another case of handling both (forever). I'll be happy to switch to a single property but yeah, firmware-name isn't right for multiple names... Anyway, will follow qcom,sc7180-mss-pil.yaml since they already use 2 entries there. Neil > > Rob