Re: [PATCH] arm64: dts: rockchip: make "poweroff" work on rock-5a

[Dragan Simic <dsimic@manjaro.org>]

On 2024-06-11 15:37, Dragan Simic wrote:
> Hello Fukami,
> 
> On 2024-06-11 14:27, FUKAUMI Naoki wrote:
>> to make "poweroff" command work, add "system-power-controller;" into
>> pmic@0. without this, "poweroff" works as same as "reboot".

Sorry, I forgot to add that the description above could be reworded
a bit, e.g. not to repeat what's already visible in the patch itself.

For example:

     Designate the RK806 PMIC on the Radxa ROCK 5A as the system power
     controller, so the board shuts down properly on poweroff(8).

The patch subject could also be tweaked a bit, e.g. to refer to the
board as "Radxa ROCK 5A".

>> Fixes: 75fdcbc8f4c1 ("arm64: dts: rockchip: add PMIC to rock-5a")
>> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
> 
> Looking good to me, with a small remark below.
> 
> Reviewed-by: Dragan Simic <dsimic@manjaro.org>
> 
>> ---
>>  arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 2 ++
>>  1 file changed, 2 insertions(+)
>> 
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
>> b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
>> index b070955627be..cf7b878a3eb2 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
>> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
>> @@ -395,6 +395,8 @@ pmic@0 {
>>  			    <&rk806_dvs2_null>, <&rk806_dvs3_null>;
>>  		spi-max-frequency = <1000000>;
>> 
> 
> I don't think there's need for the empty line right above, i.e.
> between the "spi-max-frequency" and "system-power-controller" lines.
> 
>> +		system-power-controller;
>> +
>>  		vcc1-supply = <&vcc5v0_sys>;
>>  		vcc2-supply = <&vcc5v0_sys>;
>>  		vcc3-supply = <&vcc5v0_sys>;
> 
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip