From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EB2615748F for ; Thu, 11 Jul 2024 10:00:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720692058; cv=none; b=ei69+4ASjxQbrj7DBB+mY7Nux2NVLL37QfhNrlT5j/n0LA4eshJSOXkkXkSwCOvss1LEe7JmBtksXnx/B3ZihjSbmu5jpHtfWvBZ/ZquBH5n9k98LAlgCdzt7BJCbgAmD0RWGHQEpAiyXS3d1Ic4DBB+7LMXkcZHDD6zzmpufKM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720692058; c=relaxed/simple; bh=Gk8bIow0J+Zb+3HXWKHfOllEFT0LGnZiQIPudI7cyvs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OyDXqJNHXKSbZOvtHNFLyYusff34z8YPCq23e4/Fm7tiqxBS7BdxA9uIz9JeeV3mLGxEM0zqeGhYt0KHEjh4gJNMkPZMRAzvY/h+IMrB3s2J4J6d/eOwflVEe57m0D3/lcbyjvcgdIfh2oEO5mJNbIi6UIbIzZKIDZ9TKpDUOww= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=W0QR077U; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="W0QR077U" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-a7527afa23cso84187966b.2 for ; Thu, 11 Jul 2024 03:00:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720692053; x=1721296853; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=o2fLrpnY2OFXTI/2z6+IbgCmNHL/Iy6X0ASNnkah1Sc=; b=W0QR077UTJ5dprCeoLN8hbzif8Qjnu8ir/0d9oihFGb91TIBz7CJcc7aGDgzhsqFGA lD9WtPTEERoA09Badr+OXSM8x8/+uXHkVB1w4OdPzTS8+Vgo1RBWdegdz8Us3iakxV8A shocRxE8YAdNl+p/L/AJIWFqJyb3pZrRfvSwUrRWdhfQMZL7JEQlNbiYvTdcYOQ92jdR IugkyrvpA6RZYDnKtliEjCRXC5szJhGjQ84Be8K2QBeT0TMeTupVk8q3abtOr6pVY/yo v4B4ZmDVHmkYI+A34jY4DZAGM/bsw5rhXWOT/sDZr2CX0HfgBn+pVTi/JBIaxTVUvAn9 SggQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720692053; x=1721296853; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=o2fLrpnY2OFXTI/2z6+IbgCmNHL/Iy6X0ASNnkah1Sc=; b=dlJP+XbBfYq0bYkhRgN6WZMn4nSiOBbTY9la4npr3l6+Wg1TdGottTuJaaUgW58cLg 2yqWzmxjwdeyMtLe9RQwvJcG5QD/S/ruwiBfk+3hQ321+8ujpOGSHHnOPF4jtnVKfZYZ qzQJX01gL1EfDUJBEqXrRjymEOacHNyuZ8vMeiyD10wn9nVAp6DPvWsPHRu9x0YTllXi FqHHX5yhfQZiJZPC5ZDYyj1G+bYEqKQD3MQI2y4YYLBdj9Oz6AosTA3guNLU7Nsdkg6V dFGRSBg8llbOO/a/5x2iC0gZfU5g7KIVwIaCYlHOLHz0fYJfC4QUP5wBnBWNspvoqWhA xCEA== X-Forwarded-Encrypted: i=1; AJvYcCWKuHM2DZx4sBzBu9Nn/BJHpRy5dMPMoCnTQxuCtrhKgKY9wykb0hA47It1l5O5pw1U23KP8ompkmCvgrJBHAmQC69y2w4BlixDWA== X-Gm-Message-State: AOJu0YwWlIPd43QPSTHzVX4j7RfwdXcDnTc6Vqc/GBbpCuzDglvO5vQn tbYYcfFGHbGp4CGufPDcWueDE5hXrz9JMs134OseJBvi/7cnsWiDhnFjW5q9Qvw= X-Google-Smtp-Source: AGHT+IF0SzZ5gBhyjX6kOL6plbwNTEzSm62HnomYfO//u0WXELiPcgYVQCh7J1lzkGO2ax0Mf9HRyA== X-Received: by 2002:a17:907:d93:b0:a75:20f7:2c71 with SMTP id a640c23a62f3a-a780b6ff667mr823368666b.38.1720692053227; Thu, 11 Jul 2024 03:00:53 -0700 (PDT) Received: from [192.168.105.194] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a780a6e065dsm237893166b.84.2024.07.11.03.00.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jul 2024 03:00:52 -0700 (PDT) Message-ID: Date: Thu, 11 Jul 2024 12:00:50 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: x1e80100: enable GICv3 ITS for PCIe To: Johan Hovold Cc: Johan Hovold , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Abel Vesa , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240711090250.20827-1-johan+linaro@kernel.org> Content-Language: en-US From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11.07.2024 11:58 AM, Johan Hovold wrote: > On Thu, Jul 11, 2024 at 11:54:15AM +0200, Konrad Dybcio wrote: >> On 11.07.2024 11:02 AM, Johan Hovold wrote: >>> The DWC PCIe controller can be used with its internal MSI controller or >>> with an external one such as the GICv3 Interrupt Translation Service >>> (ITS). >>> >>> Add the msi-map properties needed to use the GIC ITS. This will also >>> make Linux switch to the ITS implementation, which allows for assigning >>> affinity to individual MSIs. >>> >>> Signed-off-by: Johan Hovold >>> --- >> >> X1E CRD throws tons of correctable errors with this on PCIe6a: >> >> [ 9.358915] pcieport 0007:00:00.0: PCIe Bus Error: severity=Correctable, type=Physical Layer, (Receiver ID) >> [ 9.358916] pcieport 0007:00:00.0: device [17cb:0111] error status/mask=00000001/0000e000 >> [ 9.358917] pcieport 0007:00:00.0: [ 0] RxErr >> [ 9.358921] pcieport 0007:00:00.0: AER: Multiple Correctable error message received from 0007:00:00.0 >> [ 9.358952] pcieport 0007:00:00.0: AER: found no error details for 0007:00:00.0 >> [ 9.358953] pcieport 0007:00:00.0: AER: Multiple Correctable error message received from 0007:00:00.0 >> [ 9.359003] pcieport 0007:00:00.0: AER: found no error details for 0007:00:00.0 >> [ 9.359004] pcieport 0007:00:00.0: AER: Multiple Correctable error message received from 0007:01:00.0 >> [ 9.359008] pcieport 0007:00:00.0: PCIe Bus Error: severity=Correctable, type=Physical Layer, (Transmitter ID) >> [ 9.359009] pcieport 0007:00:00.0: device [17cb:0111] error status/mask=00001001/0000e000 >> [ 9.359010] pcieport 0007:00:00.0: [ 0] RxErr >> [ 9.359011] pcieport 0007:00:00.0: [12] Timeout > > What branch are you using? Abel reported seeing this with his branch > which has a few work-in-progress patches that try to enable 4-lane PCIe. > > There are no errors with my wip branch based on rc7, and I have the same > drive as Abel. linux-next/master > > Also note that the errors happen also without this patch applied, they > are just being reported now. Ouch.. wonder how much that drives the perf down Konrad