From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Caleb Connolly <caleb@connolly.tech>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
devicetree@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v2 1/3] arm64: dts: qcom: sdm845: commonize bluetooth UART pinmux
Date: Sun, 16 Oct 2022 21:12:14 -0400 [thread overview]
Message-ID: <bf4db82c-aaba-0fc4-ed6c-4945193a4e92@linaro.org> (raw)
In-Reply-To: <20221016172944.1892206-2-kc@postmarketos.org>
On 16/10/2022 13:29, Caleb Connolly wrote:
> From: Caleb Connolly <caleb@connolly.tech>
>
> The 4-pin configuration for UART6 is used for all or almost all SDM845
> devices with built in Bluetooth. Move the pinmux configuration to
> sdm845.dtsi in preparation to be removed from individual devices in
> future patches.
>
> Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Signed-off-by: Caleb Connolly <caleb@connolly.tech>
(...)
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index f0e286715d1b..55de40bea684 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -2971,6 +2971,28 @@ pinmux {
> };
> };
>
> + qup_uart6_4pin: qup-uart6-4pin-state {
> +
No need for blank line here.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-10-17 1:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-16 17:29 [PATCH v2 0/3] arm64: dts: qcom: sdm845: commonize bluetooth pinconf Caleb Connolly
2022-10-16 17:29 ` [PATCH v2 1/3] arm64: dts: qcom: sdm845: commonize bluetooth UART pinmux Caleb Connolly
2022-10-17 1:12 ` Krzysztof Kozlowski [this message]
2022-10-16 17:29 ` [PATCH v2 2/3] arm64: dts: qcom: sdm845-shift-axolotl: fix Bluetooth Caleb Connolly
2022-10-16 17:29 ` [PATCH v2 3/3] arm64: dts: qcom: sdm845-*: fix uart6 aliases Caleb Connolly
2022-10-18 3:05 ` [PATCH v2 0/3] arm64: dts: qcom: sdm845: commonize bluetooth pinconf Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf4db82c-aaba-0fc4-ed6c-4945193a4e92@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=caleb@connolly.tech \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).