From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0C44C4338F for ; Fri, 20 Aug 2021 14:17:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C0C90610FF for ; Fri, 20 Aug 2021 14:17:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240401AbhHTORw (ORCPT ); Fri, 20 Aug 2021 10:17:52 -0400 Received: from foss.arm.com ([217.140.110.172]:33220 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235032AbhHTORw (ORCPT ); Fri, 20 Aug 2021 10:17:52 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5C0E311FB; Fri, 20 Aug 2021 07:17:13 -0700 (PDT) Received: from [10.57.15.112] (unknown [10.57.15.112]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2432C3F66F; Fri, 20 Aug 2021 07:17:12 -0700 (PDT) Subject: Re: [PATCH] ARM: dts: rockchip: remove cap-mmc-highspeed property from mk808 &mmc0 node To: Johan Jonker , heiko@sntech.de Cc: robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, paweljarosz3691@gmail.com References: <20210820131920.1831-1-jbx6244@gmail.com> From: Robin Murphy Message-ID: Date: Fri, 20 Aug 2021 15:17:06 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210820131920.1831-1-jbx6244@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2021-08-20 14:19, Johan Jonker wrote: > On the MK808 only a microSD slot is connected with the SDMMC Host Controller, > so remove the cap-mmc-highspeed property from the &mmc0 node. Why, does it do any harm? It's perfectly possible to connect a full-sized card to a microSD slot with an adapter. I came across my old SDIO WiFi card a while back and tried it that way for a giggle, but unfortunately it turned out not to be a chipset supported by any upstream driver. Robin. > Signed-off-by: Johan Jonker > --- > arch/arm/boot/dts/rk3066a-mk808.dts | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm/boot/dts/rk3066a-mk808.dts b/arch/arm/boot/dts/rk3066a-mk808.dts > index 9790bc63b..b67f5cb51 100644 > --- a/arch/arm/boot/dts/rk3066a-mk808.dts > +++ b/arch/arm/boot/dts/rk3066a-mk808.dts > @@ -123,7 +123,6 @@ > > &mmc0 { > bus-width = <4>; > - cap-mmc-highspeed; > cap-sd-highspeed; > vmmc-supply = <&vcc_sd>; > status = "okay"; >