Re: [PATCH v3 5/9] memory: tegra210: Support interconnect framework

[Krzysztof Kozlowski <krzk@kernel.org>]

On 15/09/2025 08:08, Aaron Kling wrote:
> On Wed, Sep 10, 2025 at 5:07 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>>> +    icc_provider_init(&emc->icc_provider);
>>>> +
>>>> +    /* create External Memory Controller node */
>>>> +    node = icc_node_create(TEGRA_ICC_EMC);
>>>> +    if (IS_ERR(node)) {
>>>> +            err = PTR_ERR(node);
>>>> +            goto err_msg;
>>>
>>> return dev_err_probe
>>
>>
>> I will send patches to fix existing code. I also found some more issues
>> which I would like to implement here.
>>
>> I apologize for coming with all this at v3. I should point out things a
>> bit earlier, although how this patchset was organized also affected review.
>>
>> Anyway my comments are mostly non-critical things, so v3 is late to
>> bring these, I understand. That's on me. I appreciate your work and
>> please do not get discouraged with my comments.
> 
> I understand and that's fine. Get it done right the first time so it
> doesn't have to be redone later. I will try to get a new revision out
> this week once I cycle back around to the relevant devices here.
> 

Just FYI, I closed my tree already so I will take anything after merge
window earliest.

Best regards,
Krzysztof