From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE0CC48AE20; Wed, 1 Jul 2026 13:01:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782910919; cv=none; b=DYl+XolukXmSYM8wc8+w+8yukdhimrfmM1SuX59wZut5lwRZ0tU12PnAGlYV6LJCki3N5O7tv0d3t0Dk707nTWp+5TFz9PB6xtw0NY0lRSZ6pX72LyDvuuxJMytpapUDVC4HBjZPzXOX95CGL0XXn3v83/p6Zx+1WPgthbslI0A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782910919; c=relaxed/simple; bh=jnxZnh5V2zsErqh9R6TXWkelWIbod9lmGFF4LYtgJDc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OsEBDKJX8tNSynfVAVgGjP6WYgNPCvdMpr8ZpFo6/62PrHgM3sALgw3UBesgu4ojkw06SP9+ywT/wfHyPnN4Yau9vVRNgruuDas+an2nqiXH+N4RFhYiZMHMz5Zz+ld8alCYmcowi0DUgpmENmc4BR7I2Ck2E2SEO1ma/lnGDok= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=i8SCwyQh; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="i8SCwyQh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C9F11F000E9; Wed, 1 Jul 2026 13:01:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782910918; bh=xSQsmx4MwF6oqeO3x1f6iZ8pIkIJYGGq6vkgVXhfEIs=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=i8SCwyQhVICEaZZJ/Lp98o2+s119rdkjdwIfsz+v3x7mfvCZzQVIGsEvAj9X0l1Dk FBJejEC86nG5uBNPNuhJ3QvmBxBNGDb5NIVcuY3Yw7vx1VKXdNYUtjebwoBNUk77Ft vTpL3/bY4JTA0KDlgDLDP3nCRUJ//eXv1Itxtkba0Vpl/03h8JOmPssHq0TikKln7J Z4hC3HS8vVR19GIJW7+0bovNE8h7r5AmKj5DlMhiSs8xGpa7DhzzSKob0vj6wG/xKv a6VK22t7YXHmSK3EB0qdMtswtECqe7XABbPBwSX+m5U2RhIC8XQQxQ+n0fFNoNzKLq DytaDNZ3kcFQg== Date: Wed, 1 Jul 2026 14:01:52 +0100 From: Mark Brown To: Matti Vaittinen Cc: Matti Vaittinen , Matti Vaittinen , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Liam Girdwood , Michael Turquette , Stephen Boyd , Brian Masney , Linus Walleij , Bartosz Golaszewski , Alexandre Belloni , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org Subject: Re: [PATCH 5/8] regulator: bd71828: Support ROHM BD73800 Message-ID: References: <1d00359236272fd1fab0dfbcb9119d2f91aa0d23.1782909323.git.mazziesaccount@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jcOo3Xx3B2XL56n0" Content-Disposition: inline In-Reply-To: <1d00359236272fd1fab0dfbcb9119d2f91aa0d23.1782909323.git.mazziesaccount@gmail.com> X-Cookie: Do unto others before they undo you. --jcOo3Xx3B2XL56n0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jul 01, 2026 at 03:42:35PM +0300, Matti Vaittinen wrote: > From: Matti Vaittinen > + nproot = of_get_child_by_name(nproot, "regulators"); > + if (!nproot) { > + dev_err(dev, "failed to find regulators node\n"); > + return -ENODEV; > + } > + for_each_child_of_node(nproot, np) { > + if (of_node_name_eq(np, LDO1_NODE_NAME)) > + ldo1_use_high_range = of_property_read_bool(np, > + "rohm,ldo-range-high"); > + if (of_node_name_eq(np, LDO3_NODE_NAME)) > + ldo3_use_high_range = of_property_read_bool(np, > + "rohm,ldo-range-high"); > + } Why do we iterate over all nodes rather than doing additional of_get_child_by_name()s? > + if (ldo1_use_high_range) { > + d[BD73800_LDO1].desc.linear_ranges = bd73800_ldo13_high_volts; > + d[BD73800_LDO1].desc.n_linear_ranges = > + ARRAY_SIZE(bd73800_ldo13_high_volts); > + } > + if (ldo3_use_high_range) { > + d[BD73800_LDO3].desc.linear_ranges = bd73800_ldo13_high_volts; > + d[BD73800_LDO3].desc.n_linear_ranges = > + ARRAY_SIZE(bd73800_ldo13_high_volts); > + } You could just do these updates without the intermediate variables. --jcOo3Xx3B2XL56n0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmpFD78ACgkQJNaLcl1U h9CBDAf/dk5xA9JPiqbs7lGosK1R3IusuArR8QLpFeRkO7UbIwwMHxsEiTpllWzW gEIuuygVMXAiQ/2K7lt3KwQnEguJnlm3419HhOX7Iuvr5QbXq4Elyf044UvaveHM OCU8sANA3BvR+7CfSHWhymoA+e71GnjArm6MiTsh9zU+qNEIgCmMlSBqg9KoI7qn uJEjHHrLwfWgOdM2jdSLRvkF7P482F4+yIJYjBeZ4xur4DaYkV1/GI7J7iaTWl0c 9keWXd0Sb5B33DUC15jCrkXh0qVx0qZ0CENPNOg91cgsy/GE0h0TwgNQSI82NK3Q LIr8J90ZTo3udY4NKj6vEl7v/vvGtw== =Zag+ -----END PGP SIGNATURE----- --jcOo3Xx3B2XL56n0--