From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3C0FC3A5A9 for ; Mon, 4 May 2020 08:07:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA8F720643 for ; Mon, 4 May 2020 08:07:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727860AbgEDIH3 (ORCPT ); Mon, 4 May 2020 04:07:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727100AbgEDIH3 (ORCPT ); Mon, 4 May 2020 04:07:29 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFCA6C061A0E for ; Mon, 4 May 2020 01:07:28 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=localhost) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jVW8B-0007yE-Il; Mon, 04 May 2020 10:07:15 +0200 Message-ID: Subject: Re: [RFC PATCH 4/4] arm64: dts: imx8mm: Add GPU nodes for 2D and 3D core using Etnaviv From: Lucas Stach To: Adam Ford , Schrempf Frieder Cc: Anson Huang , Christian Gmeiner , Daniel Baluta , Fabio Estevam , Leonard Crestez , Li Jun , NXP Linux Team , Peng Fan , Pengutronix Kernel Team , Russell King , Sascha Hauer , Shawn Guo , "S.j. Wang" , "devicetree@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "etnaviv@lists.freedesktop.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Date: Mon, 04 May 2020 10:07:14 +0200 In-Reply-To: References: <20200430124602.14463-1-frieder.schrempf@kontron.de> <20200430124602.14463-5-frieder.schrempf@kontron.de> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.1 (3.36.1-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Am Sonntag, den 03.05.2020, 09:49 -0500 schrieb Adam Ford: > On Thu, Apr 30, 2020 at 7:46 AM Schrempf Frieder > wrote: > > From: Frieder Schrempf > > > > According to the documents, the i.MX8M-Mini features a GC320 and a > > GCNanoUltra GPU core. Etnaviv detects them as: > > > > etnaviv-gpu 38000000.gpu: model: GC600, revision: 4653 > > etnaviv-gpu 38008000.gpu: model: GC520, revision: 5341 > > > > This seems to work fine more or less without any changes to the HWDB, > > which still might be needed in the future to correct some features, > > etc. > > > > Signed-off-by: Frieder Schrempf > > --- > Since not everyone uses the 3D or 2D, would it make sense to mark them > as disabled by default and let people who need the 3D and 2D enable > them at their respective board files? No, devices on the SoC with no external dependencies should be always enabled. The board has much less influence over whether the GPU is being used than the specific use-case. While the board designer may not even think about using the GPUs (because no display connector present or something like that) people using the board may still find uses for the GPU, like doing video pipeline color space conversions or something lie that. Regards, Lucas