From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: David Heidelberg <david@ixit.cz>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: qcom: apq8960: reflect that memory node starts at offset 0
Date: Fri, 25 Aug 2023 13:57:47 +0200 [thread overview]
Message-ID: <bfacff27-e3b2-43e8-b50e-3da0f13feb5c@linaro.org> (raw)
In-Reply-To: <20230812183218.374157-1-david@ixit.cz>
On 12.08.2023 20:32, David Heidelberg wrote:
> Fixes warning generated by `make qcom-msm8960-cdp.dtb`:
> arch/arm/boot/dts/qcom-msm8960-cdp.dt.yaml: /: memory: False schema does not allow {'device_type': ['memory'], 'reg': [[0, 0]]}
>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
But does it really?
i.e., if you boot it on a device and xxd /sys/firmware/devicetree/base/memory
or decompile /sys/firmware/fdt, is it updated to <0x0 0xsomesize>?
Konrad
> arch/arm/boot/dts/qcom/qcom-msm8960.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
> index c10797f3793c..c20f16845a97 100644
> --- a/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
> +++ b/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
> @@ -47,7 +47,7 @@ L2: l2-cache {
> };
> };
>
> - memory {
> + memory@0 {
> device_type = "memory";
> reg = <0x0 0x0>;
> };
next prev parent reply other threads:[~2023-08-25 11:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-12 18:32 [PATCH] ARM: dts: qcom: apq8960: reflect that memory node starts at offset 0 David Heidelberg
2023-08-25 11:57 ` Konrad Dybcio [this message]
2024-07-05 22:30 ` David Heidelberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfacff27-e3b2-43e8-b50e-3da0f13feb5c@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).