From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Svyatoslav Ryhel <clamor95@gmail.com>, Mark Brown <broonie@kernel.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
Jean Delvare <jdelvare@suse.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/2] dt-bindings: hwmon: ina2xx: add supply property
Date: Wed, 8 Mar 2023 14:13:06 +0100 [thread overview]
Message-ID: <bfb859da-ea8e-50a1-81b0-7f84a55e930f@linaro.org> (raw)
In-Reply-To: <6DBD0F5A-4625-4FCD-8D64-23293D734A82@gmail.com>
On 08/03/2023 13:58, Svyatoslav Ryhel wrote:
>
>
> 8 березня 2023 р. 14:54:34 GMT+02:00, Mark Brown <broonie@kernel.org> написав(-ла):
>> On Wed, Mar 08, 2023 at 11:40:23AM +0200, Svyatoslav Ryhel wrote:
>>> Add supply property.
>>
>>> + vdd-supply: true
>>> +
>>> required:
>>> - compatible
>>> - reg
>>
>> Unless the device can work without power the supply should be required.
>
> Device can work without supply defined on most devices,
Are you sure they can work without any power? INA231 does not say VS
supply is optional. Datasheet says:
"The INA231 is typically powered by a separate supply that can range
from 2.7 V to 5.5 V."
Although it uses word "typically" which could suggest other design, but
are you sure it can work without it? From where it gets the power?
> but in my case power is gated with gpio and devices will not work
without fixed regulator.
BTW, wrap your lines to match mailing list style.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-08 13:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 9:40 [PATCH v1 0/2] Add optional power supply for INA2XX Svyatoslav Ryhel
2023-03-08 9:40 ` [PATCH v1 1/2] dt-bindings: hwmon: ina2xx: add supply property Svyatoslav Ryhel
2023-03-08 10:27 ` Krzysztof Kozlowski
2023-03-08 10:32 ` Svyatoslav Ryhel
2023-03-08 10:36 ` Krzysztof Kozlowski
2023-03-08 11:35 ` Guenter Roeck
2023-03-08 11:54 ` Svyatoslav Ryhel
2023-03-08 12:54 ` Mark Brown
2023-03-08 12:58 ` Svyatoslav Ryhel
2023-03-08 13:13 ` Krzysztof Kozlowski [this message]
2023-03-08 13:46 ` Mark Brown
2023-03-08 14:01 ` Svyatoslav Ryhel
2023-03-08 14:37 ` Krzysztof Kozlowski
2023-03-08 14:38 ` Mark Brown
2023-03-08 9:40 ` [PATCH v1 2/2] hwmon: ina2xx: add optional regulator support Svyatoslav Ryhel
2023-03-08 10:25 ` Krzysztof Kozlowski
2023-03-08 10:35 ` Svyatoslav Ryhel
2023-03-08 10:37 ` Krzysztof Kozlowski
2023-03-08 11:13 ` Guenter Roeck
2023-03-08 11:19 ` Svyatoslav Ryhel
2023-03-08 11:32 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfb859da-ea8e-50a1-81b0-7f84a55e930f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=broonie@kernel.org \
--cc=clamor95@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox