From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Naman Jain <quic_namajain@quicinc.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_pkondeti@quicinc.com,
quic_kaushalk@quicinc.com, quic_rohiagar@quicinc.com,
kernel@quicinc.com
Subject: Re: [PATCH] dt-bindings: firmware: Add documentation for qcom,platform-parts-info
Date: Mon, 4 Sep 2023 18:04:32 +0200 [thread overview]
Message-ID: <bfd34bb8-0fb1-4984-8af5-3651b4a1a74c@linaro.org> (raw)
In-Reply-To: <359ba91d-866b-45e4-83fe-598ed791f877@quicinc.com>
On 4.09.2023 10:38, Naman Jain wrote:
>
> On 9/1/2023 12:52 PM, Krzysztof Kozlowski wrote:
>> On 01/09/2023 08:02, Naman Jain wrote:
>>> Add documentation to describe device tree bindings for QCOM's
>>> platform-parts-info node. Firmware populates these nodes to pass the
>>> information to kernel regarding the subset of hardware blocks
>>> and features like Camera, Modem, Display present in a product.
>>>
>>> This is to support that the same software image runs seamlessly on
>>> different platforms where one or more HW blocks are not supported or
>>> if some sub parts for a particular block are not supported.
>>>
>>> Purpose of these definitions is to allow clients to know about this,
>>> and thus, handle these cases gracefully.
>> Whether camera is or is not supported, is defined by presence of camera
>> node or by its status field.
>>
>> Existing firmware (e.g. U-Boot) is also doing this - patching DTS when
>> needed.
>>
>> I do not think introducing some parallel way makes any sense, so no,
>> that's not the way to do it.
>>
>> Best regards,
>> Krzysztof
>
>
> Thanks Krzysztof for reviewing the patch. I think for telling whether the Camera HW block is not
> supported / not present, firmware can either remove the device tree node, or change its status
> to disabled, so that is fine.
Messing with the device tree for no reason (e.g. filling in
/memory@something/reg is expected) or without user intervention
(e.g. static DTBO flashed by the user) is not favored.
Konrad
prev parent reply other threads:[~2023-09-04 16:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 6:02 [PATCH] dt-bindings: firmware: Add documentation for qcom,platform-parts-info Naman Jain
2023-09-01 7:22 ` Krzysztof Kozlowski
2023-09-04 8:38 ` Naman Jain
2023-09-04 9:32 ` Krzysztof Kozlowski
2023-09-04 16:04 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfd34bb8-0fb1-4984-8af5-3651b4a1a74c@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@quicinc.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_kaushalk@quicinc.com \
--cc=quic_namajain@quicinc.com \
--cc=quic_pkondeti@quicinc.com \
--cc=quic_rohiagar@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).