From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A677C433EF for ; Tue, 5 Jul 2022 15:01:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229648AbiGEPBt (ORCPT ); Tue, 5 Jul 2022 11:01:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229617AbiGEPBs (ORCPT ); Tue, 5 Jul 2022 11:01:48 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54081140F8; Tue, 5 Jul 2022 08:01:46 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 75E7C6601942; Tue, 5 Jul 2022 16:01:43 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1657033304; bh=7dtkO8dKzSBEwSst0VDFjIf/IrxOZjXKOGrdhYNUMhs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=fa8YbXeEA22ARE8Gt66rR7VDYWziyJUa0DuNZEFX+8Z0Kfw3T3xNWcoRwKjia/3Vk VFa556wih1Hwvt9Mw5U3v4HIUITRHJbLEDK/04ybrSeAJbaqa5VNXRiHzPcQZrYXkx +OM/edmkCMiGvH4vvCFDW5NflyCnwlcR+PNjM7UBmkwLGUer3ExlES6MhD5/6Icmyj Yn7FcBN0nJE85U+9IuErpPjFQBVv9Ag6ij2btLkcUhFIR4RJLXeUdjl9Sof2+bNBvy dDg4rp8fbpum/S6brzpPGBUuz3ihDwq9mmGmHWQAqKEx7w3xJcmgtrTu9+Q1BI07Ju FOJwyiVZHkUMg== Message-ID: Date: Tue, 5 Jul 2022 17:01:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v4 00/19] Introduce support for MediaTek MT8192 Google Chromebooks Content-Language: en-US To: =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , Chen-Yu Tsai Cc: Matthias Brugger , kernel@collabora.com, Allen-KH Cheng , Fabien Parent , Hsin-Yi Wang , Krzysztof Kozlowski , Luca Weiss , Maxim Kutnij , Rob Herring , Sam Shih , Sean Wang , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org References: <20220629155956.1138955-1-nfraprado@collabora.com> <20220701150145.2myyk2o3vxydyhql@notapiano> <20220705135611.jlfltaormhcpuutc@notapiano> From: AngeloGioacchino Del Regno In-Reply-To: <20220705135611.jlfltaormhcpuutc@notapiano> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Il 05/07/22 15:56, Nícolas F. R. A. Prado ha scritto: > On Tue, Jul 05, 2022 at 12:03:08PM +0800, Chen-Yu Tsai wrote: >> On Fri, Jul 1, 2022 at 11:01 PM Nícolas F. R. A. Prado >> wrote: >>> >>> On Fri, Jul 01, 2022 at 08:44:53PM +0800, Chen-Yu Tsai wrote: >>>> On Thu, Jun 30, 2022 at 12:00 AM Nícolas F. R. A. Prado >>>> wrote: >>>>> >>>>> >>>>> This series introduces Devicetrees for the MT8192-based Asurada platform >>>>> as well as Asurada Spherion and Asurada Hayato boards. >>>>> >>>>> Support for the boards is added to the extent that is currently enabled >>>>> in the mt8192.dtsi, and using only properties already merged in the >>>>> dt-bindings, as to not add any dependencies to this series. >>>>> >>>>> This series was peer-reviewed internally before submission. >>>>> >>>>> Series tested on next-20220629. >>>> >>>> Just FYI I also got the internal display to work after some fixes to >>>> the dtsi [1] and copying the stuff over from the ChromeOS kernel tree. >>>> >>>> It might be harder to enable the external display, given that we don't >>>> have a good way of describing the weird design of using the DP bridge >>>> also as a mux. See [2] for ongoing discussion. >>> >>> Hi ChenYu, >>> >>> I actually have both the internal and external display working on my local >>> branch [1], but the commits there aren't final, and I'm also following the >>> Type-C switch discussion to update my commits whenever the binding is settled >>> on. >> >> I see. I think the internal display part is more or less final. It should >> be worth including it, as it is a fairly visible indication that things >> are working. > > Yeah, it is final, but not all of the display-related nodes in mt8192.dtsi have > been merged yet [1] and I didn't want to introduce dependencies to the series. > > If that series gets merged before this one, I could add the display to this > series as well, but I'm just worried that by introducing new commits with almost > every new series version, this series might never get reviewed and merged, and > this series is pretty big already. So I'd prefer to leave the display for a > following series. > > Thanks, > Nícolas > > [1] https://lore.kernel.org/all/20220701090547.21429-1-allen-kh.cheng@mediatek.com > Matthias, can you please give an advice on that? Thank you, Angelo >> >> ChenYu >> >>> I noticed the lack of the mandatory display aliases in the mt8192 series but >>> somehow missed mentioning that in the review, so thanks for adding that. >>> >>> Thanks, >>> Nícolas >>> >>> [1] https://gitlab.collabora.com/nfraprado/linux/-/commits/mt8192-asurada >>> >>>> >>>> ChenYu >>>> >>>> [1] https://lore.kernel.org/linux-mediatek/CAGXv+5F_Gi_=vV1NSk0AGRVYCa3Q8+gBaE+nv3OJ1AKe2voOwg@mail.gmail.com/ >>>> [2] https://lore.kernel.org/dri-devel/20220622173605.1168416-1-pmalani@chromium.org/ >>>> >>>>> v3: https://lore.kernel.org/all/20220512205602.158273-1-nfraprado@collabora.com/ >>>>> v2: https://lore.kernel.org/all/20220505194550.3094656-1-nfraprado@collabora.com/ >>>>> v1: https://lore.kernel.org/all/20220316151327.564214-1-nfraprado@collabora.com/ >>>>> >>>>> Changes in v4: >>>>> - Added patches 17-19 enabling MMC, SCP and SPI NOR flash >>>>> - Switched mediatek,drive-strength-adv for drive-strength-microamp >>>>> - Switched mediatek,pull-up-adv for bias-pull-up >>>>> - Updated Vgpu minimum voltage to appropriate value >>>>> >>>>> Changes in v3: >>>>> - Renamed regulator nodes to be generic >>>>> - Fixed keyboard layout for Hayato >>>>> >>>>> Changes in v2: >>>>> - Added patches 1-2 for Mediatek board dt-bindings >>>>> - Added patches 13-16 enabling hardware for Asurada that has since been >>>>> enabled on mt8192.dtsi >>>>> >>>>> Nícolas F. R. A. Prado (19): >>>>> dt-bindings: arm64: dts: mediatek: Add mt8192-asurada-spherion >>>>> dt-bindings: arm64: dts: mediatek: Add mt8192-asurada-hayato >>>>> arm64: dts: mediatek: Introduce MT8192-based Asurada board family >>>>> arm64: dts: mediatek: asurada: Document GPIO names >>>>> arm64: dts: mediatek: asurada: Add system-wide power supplies >>>>> arm64: dts: mediatek: asurada: Enable and configure I2C and SPI busses >>>>> arm64: dts: mediatek: asurada: Add ChromeOS EC >>>>> arm64: dts: mediatek: asurada: Add keyboard mapping for the top row >>>>> arm64: dts: mediatek: asurada: Add Cr50 TPM >>>>> arm64: dts: mediatek: asurada: Add Elan eKTH3000 I2C trackpad >>>>> arm64: dts: mediatek: asurada: Add I2C touchscreen >>>>> arm64: dts: mediatek: spherion: Add keyboard backlight >>>>> arm64: dts: mediatek: asurada: Enable XHCI >>>>> arm64: dts: mediatek: asurada: Enable PCIe and add WiFi >>>>> arm64: dts: mediatek: asurada: Add MT6359 PMIC >>>>> arm64: dts: mediatek: asurada: Add SPMI regulators >>>>> arm64: dts: mediatek: asurada: Enable MMC >>>>> arm64: dts: mediatek: asurada: Enable SCP >>>>> arm64: dts: mediatek: asurada: Add SPI NOR flash memory >>>>> >>>>> .../devicetree/bindings/arm/mediatek.yaml | 13 + >>>>> arch/arm64/boot/dts/mediatek/Makefile | 2 + >>>>> .../dts/mediatek/mt8192-asurada-hayato-r1.dts | 47 + >>>>> .../mediatek/mt8192-asurada-spherion-r0.dts | 62 ++ >>>>> .../boot/dts/mediatek/mt8192-asurada.dtsi | 959 ++++++++++++++++++ >>>>> 5 files changed, 1083 insertions(+) >>>>> create mode 100644 arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r1.dts >>>>> create mode 100644 arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r0.dts >>>>> create mode 100644 arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi >>>>> >>>>> -- >>>>> 2.36.1 >>>>>