From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jia Jie Ho <jiajie.ho@starfivetech.com>,
Olivia Mackall <olivia@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-crypto@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: rng: starfive: Add jh8100 compatible string
Date: Wed, 6 Dec 2023 11:17:19 +0100 [thread overview]
Message-ID: <c006dd3a-07a2-4d14-899b-72373540ad37@linaro.org> (raw)
In-Reply-To: <20231206014236.1109832-2-jiajie.ho@starfivetech.com>
On 06/12/2023 02:42, Jia Jie Ho wrote:
> Add compatible string for StarFive JH8100 trng.
>
> Signed-off-by: Jia Jie Ho <jiajie.ho@starfivetech.com>
> ---
> .../devicetree/bindings/rng/starfive,jh7110-trng.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml b/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml
> index 2b76ce25acc4..d275bdc4d009 100644
> --- a/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml
> +++ b/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml
> @@ -11,7 +11,9 @@ maintainers:
>
> properties:
> compatible:
> - const: starfive,jh7110-trng
> + enum:
> + - starfive,jh7110-trng
> + - starfive,jh8100-trng
Your driver change suggests these are compatible, so express this here
and drop driver change.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-12-06 10:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 1:42 [PATCH 0/3] hwrng: starfive: Add support for JH8100 Jia Jie Ho
2023-12-06 1:42 ` [PATCH 1/3] dt-bindings: rng: starfive: Add jh8100 compatible string Jia Jie Ho
2023-12-06 10:17 ` Krzysztof Kozlowski [this message]
2023-12-07 2:33 ` Jia Jie Ho
2023-12-06 1:42 ` [PATCH 2/3] hwrng: starfive - Update " Jia Jie Ho
2023-12-06 1:42 ` [PATCH 3/3] hwrng: starfive - Add suspend-to-idle support Jia Jie Ho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c006dd3a-07a2-4d14-899b-72373540ad37@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=jiajie.ho@starfivetech.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olivia@selenic.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).