devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Johan Hovold <johan@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] arm64: dts: qcom: align OPP table node name with DT schema
Date: Wed, 28 Dec 2022 10:38:27 +0100	[thread overview]
Message-ID: <c0142eb6-aa46-a157-6a9a-9134c7e06ca2@linaro.org> (raw)
In-Reply-To: <Y6somGn+V0CAxVA5@hovoldconsulting.com>

On 27/12/2022 18:17, Johan Hovold wrote:
> On Sun, Dec 25, 2022 at 12:58:42PM +0100, Krzysztof Kozlowski wrote:
>> Bindings expect OPP tables to start with "opp-table".
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>>  arch/arm64/boot/dts/qcom/msm8996-v3.0.dtsi | 2 +-
>>  arch/arm64/boot/dts/qcom/sa8540p.dtsi      | 4 ++--
>>  arch/arm64/boot/dts/qcom/sc8280xp.dtsi     | 6 +++---
>>  arch/arm64/boot/dts/qcom/sdm845.dtsi       | 2 +-
>>  4 files changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/msm8996-v3.0.dtsi b/arch/arm64/boot/dts/qcom/msm8996-v3.0.dtsi
>> index 5728583af41e..929bdcd45d02 100644
>  
>> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
>> index 109c9d2b684d..89004cb657e0 100644
>> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
>> @@ -33,7 +33,7 @@ sleep_clk: sleep-clk {
>>  		};
>>  	};
>>  
>> -	cpu0_opp_table: cpu0-opp-table {
>> +	cpu0_opp_table: opp-table-cpu0 {
>>  		compatible = "operating-points-v2";
>>  		opp-shared;
>>  
>> @@ -123,7 +123,7 @@ opp-2438400000 {
>>  		};
>>  	};
>>  
>> -	cpu4_opp_table: cpu4-opp-table {
>> +	cpu4_opp_table: opp-table-cpu4 {
>>  		compatible = "operating-points-v2";
>>  		opp-shared;
>>  
>> @@ -591,7 +591,7 @@ CLUSTER_PD: cpu-cluster0 {
>>  		};
>>  	};
>>  
>> -	qup_opp_table_100mhz: qup-100mhz-opp-table {
>> +	qup_opp_table_100mhz: opp-table-qup100mhz {
>>  		compatible = "operating-points-v2";
>>  
>>  		opp-75000000 {
> 
> Please also move these nodes after the 'memory' node so that they remain
> sorted by name.

OK

Best regards,
Krzysztof


  reply	other threads:[~2022-12-28  9:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-25 11:58 [PATCH 1/4] ARM: dts: qcom: align OPP table node name with DT schema Krzysztof Kozlowski
2022-12-25 11:58 ` [PATCH 2/4] arm64: " Krzysztof Kozlowski
2022-12-27 11:19   ` Konrad Dybcio
2022-12-27 17:17   ` Johan Hovold
2022-12-28  9:38     ` Krzysztof Kozlowski [this message]
2022-12-25 11:58 ` [PATCH 3/4] arm64: dts: qcom: sm8250: drop unused clock-frequency from wsa-macro Krzysztof Kozlowski
2022-12-27 11:18   ` Konrad Dybcio
2022-12-25 11:58 ` [PATCH 4/4] arm64: dts: qcom: sm8250: drop unused properties from tx-macro Krzysztof Kozlowski
2022-12-27 11:19   ` Konrad Dybcio
2022-12-27 11:18 ` [PATCH 1/4] ARM: dts: qcom: align OPP table node name with DT schema Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0142eb6-aa46-a157-6a9a-9134c7e06ca2@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=johan@kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).