* [PATCH] arm64: dts: qcom: sdm850-lenovo-yoga: Add wakeup-sources
@ 2023-11-07 0:12 Steev Klimaszewski via B4 Relay
2023-11-07 21:26 ` Konrad Dybcio
0 siblings, 1 reply; 2+ messages in thread
From: Steev Klimaszewski via B4 Relay @ 2023-11-07 0:12 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Steev Klimaszewski
From: Steev Klimaszewski <steev@kali.org>
The keyboard, touchpad and touchscreen can all be used to wake the
computer up from sleep, so mark them as such in the dts file.
Signed-off-by: Steev Klimaszewski <steev@kali.org>
---
It would be nice to wake up the Lenovo Yoga C630 from suspend by hitting
the keyboard or touchpad or even touchscreen, so this patch enables that
ability.
I'm not married to enabling it for the touchscreen, so if anyone wants
me to drop that hunk, I'd be fine with it.
---
arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
index 92a812b5f423..9ddffb98408d 100644
--- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
+++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
@@ -384,6 +384,8 @@ tsel: hid@15 {
hid-descr-addr = <0x1>;
interrupts-extended = <&tlmm 37 IRQ_TYPE_LEVEL_HIGH>;
+
+ wakeup-source;
};
tsc2: hid@2c {
@@ -392,6 +394,8 @@ tsc2: hid@2c {
hid-descr-addr = <0x20>;
interrupts-extended = <&tlmm 37 IRQ_TYPE_LEVEL_HIGH>;
+
+ wakeup-source;
};
};
@@ -408,6 +412,8 @@ tsc1: hid@10 {
pinctrl-names = "default";
pinctrl-0 = <&i2c5_hid_active>;
+
+ wakeup-source;
};
};
@@ -482,6 +488,8 @@ ecsh: hid@5c {
pinctrl-names = "default";
pinctrl-0 = <&i2c11_hid_active>;
+
+ wakeup-source;
};
};
---
base-commit: 3ff7a5781ceee3befb9224d29cef6e6a4766c5fe
change-id: 20231106-wakeup-source-15af6f5a6329
Best regards,
--
Steev Klimaszewski <steev@kali.org>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sdm850-lenovo-yoga: Add wakeup-sources
2023-11-07 0:12 [PATCH] arm64: dts: qcom: sdm850-lenovo-yoga: Add wakeup-sources Steev Klimaszewski via B4 Relay
@ 2023-11-07 21:26 ` Konrad Dybcio
0 siblings, 0 replies; 2+ messages in thread
From: Konrad Dybcio @ 2023-11-07 21:26 UTC (permalink / raw)
To: steev, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel
On 11/7/23 01:12, Steev Klimaszewski via B4 Relay wrote:
> From: Steev Klimaszewski <steev@kali.org>
>
> The keyboard, touchpad and touchscreen can all be used to wake the
> computer up from sleep, so mark them as such in the dts file.
>
> Signed-off-by: Steev Klimaszewski <steev@kali.org>
> ---
> It would be nice to wake up the Lenovo Yoga C630 from suspend by hitting
> the keyboard or touchpad or even touchscreen, so this patch enables that
> ability.
>
> I'm not married to enabling it for the touchscreen, so if anyone wants
> me to drop that hunk, I'd be fine with it.
Does the touchscreen power off? Would touching it when the laptop is
asleep wake the device up? If so, I'd say that leaving it out makes
more sense by default
Konrad
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-07 21:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-07 0:12 [PATCH] arm64: dts: qcom: sdm850-lenovo-yoga: Add wakeup-sources Steev Klimaszewski via B4 Relay
2023-11-07 21:26 ` Konrad Dybcio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).