From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF0F01371 for ; Tue, 7 Nov 2023 21:26:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lZ/lXuYl" Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B03A812F for ; Tue, 7 Nov 2023 13:26:25 -0800 (PST) Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-507b96095abso7820486e87.3 for ; Tue, 07 Nov 2023 13:26:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699392384; x=1699997184; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=v8ZbabYnEZ0TbrYO0L9GGQTYabN7EWJlrXz4ovvinYE=; b=lZ/lXuYleOyNqWTK8ZA4sjS2tO+gvQdpLhmWJmF1TCX0whdZjac6mdl2CnDi7xaNrR 5rBpTb0qXh+a97HZzN3KrFdyi3lT6qZiGwnYarCdb7bBd3OVNnqjOQyAX7EFqx2j23OW k+Ysxq9nzyqToJAuM4GrGo3R3BW3dIUOlV+CbXO3Yv6KxRLuSCT5q6HF25QnnL2vioYp 5yPwSfi8EbVsRUUJecpX97JZa5pjickrk1n5RPxlxuo4Mo5qniwNKJlN9cw5xlERc7hk ObNNNxVP3wPECg2GRfOdgKo3XC8xzoC1qgM+TcTbKfIRKYSQZdN5WqF9y4DPMzRWeYSF 2pzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699392384; x=1699997184; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=v8ZbabYnEZ0TbrYO0L9GGQTYabN7EWJlrXz4ovvinYE=; b=A+dDFGUkypksBaEkc90hQwXUYVk0uB2oOhCJqNRnDcgzs9s8NYlP4lDYN7yCRtckXB 593yBFE2gr1A65XCyXiu73CaNGTYhTyW3pg8DU6pm8FniJfsliC/6rSjXOv8//tcYJF4 gQvv7KeYFXHQpjpFXwHld+Q1fGxou8kXaVRoBga+M6rTL7LFChdnNbcbX4SisyQHqaWc GBTBUXxMi4WULZB9yi+g8KAJIqm4AvTwGlfFog0QV9wyPo2C3U7YmNo8b9Nm/mTRF+Zh egnpJqMqqcjw2tgsBg9+DyNxH3dzMy/ngEEaTXgt7hL2j2zrOSkgjUFMQ8OmsDY4bUBJ Jp5A== X-Gm-Message-State: AOJu0YzmqwKVl/y6m3qWlOv+TCRwpFwdA5hQKnZXLups8ehGfDpYGLJ/ myqDsj1qaytfK3rl1CQ6B6OHIjhmw3+yyob+ahZWtw== X-Google-Smtp-Source: AGHT+IHgLJN+d/IqcqroFzMDSTAI3G6hIBS/d7pJb3zhOOeHlWT4o81L0maEKBm4+T2uZ7Y4KtUPDg== X-Received: by 2002:a05:6512:31d0:b0:508:1332:558a with SMTP id j16-20020a05651231d000b005081332558amr31609895lfe.2.1699392383665; Tue, 07 Nov 2023 13:26:23 -0800 (PST) Received: from [172.30.205.109] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id t14-20020ac243ae000000b005094bb01fc4sm457208lfl.275.2023.11.07.13.26.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Nov 2023 13:26:23 -0800 (PST) Message-ID: Date: Tue, 7 Nov 2023 22:26:20 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: sdm850-lenovo-yoga: Add wakeup-sources Content-Language: en-US To: steev@kali.org, Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231106-wakeup-source-v1-1-36b1f39e67fd@kali.org> From: Konrad Dybcio In-Reply-To: <20231106-wakeup-source-v1-1-36b1f39e67fd@kali.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/7/23 01:12, Steev Klimaszewski via B4 Relay wrote: > From: Steev Klimaszewski > > The keyboard, touchpad and touchscreen can all be used to wake the > computer up from sleep, so mark them as such in the dts file. > > Signed-off-by: Steev Klimaszewski > --- > It would be nice to wake up the Lenovo Yoga C630 from suspend by hitting > the keyboard or touchpad or even touchscreen, so this patch enables that > ability. > > I'm not married to enabling it for the touchscreen, so if anyone wants > me to drop that hunk, I'd be fine with it. Does the touchscreen power off? Would touching it when the laptop is asleep wake the device up? If so, I'd say that leaving it out makes more sense by default Konrad