From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42F06EB64D7 for ; Tue, 20 Jun 2023 06:19:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230268AbjFTGT3 (ORCPT ); Tue, 20 Jun 2023 02:19:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230235AbjFTGT2 (ORCPT ); Tue, 20 Jun 2023 02:19:28 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D66EA10D7 for ; Mon, 19 Jun 2023 23:19:26 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-4f7deee339dso5194570e87.0 for ; Mon, 19 Jun 2023 23:19:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687241965; x=1689833965; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oO29vTyH00u9Cnemrj5+OqL3rJnNJVkGd7KyzUdckJc=; b=hhdBu0W0qX/0/mlBgaMXaWbidX+xQtAYl6qYY+nmVWaza8SKXp8lBxfRt5xhYLWeKs PhgczPVyujwWmSC3ENjjPyOBy68r7jBItGsyQJfBSfKe1Z0p1sFMZFGhHgKMtOcOPlRY L1u/Ip5qIvpvReKWaCRb250l26d6M5goqG8H4r9Sk+OnFl/2OuvTszgDkCGu3VqqyLBI ZNEdyBYQ+amc3AxWZ9rzjXyTNWYbUQj2yzg/P3fX3AUn2tgMr40B0JdBvQ0FX1amZZim UgZgYdaInNdGZ4WUU/IFcmKxqEWecp5ryF3B2ms5whBegxaZQ91ilzhe5laJK9Ri9jro aSmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687241965; x=1689833965; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oO29vTyH00u9Cnemrj5+OqL3rJnNJVkGd7KyzUdckJc=; b=fylHwwAu0ODUxSwQ7Ve2xtP5RBkRswilIOp4yJQPJRYAuYhDEAfPcd2137+AvIFjzV rwFBuVmegXP8vdQytGRPep4MWIig1mAPlS+v/j0Ac13ORJFOgphkHRowoaX9ux9Z3WCJ q7eciJEMptvMUKx+251EObwROCT2drjNczL3vzifGxrGEYD37FU+NqrRFC76lcFzpfyV 3c23MCccfLpJeTZ4tVHHIEGIqNMXpumTSfZ2/A8IhpwxbnG7Wbsy2Xsjobx/JPoPbKWY FMGXkdsyTXYK7JUo6wbDy8PDl2Bc8dhVl+YcSub+7BhNyDe8uoAaagcjM2J3FkTW4Ox9 xDRQ== X-Gm-Message-State: AC+VfDyWV5LZIhtot6obAXxe8QwAA6yIutPIK4I2uHnNAs6LfEHhCBfO SlbFbq5GIoZ5tcujqjkyC7PXPA== X-Google-Smtp-Source: ACHHUZ7usY0XPsrJHRsdCyO8q/9zfJ/EGU8VDFSPYhYiP4eZgWJnkQnPQtutOJF8jpavCoGfWRglig== X-Received: by 2002:a19:6909:0:b0:4f8:6d54:72fb with SMTP id e9-20020a196909000000b004f86d5472fbmr2856355lfc.62.1687241965041; Mon, 19 Jun 2023 23:19:25 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id x7-20020a5d54c7000000b0031270cf1904sm1181896wrv.59.2023.06.19.23.19.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Jun 2023 23:19:24 -0700 (PDT) Message-ID: Date: Tue, 20 Jun 2023 08:19:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCHv3 2/2] arm64: dts: rockchip: add dts for Firefly Station P2 aka rk3568-roc-pc To: Furkan Kardame , robh+dt@kernel.org Cc: krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, heiko@sntech.de, broonie@kernel.org, deller@gmx.de, dsterba@suse.com, arnd@arndb.de, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230619184856.23066-1-f.kardame@manjaro.org> <20230619184856.23066-3-f.kardame@manjaro.org> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <20230619184856.23066-3-f.kardame@manjaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 19/06/2023 20:48, Furkan Kardame wrote: > Add dts for Firefly Station P2. > Working IO: > * eMMC > * HDMI > * LAN > * LED > * SD Card > * UART > * USB2 > * USB3 ... > + }; > + > + hdmi-con { > + compatible = "hdmi-connector"; > + type = "a"; > + > + port { > + hdmi_con_in: endpoint { > + remote-endpoint = <&hdmi_out_con>; Missing indentation. ... > + > + vcc3v3_lcd0_n: vcc3v3-lcd0-n-regulator { > + compatible = "regulator-fixed"; > + regulator-name = "vcc3v3_lcd0_n"; > + regulator-boot-on; > + > + regulator-state-mem { > + regulator-off-in-suspend; How do you turn this regulator off in suspend? > + }; > + }; > + > + vcc3v3_lcd1_n: vcc3v3-lcd1-n-regulator { > + compatible = "regulator-fixed"; > + regulator-name = "vcc3v3_lcd1_n"; > + regulator-boot-on; > + > + regulator-state-mem { > + regulator-off-in-suspend; Same question here. > + }; > + }; > +}; Best regards, Krzysztof